fix: Fix BB bug #2488
fix: Fix BB bug #2488
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2488 +/- ##
=====================================
Coverage 98.26 98.26
=====================================
Files 773 773
Lines 9866 9866
Branches 2473 2519 +46
=====================================
Hits 9694 9694
Misses 170 170
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2488 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 773 773
Lines 9866 9866
Branches 2519 2519
=======================================
Hits 9694 9694
Misses 170 170
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #2488 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 773 773
Lines 9866 9866
Branches 2524 2519 -5
=======================================
Hits 9694 9694
Misses 170 170
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2488 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 773 773
Lines 9866 9866
Branches 2524 2519 -5
=======================================
Hits 9694 9694
Misses 170 170
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Description
we counted on the fact that users would have at least email when they login to Codecov, but we realised BB users can have both business email and email null, this is changing Zod schema to accommodate such use case .
Screenshots
before.mov
after.mov
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.