Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create hook to fetch bundle analysis summary for a commit #2493

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR adds in a new hook that will be used to get the information required for the bundle analysis dropdown that will be used when both Coverage and a Bundle analysis data is present inside a repo for a given commit.

GH codecov/engineering-team#992

Notable Changes

  • Create new useCommitBADropdownSummary hook
  • Write up tests for useCommitBADropdownSummary

@codecov-staging
Copy link

codecov-staging bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2493   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         775      776    +1     
  Lines        9896     9914   +18     
  Branches     2483     2486    +3     
=======================================
+ Hits         9721     9739   +18     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
src/services/commit/useCommitBADropdownSummary.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 99.22% <ø> (ø)
Services 99.45% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <ø> (ø)
UI 94.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f26e347...f016084. Read the comment docs.

Copy link

codecov-public-qa bot commented Jan 8, 2024

Codecov Report

Merging #2493 (f016084) into main (f26e347) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2493   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         775      776    +1     
  Lines        9896     9914   +18     
  Branches     2534     2537    +3     
=======================================
+ Hits         9721     9739   +18     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
src/services/commit/useCommitBADropdownSummary.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 99.22% <ø> (ø)
Services 99.45% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <ø> (ø)
UI 94.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f26e347...f016084. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f26e347) 98.23% compared to head (f016084) 98.23%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2493   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         775      776    +1     
  Lines        9896     9914   +18     
  Branches     2529     2532    +3     
=======================================
+ Hits         9721     9739   +18     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
src/services/commit/useCommitBADropdownSummary.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 99.22% <ø> (ø)
Services 99.45% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <ø> (ø)
UI 94.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f26e347...f016084. Read the comment docs.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f26e347) 98.23% compared to head (f016084) 98.23%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2493   +/-   ##
=====================================
  Coverage   98.23   98.23           
=====================================
  Files        775     776    +1     
  Lines       9896    9914   +18     
  Branches    2485    2532   +47     
=====================================
+ Hits        9721    9739   +18     
  Misses       173     173           
  Partials       2       2           
Files Coverage Δ
src/services/commit/useCommitBADropdownSummary.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 99.22% <ø> (ø)
Services 99.45% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <ø> (ø)
UI 94.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f26e347...f016084. Read the comment docs.

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit f016084
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/659c5abc4192f9000838345a
😎 Deploy Preview https://deploy-preview-2493--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nicholas-codecov nicholas-codecov merged commit 3f96e45 into main Jan 9, 2024
57 of 58 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-992-create-hook-to-fetch-bundle-analysis-summary-for-a-commit branch January 9, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants