Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create hook to fetch a list of bundles for a pull #2496

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR adds in a new hook that fetches a list of bundles for a given pull.

GH codecov/engineering-team#993

Notable Changes

  • Create new usePullBundleList hook
  • Write up tests for usePullBundleList

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit a3742e4
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/659fdde7444a8f0009fb86a3
😎 Deploy Preview https://deploy-preview-2496--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nicholas-codecov nicholas-codecov force-pushed the gh-eng-993-create-hook-to-fetch-a-list-of-bundles-for-a-pull branch from 67901b1 to a3742e4 Compare January 11, 2024 12:24
@codecov-qa
Copy link

codecov-qa bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d871d87) 98.24% compared to head (a3742e4) 98.24%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2496   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         781      782    +1     
  Lines        9948     9968   +20     
  Branches     2517     2491   -26     
=======================================
+ Hits         9773     9793   +20     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
src/services/pull/usePullBundleList.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.23% <ø> (ø)
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d871d87...a3742e4. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2496   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         781      782    +1     
  Lines        9948     9968   +20     
  Branches     2485     2489    +4     
=======================================
+ Hits         9773     9793   +20     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
src/services/pull/usePullBundleList.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.23% <ø> (ø)
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d871d87...a3742e4. Read the comment docs.

Copy link

Codecov Report

Merging #2496 (a3742e4) into main (d871d87) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2496   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         781      782    +1     
  Lines        9948     9968   +20     
  Branches     2531     2489   -42     
=======================================
+ Hits         9773     9793   +20     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
src/services/pull/usePullBundleList.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.23% <ø> (ø)
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d871d87...a3742e4. Read the comment docs.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d871d87) 98.24% compared to head (a3742e4) 98.24%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2496   +/-   ##
=====================================
  Coverage   98.24   98.24           
=====================================
  Files        781     782    +1     
  Lines       9948    9968   +20     
  Branches    2536    2540    +4     
=====================================
+ Hits        9773    9793   +20     
  Misses       173     173           
  Partials       2       2           
Files Coverage Δ
src/services/pull/usePullBundleList.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.23% <ø> (ø)
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d871d87...a3742e4. Read the comment docs.

@nicholas-codecov nicholas-codecov merged commit c456ca5 into main Jan 11, 2024
58 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-993-create-hook-to-fetch-a-list-of-bundles-for-a-pull branch January 11, 2024 14:47
RulaKhaled pushed a commit that referenced this pull request Jan 11, 2024
Add in a hook that fetches a list of bundles for a given pull request.

GH codecov/engineering-team#993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants