Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useResyncUser causing Docker builds to fail #2500

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

For whatever reason eslint is causing the builds to fail because useResyncUser is using a callback that is going to be deprecated in the next version of TanStack query. This PR removes the callback instead moving the functionality into a useEffect as recommended in the migration guide.

Copy link

codecov-public-qa bot commented Jan 10, 2024

Codecov Report

Merging #2500 (346754e) into main (c25582c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2500   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         781      781           
  Lines        9946     9948    +2     
  Branches     2530     2517   -13     
=======================================
+ Hits         9771     9773    +2     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
src/services/user/useResyncUser.js 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.23% <ø> (ø)
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c25582c...346754e. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2500   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         781      781           
  Lines        9946     9948    +2     
  Branches     2484     2487    +3     
=======================================
+ Hits         9771     9773    +2     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
src/services/user/useResyncUser.js 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.23% <ø> (ø)
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c25582c...346754e. Read the comment docs.

Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 346754e
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/659ee53188189f000878ec01
😎 Deploy Preview https://deploy-preview-2500--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c25582c) 98.24% compared to head (346754e) 98.24%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2500   +/-   ##
=====================================
  Coverage   98.24   98.24           
=====================================
  Files        781     781           
  Lines       9946    9948    +2     
  Branches    2486    2517   +31     
=====================================
+ Hits        9771    9773    +2     
  Misses       173     173           
  Partials       2       2           
Files Coverage Δ
src/services/user/useResyncUser.js 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.23% <ø> (ø)
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c25582c...346754e. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c25582c) 98.24% compared to head (346754e) 98.24%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2500   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         781      781           
  Lines        9946     9948    +2     
  Branches     2530     2517   -13     
=======================================
+ Hits         9771     9773    +2     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
src/services/user/useResyncUser.js 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.23% <ø> (ø)
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c25582c...346754e. Read the comment docs.

@nicholas-codecov nicholas-codecov merged commit 517ec31 into main Jan 10, 2024
58 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-use-resync-user-causing-builds-to-fail branch January 10, 2024 18:53
RulaKhaled pushed a commit that referenced this pull request Jan 11, 2024
Swap to using useEffect over soon to be removed onSuccess in useResyncUser.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants