ref: Move coverage onboarding to coverage tab #2504

nicholas-codecov · 2024-01-11T14:06:20Z

Description

This PR basically enables the tabs on the RepoPage to be rendered (though only the coverage tab, at the moment). This is basically setting things up for having bundle analysis onboarding under a new bundles tab once we reach that stage.

Closes codecov/engineering-team#1023

Notable Changes

Add new path matcher hook, and refactor to TS
Allow repo page tabs to be rendered when repo is not active or deactivated
Rename NewRepoTab to CoverageOnboarding
Tweak coverage onboarding tab styles
Update tests

Screenshots

codecov · 2024-01-11T14:09:42Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (59bcfb4) 98.26% compared to head (6d82c58) 98.26%.

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #2504   +/-   ##
=====================================
  Coverage   98.26   98.26           
=====================================
  Files        786     786           
  Lines      10073   10083   +10     
  Branches    2550    2506   -44     
=====================================
+ Hits        9898    9908   +10     
  Misses       173     173           
  Partials       2       2

Files	Coverage Δ
.../RepoPage/CoverageOnboarding/CircleCI/CircleCI.jsx	`100.00% <ø> (ø)`
...CoverageOnboarding/GitHubActions/GitHubActions.tsx	`100.00% <ø> (ø)`
...c/pages/RepoPage/CoverageOnboarding/NewRepoTab.jsx	`100.00% <ø> (ø)`
...es/RepoPage/CoverageOnboarding/OtherCI/OtherCI.jsx	`100.00% <ø> (ø)`
...ng/OtherCI/TerminalInstructions/InstructionBox.jsx	`100.00% <ø> (ø)`
src/pages/RepoPage/RepoPage.jsx	`100.00% <100.00%> (ø)`
src/pages/RepoPage/hooks/pathMatchersHooks.ts	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`59.37% <ø> (ø)`
Layouts	`96.95% <ø> (ø)`
Pages	`99.24% <100.00%> (+<0.01%)`	⬆️
Services	`99.49% <ø> (ø)`
Shared	`99.82% <ø> (ø)`
UI	`94.23% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59bcfb4...6d82c58. Read the comment docs.

netlify · 2024-01-11T14:10:06Z

✅ Deploy Preview for gazebo-staging ready!

Name	Link
🔨 Latest commit	`6d82c58`
🔍 Latest deploy log	https://app.netlify.com/sites/gazebo-staging/deploys/65a53c9a39f9450008db289f
😎 Deploy Preview	https://deploy-preview-2504--gazebo-staging.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov-staging · 2024-01-11T14:49:57Z

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff           @@
##             main    #2504   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files         786      786           
  Lines       10073    10083   +10     
  Branches     2536     2550   +14     
=======================================
+ Hits         9898     9908   +10     
  Misses        173      173           
  Partials        2        2

Files	Coverage Δ
.../RepoPage/CoverageOnboarding/CircleCI/CircleCI.jsx	`100.00% <ø> (ø)`
...CoverageOnboarding/GitHubActions/GitHubActions.tsx	`100.00% <ø> (ø)`
...c/pages/RepoPage/CoverageOnboarding/NewRepoTab.jsx	`100.00% <ø> (ø)`
...es/RepoPage/CoverageOnboarding/OtherCI/OtherCI.jsx	`100.00% <ø> (ø)`
...ng/OtherCI/TerminalInstructions/InstructionBox.jsx	`100.00% <ø> (ø)`
src/pages/RepoPage/RepoPage.jsx	`100.00% <100.00%> (ø)`
src/pages/RepoPage/hooks/pathMatchersHooks.ts	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`59.37% <ø> (ø)`
Layouts	`96.95% <ø> (ø)`
Pages	`99.24% <100.00%> (+<0.01%)`	⬆️
Services	`99.49% <ø> (ø)`
Shared	`99.82% <ø> (ø)`
UI	`94.23% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59bcfb4...6d82c58. Read the comment docs.

codecov-qa · 2024-01-11T14:52:31Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (59bcfb4) 98.26% compared to head (6d82c58) 98.26%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2504   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files         786      786           
  Lines       10073    10083   +10     
  Branches     2504     2555   +51     
=======================================
+ Hits         9898     9908   +10     
  Misses        173      173           
  Partials        2        2

Files	Coverage Δ
.../RepoPage/CoverageOnboarding/CircleCI/CircleCI.jsx	`100.00% <ø> (ø)`
...CoverageOnboarding/GitHubActions/GitHubActions.tsx	`100.00% <ø> (ø)`
...c/pages/RepoPage/CoverageOnboarding/NewRepoTab.jsx	`100.00% <ø> (ø)`
...es/RepoPage/CoverageOnboarding/OtherCI/OtherCI.jsx	`100.00% <ø> (ø)`
...ng/OtherCI/TerminalInstructions/InstructionBox.jsx	`100.00% <ø> (ø)`
src/pages/RepoPage/RepoPage.jsx	`100.00% <100.00%> (ø)`
src/pages/RepoPage/hooks/pathMatchersHooks.ts	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`59.37% <ø> (ø)`
Layouts	`96.95% <ø> (ø)`
Pages	`99.24% <100.00%> (+<0.01%)`	⬆️
Services	`99.49% <ø> (ø)`
Shared	`99.82% <ø> (ø)`
UI	`94.23% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59bcfb4...6d82c58. Read the comment docs.

RulaKhaled

lgtm

RulaKhaled

can you fix the failing test please, approved otherwise

…rage-tab

codecov-public-qa · 2024-01-11T15:04:59Z

Codecov Report

Merging #2504 (6d82c58) into main (59bcfb4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2504   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files         786      786           
  Lines       10073    10083   +10     
  Branches     2504     2536   +32     
=======================================
+ Hits         9898     9908   +10     
  Misses        173      173           
  Partials        2        2

Files	Coverage Δ
.../RepoPage/CoverageOnboarding/CircleCI/CircleCI.jsx	`100.00% <ø> (ø)`
...CoverageOnboarding/GitHubActions/GitHubActions.tsx	`100.00% <ø> (ø)`
...c/pages/RepoPage/CoverageOnboarding/NewRepoTab.jsx	`100.00% <ø> (ø)`
...es/RepoPage/CoverageOnboarding/OtherCI/OtherCI.jsx	`100.00% <ø> (ø)`
...ng/OtherCI/TerminalInstructions/InstructionBox.jsx	`100.00% <ø> (ø)`
src/pages/RepoPage/RepoPage.jsx	`100.00% <100.00%> (ø)`
src/pages/RepoPage/hooks/pathMatchersHooks.ts	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`59.37% <ø> (ø)`
Layouts	`96.95% <ø> (ø)`
Pages	`99.24% <100.00%> (+<0.01%)`	⬆️
Services	`99.49% <ø> (ø)`
Shared	`99.82% <ø> (ø)`
UI	`94.23% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59bcfb4...6d82c58. Read the comment docs.

…rage-tab

codecovdesign · 2024-01-11T18:31:57Z

@nicholas-codecov looks great! minor sugguestion is adding some padding-top to space out the instructions a bit below the sub-nav

nicholas-codecov · 2024-01-11T19:00:40Z

@nicholas-codecov looks great! minor sugguestion is adding some padding-top to space out the instructions a bit below the sub-nav

Are you talking about the header for the instructions?

…rage-tab

sentry-io · 2024-01-25T12:40:29Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️ React ErrorBoundary TypeError: Failed to fetch graphql(shared/api/api) View Issue

_{Did you find this useful? React with a 👍 or 👎}

nicholas-codecov added 4 commits January 11, 2024 09:38

add new hook to check for onboarding as well as refactor to TS

76c148f

tweak styles of new repo tab

343d9bb

update repo page to display coverage onbording with tab nav

d776eac

rename from new repo tab to coverage onboarding

92e4863

fix up mock in repo page test

f87eca4

RulaKhaled approved these changes Jan 11, 2024

View reviewed changes

RulaKhaled requested changes Jan 11, 2024

View reviewed changes

nicholas-codecov added 2 commits January 11, 2024 11:00

fixed the mock but didn't update the test

ca50037

Merge branch 'main' into gh-eng-1023-move-coverage-onboarding-to-cove…

645ea6c

…rage-tab

RulaKhaled approved these changes Jan 11, 2024

View reviewed changes

nicholas-codecov added 2 commits January 11, 2024 11:43

Merge branch 'main' into gh-eng-1023-move-coverage-onboarding-to-cove…

5d26fbd

…rage-tab

show settings tab when repo is not active

87a58d7

codecovdesign mentioned this pull request Jan 11, 2024

Not yet configured status updated codecov/engineering-team#977

Closed

nicholas-codecov added 6 commits January 12, 2024 07:06

Merge branch 'main' into gh-eng-1023-move-coverage-onboarding-to-cove…

98309df

…rage-tab

add a little more padding to the top

f743792

Merge branch 'main' into gh-eng-1023-move-coverage-onboarding-to-cove…

c653593

…rage-tab

Merge branch 'main' into gh-eng-1023-move-coverage-onboarding-to-cove…

47d4b2e

…rage-tab

Merge branch 'main' into gh-eng-1023-move-coverage-onboarding-to-cove…

6dd99ef

…rage-tab

handle case where tests evenly divide into test indexes

6d82c58

nicholas-codecov merged commit b9ec1c6 into main Jan 15, 2024
58 checks passed

nicholas-codecov deleted the gh-eng-1023-move-coverage-onboarding-to-coverage-tab branch January 15, 2024 18:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ref: Move coverage onboarding to coverage tab #2504

ref: Move coverage onboarding to coverage tab #2504

nicholas-codecov commented Jan 11, 2024

codecov bot commented Jan 11, 2024 •

edited

netlify bot commented Jan 11, 2024 •

edited

codecov-staging bot commented Jan 11, 2024 •

edited

codecov-qa bot commented Jan 11, 2024 •

edited

RulaKhaled left a comment

RulaKhaled left a comment

codecov-public-qa bot commented Jan 11, 2024 •

edited

codecovdesign commented Jan 11, 2024

nicholas-codecov commented Jan 11, 2024

sentry-io bot commented Jan 25, 2024

ref: Move coverage onboarding to coverage tab #2504

ref: Move coverage onboarding to coverage tab #2504

Conversation

nicholas-codecov commented Jan 11, 2024

Description

Notable Changes

Screenshots

codecov bot commented Jan 11, 2024 • edited

Codecov Report

netlify bot commented Jan 11, 2024 • edited

✅ Deploy Preview for gazebo-staging ready!

codecov-staging bot commented Jan 11, 2024 • edited

Codecov Report

codecov-qa bot commented Jan 11, 2024 • edited

Codecov Report

RulaKhaled left a comment

Choose a reason for hiding this comment

RulaKhaled left a comment

Choose a reason for hiding this comment

codecov-public-qa bot commented Jan 11, 2024 • edited

Codecov Report

codecovdesign commented Jan 11, 2024

nicholas-codecov commented Jan 11, 2024

sentry-io bot commented Jan 25, 2024

Suspect Issues

codecov bot commented Jan 11, 2024 •

edited

netlify bot commented Jan 11, 2024 •

edited

codecov-staging bot commented Jan 11, 2024 •

edited

codecov-qa bot commented Jan 11, 2024 •

edited

codecov-public-qa bot commented Jan 11, 2024 •

edited