Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Refactor coverage commits table #2507

Merged
merged 6 commits into from
Jan 15, 2024
Merged

Conversation

RulaKhaled
Copy link
Contributor

Description

Update coverage commits table with the new ui/table

Code Example

Notable Changes

  • new createCommitsTableTeamData to fetch tables data
  • new table
  • tests

Screenshots

Screenshot 2024-01-11 at 4 53 01 PM
Screenshot 2024-01-11 at 4 52 54 PM

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ccc2e46) 98.25% compared to head (0254a18) 98.26%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2507   +/-   ##
=======================================
  Coverage   98.25%   98.26%           
=======================================
  Files         785      786    +1     
  Lines       10053    10073   +20     
  Branches     2504     2550   +46     
=======================================
+ Hits         9878     9898   +20     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
.../RepoPage/CommitsTab/CommitsTable/CommitsTable.tsx 100.00% <100.00%> (ø)
...CommitsTab/CommitsTable/createCommitsTableData.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.24% <100.00%> (+<0.01%) ⬆️
Services 99.49% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccc2e46...0254a18. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2507   +/-   ##
=======================================
  Coverage   98.25%   98.26%           
=======================================
  Files         785      786    +1     
  Lines       10053    10073   +20     
  Branches     2504     2555   +51     
=======================================
+ Hits         9878     9898   +20     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
.../RepoPage/CommitsTab/CommitsTable/CommitsTable.tsx 100.00% <100.00%> (ø)
...CommitsTab/CommitsTable/createCommitsTableData.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.24% <100.00%> (+<0.01%) ⬆️
Services 99.49% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccc2e46...0254a18. Read the comment docs.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ccc2e46) 98.26% compared to head (0254a18) 98.26%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2507   +/-   ##
=====================================
  Coverage   98.26   98.26           
=====================================
  Files        785     786    +1     
  Lines      10053   10073   +20     
  Branches    2548    2536   -12     
=====================================
+ Hits        9878    9898   +20     
  Misses       173     173           
  Partials       2       2           
Files Coverage Δ
.../RepoPage/CommitsTab/CommitsTable/CommitsTable.tsx 100.00% <100.00%> (ø)
...CommitsTab/CommitsTable/createCommitsTableData.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.24% <100.00%> (+<0.01%) ⬆️
Services 99.49% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccc2e46...0254a18. Read the comment docs.

Copy link

codecov-public-qa bot commented Jan 11, 2024

Codecov Report

Merging #2507 (0254a18) into main (ccc2e46) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2507   +/-   ##
=======================================
  Coverage   98.25%   98.26%           
=======================================
  Files         785      786    +1     
  Lines       10053    10073   +20     
  Branches     2534     2506   -28     
=======================================
+ Hits         9878     9898   +20     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
.../RepoPage/CommitsTab/CommitsTable/CommitsTable.tsx 100.00% <100.00%> (ø)
...CommitsTab/CommitsTable/createCommitsTableData.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.24% <100.00%> (+<0.01%) ⬆️
Services 99.49% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccc2e46...0254a18. Read the comment docs.

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 0254a18
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65a52132dc580f0007a46b31
😎 Deploy Preview https://deploy-preview-2507--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick change

Comment on lines 41 to 45
name: JSX.Element
coverage: JSX.Element
ciStatus: JSX.Element
patch: JSX.Element
change: JSX.Element
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: Can you swap these over to React.ReactNode we should use that over JSX.Element.

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send it 🚀

@RulaKhaled RulaKhaled merged commit 59bcfb4 into main Jan 15, 2024
58 checks passed
@RulaKhaled RulaKhaled deleted the coverage-commits-table branch January 15, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants