Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create bundle analysis table for a given pull #2510

Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR adds in a table to display a list of bundle for a given pull request.

GH codecov/engineering-team#994

Notable Changes

  • Create table for displaying bundles in a pull request
  • Create wrapper component to be used later
  • Add in tests

Screenshots

Screenshot 2024-01-12 at 08 24 38

@codecov-staging
Copy link

codecov-staging bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2510   +/-   ##
=======================================
  Coverage   98.27%   98.28%           
=======================================
  Files         789      791    +2     
  Lines       10147    10190   +43     
  Branches     2561     2568    +7     
=======================================
+ Hits         9972    10015   +43     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
...uestPage/PullBundleAnalysis/PullBundleAnalysis.tsx 100.00% <100.00%> (ø)
...ullBundleAnalysisTable/PullBundleAnalysisTable.tsx 100.00% <100.00%> (ø)
src/services/pull/usePullBundleList.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.25% <100.00%> (+<0.01%) ⬆️
Services 99.49% <100.00%> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c26fc4f...0f6f74c. Read the comment docs.

Copy link

codecov-public-qa bot commented Jan 12, 2024

Codecov Report

Merging #2510 (0f6f74c) into main (c26fc4f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2510   +/-   ##
=======================================
  Coverage   98.27%   98.28%           
=======================================
  Files         789      791    +2     
  Lines       10147    10190   +43     
  Branches     2547     2568   +21     
=======================================
+ Hits         9972    10015   +43     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
...uestPage/PullBundleAnalysis/PullBundleAnalysis.tsx 100.00% <100.00%> (ø)
...ullBundleAnalysisTable/PullBundleAnalysisTable.tsx 100.00% <100.00%> (ø)
src/services/pull/usePullBundleList.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.25% <100.00%> (+<0.01%) ⬆️
Services 99.49% <100.00%> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c26fc4f...0f6f74c. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c26fc4f) 98.27% compared to head (0f6f74c) 98.28%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2510   +/-   ##
=======================================
  Coverage   98.27%   98.28%           
=======================================
  Files         789      791    +2     
  Lines       10147    10190   +43     
  Branches     2515     2522    +7     
=======================================
+ Hits         9972    10015   +43     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
...uestPage/PullBundleAnalysis/PullBundleAnalysis.tsx 100.00% <100.00%> (ø)
...ullBundleAnalysisTable/PullBundleAnalysisTable.tsx 100.00% <100.00%> (ø)
src/services/pull/usePullBundleList.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.25% <100.00%> (+<0.01%) ⬆️
Services 99.49% <100.00%> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c26fc4f...0f6f74c. Read the comment docs.

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c26fc4f) 98.28% compared to head (0f6f74c) 98.28%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2510   +/-   ##
=====================================
  Coverage   98.28   98.28           
=====================================
  Files        789     791    +2     
  Lines      10147   10190   +43     
  Branches    2517    2568   +51     
=====================================
+ Hits        9972   10015   +43     
  Misses       173     173           
  Partials       2       2           
Files Coverage Δ
...uestPage/PullBundleAnalysis/PullBundleAnalysis.tsx 100.00% <100.00%> (ø)
...ullBundleAnalysisTable/PullBundleAnalysisTable.tsx 100.00% <100.00%> (ø)
src/services/pull/usePullBundleList.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.25% <100.00%> (+<0.01%) ⬆️
Services 99.49% <100.00%> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c26fc4f...0f6f74c. Read the comment docs.

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 0f6f74c
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65a7b88c852c2e0008952275
😎 Deploy Preview https://deploy-preview-2510--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rohitvinnakota-codecov rohitvinnakota-codecov dismissed their stale review January 16, 2024 03:17

Was looking at another PR

@nicholas-codecov nicholas-codecov merged commit 51f356f into main Jan 17, 2024
59 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-994-create-bundle-analysis-table-for-a-given-pull branch January 17, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants