Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fetch product status in use pull page data #2537

Merged

Conversation

nicholas-codecov
Copy link
Contributor

@nicholas-codecov nicholas-codecov commented Jan 24, 2024

Description

This PR updates the usePullPageData to also fetch the fields to see if coverage or bundle analysis is enabled for future use on the PR page.

GH codecov/engineering-team#997

Notable Changes

  • Update usePullPageData to fetch product status checks
  • Update related tests

@codecov-staging
Copy link

codecov-staging bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2537   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         803      803           
  Lines       10331    10333    +2     
  Branches     2587     2575   -12     
=======================================
+ Hits        10157    10159    +2     
  Misses        172      172           
  Partials        2        2           
Files Coverage Δ
...rc/pages/PullRequestPage/hooks/usePullPageData.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.55% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ffc2a...55bda1e. Read the comment docs.

Copy link

codecov-public-qa bot commented Jan 24, 2024

Codecov Report

Merging #2537 (55bda1e) into main (25ffc2a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2537   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         803      803           
  Lines       10331    10333    +2     
  Branches     2587     2589    +2     
=======================================
+ Hits        10157    10159    +2     
  Misses        172      172           
  Partials        2        2           
Files Coverage Δ
...rc/pages/PullRequestPage/hooks/usePullPageData.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.55% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ffc2a...55bda1e. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25ffc2a) 98.31% compared to head (55bda1e) 98.31%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2537   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         803      803           
  Lines       10331    10333    +2     
  Branches     2573     2589   +16     
=======================================
+ Hits        10157    10159    +2     
  Misses        172      172           
  Partials        2        2           
Files Coverage Δ
...rc/pages/PullRequestPage/hooks/usePullPageData.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.55% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ffc2a...55bda1e. Read the comment docs.

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 55bda1e
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65b274e753db1d0008b53d2d
😎 Deploy Preview https://deploy-preview-2537--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25ffc2a) 98.32% compared to head (55bda1e) 98.32%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2537   +/-   ##
=====================================
  Coverage   98.32   98.32           
=====================================
  Files        803     803           
  Lines      10331   10333    +2     
  Branches    2587    2575   -12     
=====================================
+ Hits       10157   10159    +2     
  Misses       172     172           
  Partials       2       2           
Files Coverage Δ
...rc/pages/PullRequestPage/hooks/usePullPageData.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.55% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ffc2a...55bda1e. Read the comment docs.

@nicholas-codecov nicholas-codecov merged commit 040aa92 into main Jan 25, 2024
60 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-997-fetch-product-status-in-usePullPageData branch January 25, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants