Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Handle invalid path errors from GraphQL #2546

Merged
merged 14 commits into from
Feb 26, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

Description

Adding invalid path message info from https://codecovio.atlassian.net/browse/CODE-1692 in relevant places in gazebo

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review January 29, 2024 21:18
@codecov-qa
Copy link

codecov-qa bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (fea31e7) to head (57acb9d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2546   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files         845      845           
  Lines       11374    11415   +41     
  Branches     2895     2948   +53     
=======================================
+ Hits        11189    11230   +41     
  Misses        183      183           
  Partials        2        2           
Files Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.jsx 100.00% <100.00%> (ø)
...ilFileExplorer/hooks/useRepoCommitContentsTable.js 100.00% <ø> (ø)
.../PullCoverage/routes/FileExplorer/FileExplorer.jsx 100.00% <100.00%> (ø)
...tes/FileExplorer/hooks/useRepoPullContentsTable.js 100.00% <ø> (ø)
...route/FileExplorer/CodeTreeTable/CodeTreeTable.jsx 100.00% <100.00%> (ø)
...CoverageTab/subroute/FileExplorer/FileExplorer.jsx 100.00% <100.00%> (ø)
...route/FileExplorer/FileListTable/FileListTable.jsx 100.00% <100.00%> (ø)
...e/FileExplorer/hooks/useRepoBranchContentsTable.js 100.00% <ø> (ø)
src/services/pathContents/branch/dir/constants.js 100.00% <ø> (ø)
...thContents/branch/dir/usePrefetchBranchDirEntry.js 100.00% <100.00%> (ø)
... and 6 more
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 97.00% <ø> (ø)
Pages 99.34% <100.00%> (+<0.01%) ⬆️
Services 99.59% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <ø> (ø)
UI 94.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fea31e7...57acb9d. Read the comment docs.

Copy link

codecov-public-qa bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fea31e7) 98.37% compared to head (57acb9d) 98.37%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2546   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files         845      845           
  Lines       11374    11415   +41     
  Branches     2938     2966   +28     
=======================================
+ Hits        11189    11230   +41     
  Misses        183      183           
  Partials        2        2           
Files Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.jsx 100.00% <100.00%> (ø)
...ilFileExplorer/hooks/useRepoCommitContentsTable.js 100.00% <ø> (ø)
.../PullCoverage/routes/FileExplorer/FileExplorer.jsx 100.00% <100.00%> (ø)
...tes/FileExplorer/hooks/useRepoPullContentsTable.js 100.00% <ø> (ø)
...route/FileExplorer/CodeTreeTable/CodeTreeTable.jsx 100.00% <100.00%> (ø)
...CoverageTab/subroute/FileExplorer/FileExplorer.jsx 100.00% <100.00%> (ø)
...route/FileExplorer/FileListTable/FileListTable.jsx 100.00% <100.00%> (ø)
...e/FileExplorer/hooks/useRepoBranchContentsTable.js 100.00% <ø> (ø)
src/services/pathContents/branch/dir/constants.js 100.00% <ø> (ø)
...thContents/branch/dir/usePrefetchBranchDirEntry.js 100.00% <100.00%> (ø)
... and 6 more
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 97.00% <ø> (ø)
Pages 99.34% <100.00%> (+<0.01%) ⬆️
Services 99.59% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <ø> (ø)
UI 94.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fea31e7...57acb9d. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2546   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files         845      845           
  Lines       11374    11415   +41     
  Branches     2893     2958   +65     
=======================================
+ Hits        11189    11230   +41     
  Misses        183      183           
  Partials        2        2           
Files Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.jsx 100.00% <100.00%> (ø)
...ilFileExplorer/hooks/useRepoCommitContentsTable.js 100.00% <ø> (ø)
.../PullCoverage/routes/FileExplorer/FileExplorer.jsx 100.00% <100.00%> (ø)
...tes/FileExplorer/hooks/useRepoPullContentsTable.js 100.00% <ø> (ø)
...route/FileExplorer/CodeTreeTable/CodeTreeTable.jsx 100.00% <100.00%> (ø)
...CoverageTab/subroute/FileExplorer/FileExplorer.jsx 100.00% <100.00%> (ø)
...route/FileExplorer/FileListTable/FileListTable.jsx 100.00% <100.00%> (ø)
...e/FileExplorer/hooks/useRepoBranchContentsTable.js 100.00% <ø> (ø)
src/services/pathContents/branch/dir/constants.js 100.00% <ø> (ø)
...thContents/branch/dir/usePrefetchBranchDirEntry.js 100.00% <100.00%> (ø)
... and 6 more
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 97.00% <ø> (ø)
Pages 99.34% <100.00%> (+<0.01%) ⬆️
Services 99.59% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <ø> (ø)
UI 94.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fea31e7...57acb9d. Read the comment docs.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (fea31e7) to head (57acb9d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2546     +/-   ##
=======================================
+ Coverage   98.37   98.38   +0.01     
=======================================
  Files        845     845             
  Lines      11374   11415     +41     
  Branches    2946    2915     -31     
=======================================
+ Hits       11189   11230     +41     
  Misses       183     183             
  Partials       2       2             
Files Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.jsx 100.00% <100.00%> (ø)
...ilFileExplorer/hooks/useRepoCommitContentsTable.js 100.00% <ø> (ø)
.../PullCoverage/routes/FileExplorer/FileExplorer.jsx 100.00% <100.00%> (ø)
...tes/FileExplorer/hooks/useRepoPullContentsTable.js 100.00% <ø> (ø)
...route/FileExplorer/CodeTreeTable/CodeTreeTable.jsx 100.00% <100.00%> (ø)
...CoverageTab/subroute/FileExplorer/FileExplorer.jsx 100.00% <100.00%> (ø)
...route/FileExplorer/FileListTable/FileListTable.jsx 100.00% <100.00%> (ø)
...e/FileExplorer/hooks/useRepoBranchContentsTable.js 100.00% <ø> (ø)
src/services/pathContents/branch/dir/constants.js 100.00% <ø> (ø)
...thContents/branch/dir/usePrefetchBranchDirEntry.js 100.00% <100.00%> (ø)
... and 6 more
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 97.00% <ø> (ø)
Pages 99.34% <100.00%> (+<0.01%) ⬆️
Services 99.59% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <ø> (ø)
UI 94.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fea31e7...57acb9d. Read the comment docs.

Copy link

netlify bot commented Jan 29, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 57acb9d
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65dca5a24d2d620008a0a270
😎 Deploy Preview https://deploy-preview-2546--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jan 29, 2024

Visit https://preview-pr-2546.codecov.dev for your PR preview. Expires after 1 month automatically. Enterprise URL: https://preview-pr-2546-enterprise.codecov.dev

@nicholas-codecov
Copy link
Contributor

nicholas-codecov commented Jan 31, 2024

Can you handle these errors in the locations that use these hooks, so that these cases are properly handled?

@codecov-staging
Copy link

codecov-staging bot commented Feb 23, 2024

Bundle Report

Changes will increase total bundle size by 735 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 5.88MB 735 bytes ⬆️

Copy link

codecov bot commented Feb 23, 2024

Bundle Report

Changes will increase total bundle size by 3.55kB ⬆️

Bundle name Size Change
gazebo-production-array-push 5.88MB 3.55kB ⬆️

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me 👍

@rohitvinnakota-codecov rohitvinnakota-codecov merged commit 747ed94 into main Feb 26, 2024
62 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/handle-invalid-gql-path branch February 26, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants