-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Handle invalid path errors from GraphQL #2546
[feat] Handle invalid path errors from GraphQL #2546
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2546 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 845 845
Lines 11374 11415 +41
Branches 2895 2948 +53
=======================================
+ Hits 11189 11230 +41
Misses 183 183
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #2546 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 845 845
Lines 11374 11415 +41
Branches 2938 2966 +28
=======================================
+ Hits 11189 11230 +41
Misses 183 183
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #2546 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 845 845
Lines 11374 11415 +41
Branches 2893 2958 +65
=======================================
+ Hits 11189 11230 +41
Misses 183 183
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2546 +/- ##
=======================================
+ Coverage 98.37 98.38 +0.01
=======================================
Files 845 845
Lines 11374 11415 +41
Branches 2946 2915 -31
=======================================
+ Hits 11189 11230 +41
Misses 183 183
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Visit https://preview-pr-2546.codecov.dev for your PR preview. Expires after 1 month automatically. Enterprise URL: https://preview-pr-2546-enterprise.codecov.dev |
Can you handle these errors in the locations that use these hooks, so that these cases are properly handled? |
Bundle ReportChanges will increase total bundle size by 735 bytes ⬆️
|
Bundle ReportChanges will increase total bundle size by 3.55kB ⬆️
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me 👍
Description
Adding invalid path message info from https://codecovio.atlassian.net/browse/CODE-1692 in relevant places in gazebo
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.