[fix] Disable update on initial render on billing page #2565
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2565 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 817 817
Lines 10743 10744 +1
Branches 2697 2742 +45
=======================================
+ Hits 10568 10569 +1
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2565 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 817 817
Lines 10743 10744 +1
Branches 2742 2750 +8
=======================================
+ Hits 10568 10569 +1
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #2565 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 817 817
Lines 10743 10744 +1
Branches 2750 2732 -18
=======================================
+ Hits 10568 10569 +1
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Visit https://preview-pr-2565.codecov.dev for your PR preview. Expires after 1 month automatically. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2565 +/- ##
=====================================
Coverage 98.37 98.37
=====================================
Files 817 817
Lines 10743 10744 +1
Branches 2697 2732 +35
=====================================
+ Hits 10568 10569 +1
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
rohitvinnakota-codecov
changed the title
| @@ -20,14 +20,12 @@ const UpdateButton: React.FC<BillingControlsProps> = ({ | |||
| }) => { | |||
| const { provider, owner } = useParams<{ provider: string; owner: string }>() | |||
| const { data: accountDetails } = useAccountDetails({ provider, owner }) | |||
|
|
|||
There was a problem hiding this comment.
what's up with the empty lines
Description
We currently have a bug where the
Updatebutton is not disabled when a user is on a team plan and goes to the billing page for the first time. This PR fixes the issue by defaulting the form values to the user's current plan.Before
Screen.Recording.2024-02-06.at.3.56.31.PM.mov
Screen.Recording.2024-02-06.at.3.56.59.PM.mov
After
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.