fix: Remove feedback link form header #2567
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #2567 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 817 817
Lines 10743 10743
Branches 2742 2742
=======================================
Hits 10568 10568
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2567 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 817 817
Lines 10743 10743
Branches 2699 2697 -2
=======================================
Hits 10568 10568
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2567 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 817 817
Lines 10743 10743
Branches 2732 2697 -35
=======================================
Hits 10568 10568
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2567 +/- ##
=====================================
Coverage 98.37 98.37
=====================================
Files 817 817
Lines 10743 10743
Branches 2697 2742 +45
=====================================
Hits 10568 10568
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Visit https://preview-pr-2567.codecov.dev for your PR preview. Expires after 1 month automatically. |
Description
Currently, we have 2 repeated "Feedback" links one located on the top nav, another one on the footer. We are adding a new "feedback" link on the banner here, see design here: codecov/engineering-team#1065.
To avoid confusion, we should remove the "Feedback" link on the top nav.
Notable Changes
remove the link, fix test
Screenshots
closes: codecov/engineering-team#1069
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.