feat: Update conditional render logic for repo page tabs #2570

nicholas-codecov · 2024-02-08T13:51:39Z

Description

This PR pulls the tabs out of the current RepoPage component and moves them into their own component RepoPageTabs including an overhaul of how we determine what tabs to render as well as adding in the new bundles tab.

GH codecov/engineering-team#1024

Notable Changes

Create new RepoPageTabs component
Remove tabs from RepoPage
Update how we determine what tabs to render
Add bundles entry to useNavLinks
Update App tests so they don't log out any errors
Few other tweaks here and there

…repo page tabs

codecov-public-qa · 2024-02-08T13:54:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1c297c) 98.31% compared to head (b8a82dd) 98.32%.

@@           Coverage Diff           @@
##             main    #2570   +/-   ##
=======================================
  Coverage   98.31%   98.32%           
=======================================
  Files         824      825    +1     
  Lines       10887    10908   +21     
  Branches     2745     2754    +9     
=======================================
+ Hits        10704    10725   +21     
  Misses        181      181           
  Partials        2        2

Files	Coverage Δ
src/pages/RepoPage/RepoPage.jsx	`100.00% <ø> (ø)`
src/pages/RepoPage/RepoPageTabs.tsx	`100.00% <100.00%> (ø)`
src/services/navigation/useNavLinks/useNavLinks.js	`99.08% <100.00%> (+<0.01%)`	⬆️
src/services/repo/useRepoOverview.tsx	`100.00% <100.00%> (ø)`
src/services/tier/useTier.ts	`100.00% <ø> (ø)`

Components	Coverage Δ
Assets	`55.26% <ø> (ø)`
Layouts	`96.95% <ø> (ø)`
Pages	`99.30% <100.00%> (+<0.01%)`	⬆️
Services	`99.56% <100.00%> (+<0.01%)`	⬆️
Shared	`99.83% <ø> (ø)`
UI	`94.23% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c297c...b8a82dd. Read the comment docs.

codecov-staging · 2024-02-08T13:54:56Z

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main    #2570      +/-   ##
==========================================
- Coverage   98.30%   98.30%   -0.01%     
==========================================
  Files         820      819       -1     
  Lines       10827    10797      -30     
  Branches     2775     2766       -9     
==========================================
- Hits        10644    10614      -30     
  Misses        181      181              
  Partials        2        2

Files	Coverage Δ
src/pages/RepoPage/RepoPage.jsx	`100.00% <ø> (ø)`
src/pages/RepoPage/RepoPageTabs.tsx	`100.00% <100.00%> (ø)`
src/services/navigation/useNavLinks/useNavLinks.js	`99.08% <100.00%> (+<0.01%)`	⬆️
src/services/tier/useTier.ts	`100.00% <ø> (ø)`

... and 11 files with indirect coverage changes

Components	Coverage Δ
Assets	`55.26% <ø> (ø)`
Layouts	`96.95% <ø> (ø)`
Pages	`99.29% <100.00%> (-0.01%)`	⬇️
Services	`99.56% <100.00%> (-0.01%)`	⬇️
Shared	`99.83% <ø> (ø)`
UI	`94.23% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbc19cb...00b9312. Read the comment docs.

netlify · 2024-02-08T13:55:35Z

✅ Deploy Preview for gazebo-staging ready!

Name	Link
🔨 Latest commit	`b8a82dd`
🔍 Latest deploy log	https://app.netlify.com/sites/gazebo-staging/deploys/65c66058d923930008d7faf7
😎 Deploy Preview	https://deploy-preview-2570--gazebo-staging.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov-qa · 2024-02-08T13:57:31Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1c297c) 98.31% compared to head (b8a82dd) 98.32%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2570   +/-   ##
=======================================
  Coverage   98.31%   98.32%           
=======================================
  Files         824      825    +1     
  Lines       10887    10908   +21     
  Branches     2778     2754   -24     
=======================================
+ Hits        10704    10725   +21     
  Misses        181      181           
  Partials        2        2

Files	Coverage Δ
src/pages/RepoPage/RepoPage.jsx	`100.00% <ø> (ø)`
src/pages/RepoPage/RepoPageTabs.tsx	`100.00% <100.00%> (ø)`
src/services/navigation/useNavLinks/useNavLinks.js	`99.08% <100.00%> (+<0.01%)`	⬆️
src/services/repo/useRepoOverview.tsx	`100.00% <100.00%> (ø)`
src/services/tier/useTier.ts	`100.00% <ø> (ø)`

Components	Coverage Δ
Assets	`55.26% <ø> (ø)`
Layouts	`96.95% <ø> (ø)`
Pages	`99.30% <100.00%> (+<0.01%)`	⬆️
Services	`99.56% <100.00%> (+<0.01%)`	⬆️
Shared	`99.83% <ø> (ø)`
UI	`94.23% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c297c...b8a82dd. Read the comment docs.

codecov · 2024-02-08T13:58:14Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fbc19cb) 98.31% compared to head (18f2be6) 98.31%.
Report is 2 commits behind head on main.

❗ Current head 18f2be6 differs from pull request most recent head b8a82dd. Consider uploading reports for the commit b8a82dd to get more accurate results

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #2570   +/-   ##
=====================================
  Coverage   98.31   98.31           
=====================================
  Files        820     819    -1     
  Lines      10827   10797   -30     
  Branches    2775    2713   -62     
=====================================
- Hits       10644   10614   -30     
  Misses       181     181           
  Partials       2       2

Files	Coverage Δ
src/pages/RepoPage/RepoPage.jsx	`100.00% <ø> (ø)`
src/pages/RepoPage/RepoPageTabs.tsx	`100.00% <100.00%> (ø)`
src/services/navigation/useNavLinks/useNavLinks.js	`99.08% <100.00%> (+<0.01%)`	⬆️
src/services/tier/useTier.ts	`100.00% <ø> (ø)`

... and 11 files with indirect coverage changes

Components	Coverage Δ
Assets	`55.26% <ø> (ø)`
Layouts	`96.95% <ø> (ø)`
Pages	`99.29% <100.00%> (-0.01%)`	⬇️
Services	`99.56% <100.00%> (-0.01%)`	⬇️
Shared	`99.83% <ø> (ø)`
UI	`94.23% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c297c...b8a82dd. Read the comment docs.

codecov-releaser · 2024-02-08T14:00:06Z

Visit https://preview-pr-2570.codecov.dev for your PR preview. Expires after 1 month automatically.

codecov-staging · 2024-02-09T11:33:11Z

Bundle Report

Changes will increase total bundle size by 1.08KB ⬆️

Bundle name	Size	Change
gazebo-staging-array-push	5.81MB	1.08KB ⬆️

nicholas-codecov added 6 commits February 8, 2024 09:35

export TTierNames type

15ba213

add new bundles route to useNavLinks

40c4abd

fix up App tests so that they don't log a bunch of errors

8eaecfe

create new RepoPageTabs component to handle conditional rendering of …

8365890

…repo page tabs

update RepoPage moving tabs into it's own component

8bf07f6

move repo page tabs up one level

18f2be6

Merge branch 'main' into gh-eng-1024-conditionally-render-repo-page-tabs

00b9312

update useRepoOverview to check to see if js or ts is present

a619664

rohitvinnakota-codecov approved these changes Feb 9, 2024

View reviewed changes

nicholas-codecov added 3 commits February 9, 2024 11:00

Merge branch 'main' into gh-eng-1024-conditionally-render-repo-page-tabs

ee6a141

stop using useMemo

9715754

Merge branch 'main' into gh-eng-1024-conditionally-render-repo-page-tabs

b8a82dd

nicholas-codecov merged commit 5debbc7 into main Feb 9, 2024
45 checks passed

nicholas-codecov deleted the gh-eng-1024-conditionally-render-repo-page-tabs branch February 9, 2024 17:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Update conditional render logic for repo page tabs #2570

feat: Update conditional render logic for repo page tabs #2570

nicholas-codecov commented Feb 8, 2024

codecov-public-qa bot commented Feb 8, 2024 •

edited

codecov-staging bot commented Feb 8, 2024 •

edited

netlify bot commented Feb 8, 2024 •

edited

codecov-qa bot commented Feb 8, 2024 •

edited

codecov bot commented Feb 8, 2024 •

edited

codecov-releaser commented Feb 8, 2024

codecov-staging bot commented Feb 9, 2024 •

edited

feat: Update conditional render logic for repo page tabs #2570

feat: Update conditional render logic for repo page tabs #2570

Conversation

nicholas-codecov commented Feb 8, 2024

Description

Notable Changes

codecov-public-qa bot commented Feb 8, 2024 • edited

Codecov Report

codecov-staging bot commented Feb 8, 2024 • edited

Codecov Report

netlify bot commented Feb 8, 2024 • edited

✅ Deploy Preview for gazebo-staging ready!

codecov-qa bot commented Feb 8, 2024 • edited

Codecov Report

codecov bot commented Feb 8, 2024 • edited

Codecov Report

codecov-releaser commented Feb 8, 2024

codecov-staging bot commented Feb 9, 2024 • edited

Bundle Report

codecov-public-qa bot commented Feb 8, 2024 •

edited

codecov-staging bot commented Feb 8, 2024 •

edited

netlify bot commented Feb 8, 2024 •

edited

codecov-qa bot commented Feb 8, 2024 •

edited

codecov bot commented Feb 8, 2024 •

edited

codecov-staging bot commented Feb 9, 2024 •

edited