Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update to default to 10 if pro plan already exceeds 10 users #2571

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

RulaKhaled
Copy link
Contributor

@RulaKhaled RulaKhaled commented Feb 8, 2024

Description

Before

Screen.Recording.2024-02-08.at.5.23.43.PM.mov

After

Screen.Recording.2024-02-08.at.5.23.00.PM.mov

Link to Sample Entry

this is a temp fix, i'm working on refactoring extract seats so that each seats input its own value

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov-public-qa bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29bc81f) 98.30% compared to head (ba25327) 98.30%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2571   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files         820      820           
  Lines       10825    10827    +2     
  Branches     2756     2724   -32     
=======================================
+ Hits        10642    10644    +2     
  Misses        181      181           
  Partials        2        2           
Files Coverage Δ
...trollers/TeamPlanController/TeamPlanController.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.30% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29bc81f...ba25327. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29bc81f) 98.30% compared to head (ba25327) 98.30%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2571   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files         820      820           
  Lines       10825    10827    +2     
  Branches     2756     2722   -34     
=======================================
+ Hits        10642    10644    +2     
  Misses        181      181           
  Partials        2        2           
Files Coverage Δ
...trollers/TeamPlanController/TeamPlanController.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.30% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29bc81f...ba25327. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2571   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files         820      820           
  Lines       10825    10827    +2     
  Branches     2766     2767    +1     
=======================================
+ Hits        10642    10644    +2     
  Misses        181      181           
  Partials        2        2           
Files Coverage Δ
...trollers/TeamPlanController/TeamPlanController.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.30% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29bc81f...ba25327. Read the comment docs.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit ba25327
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65c506c1ebaef40008c087ff
😎 Deploy Preview https://deploy-preview-2571--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-staging
Copy link

codecov-staging bot commented Feb 8, 2024

Bundle Report

Changes will increase total bundle size by 23 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 5.8MB 23 bytes ⬆️

@codecov-releaser
Copy link
Contributor

Visit https://preview-pr-2571.codecov.dev for your PR preview. Expires after 1 month automatically.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29bc81f) 98.31% compared to head (3a0b2d1) 98.31%.

❗ Current head 3a0b2d1 differs from pull request most recent head ba25327. Consider uploading reports for the commit ba25327 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2571   +/-   ##
=====================================
  Coverage   98.31   98.31           
=====================================
  Files        820     820           
  Lines      10825   10827    +2     
  Branches    2721    2722    +1     
=====================================
+ Hits       10642   10644    +2     
  Misses       181     181           
  Partials       2       2           
Files Coverage Δ
...trollers/TeamPlanController/TeamPlanController.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.30% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29bc81f...ba25327. Read the comment docs.

@RulaKhaled RulaKhaled merged commit e6458b9 into main Feb 8, 2024
53 checks passed
@RulaKhaled RulaKhaled deleted the count-bug branch February 8, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants