fix: Add hard redirect to bundle onboarding #2595
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2595 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 831 831
Lines 11080 11086 +6
Branches 2815 2818 +3
=======================================
+ Hits 10897 10903 +6
Misses 181 181
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #2595 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 831 831
Lines 11080 11086 +6
Branches 2868 2869 +1
=======================================
+ Hits 10897 10903 +6
Misses 181 181
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #2595 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 831 831
Lines 11080 11086 +6
Branches 2860 2861 +1
=======================================
+ Hits 10897 10903 +6
Misses 181 181
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2595 +/- ##
=====================================
Coverage 98.35 98.35
=====================================
Files 831 831
Lines 11080 11086 +6
Branches 2860 2861 +1
=====================================
+ Hits 10897 10903 +6
Misses 181 181
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 560 bytes ⬆️
|
|
Visit https://preview-pr-2595.codecov.dev for your PR preview. Expires after 1 month automatically. Enterprise URL: https://preview-pr-2595-enterprise.codecov.dev |
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| // if no upload token redirect | ||
| if (!data?.repository?.uploadToken) { | ||
| hardRedirect() | ||
| return <NotFound /> |
There was a problem hiding this comment.
Will this element will be rendered if we redirect away from the page? It is possible the test is passing since we are not waiting for hardRedirect() to finish executing.
There was a problem hiding this comment.
So for this, this is pretty much a direct copy over from the new repo page, as to why it has both, I'm not 100% certain, I assume it may be incase something doesn't happen fast enough it'll render the not found just incase.
There was a problem hiding this comment.
I see the commit history on there. Looks like there was inconsistent behaviour with the redirect. Prefer adding a comment explaining the possibly redundant component.
Bundle ReportChanges will increase total bundle size by 560 bytes ⬆️
|
nicholas-codecov
deleted the
fix-add-hard-redirect-to-bundle-onboarding
branch
Description
Small change to bundle onboarding to redirect the user if upload token is not present similar as to how the coverage onboarding currently works.