ref: Convert TokensTable to tanstack table #2612

spalmurray-codecov · 2024-02-21T14:03:31Z

Description

Refactor TokensTable and the hooks it depends on: useSessions and useRevokeUserToken. Also, update the column layout of TokensTable to better accommodate long names. Since the 'Token' column has fixed width, allowing the name column to take up more width seems like good change. See change in screenshot.

Closes codecov/engineering-team#601

Notable Changes

Convert TokensTable to TS/tanstack table
Update column layout of TokensTable
Convert useSessions to TS
Convert useRevokeUserToken to TS

Screenshots

codecov-public-qa · 2024-02-21T14:06:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (747ed94) 98.37% compared to head (e9ec767) 98.38%.

@@           Coverage Diff           @@
##             main    #2612   +/-   ##
=======================================
  Coverage   98.37%   98.38%           
=======================================
  Files         845      845           
  Lines       11415    11422    +7     
  Branches     2958     2961    +3     
=======================================
+ Hits        11230    11237    +7     
  Misses        183      183           
  Partials        2        2

Files	Coverage Δ
.../pages/AccountSettings/tabs/Access/TokensTable.tsx	`100.00% <100.00%> (ø)`
src/services/access/useRevokeUserToken.ts	`100.00% <100.00%> (ø)`
src/services/access/useSessions.ts	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`55.26% <ø> (ø)`
Layouts	`97.00% <ø> (ø)`
Pages	`99.34% <100.00%> (+<0.01%)`	⬆️
Services	`99.60% <100.00%> (+<0.01%)`	⬆️
Shared	`99.83% <ø> (ø)`
UI	`94.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 747ed94...e9ec767. Read the comment docs.

codecov-qa · 2024-02-21T14:06:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (747ed94) to head (e9ec767).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2612   +/-   ##
=======================================
  Coverage   98.37%   98.38%           
=======================================
  Files         845      845           
  Lines       11415    11422    +7     
  Branches     2958     2961    +3     
=======================================
+ Hits        11230    11237    +7     
  Misses        183      183           
  Partials        2        2

Files	Coverage Δ
.../pages/AccountSettings/tabs/Access/TokensTable.tsx	`100.00% <100.00%> (ø)`
src/services/access/useRevokeUserToken.ts	`100.00% <100.00%> (ø)`
src/services/access/useSessions.ts	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`55.26% <ø> (ø)`
Layouts	`97.00% <ø> (ø)`
Pages	`99.34% <100.00%> (+<0.01%)`	⬆️
Services	`99.60% <100.00%> (+<0.01%)`	⬆️
Shared	`99.83% <ø> (ø)`
UI	`94.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 747ed94...e9ec767. Read the comment docs.

codecov-staging · 2024-02-21T14:06:33Z

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff           @@
##             main    #2612   +/-   ##
=======================================
  Coverage   98.37%   98.38%           
=======================================
  Files         845      845           
  Lines       11415    11422    +7     
  Branches     2948     2910   -38     
=======================================
+ Hits        11230    11237    +7     
  Misses        183      183           
  Partials        2        2

Files	Coverage Δ
.../pages/AccountSettings/tabs/Access/TokensTable.tsx	`100.00% <100.00%> (ø)`
src/services/access/useRevokeUserToken.ts	`100.00% <100.00%> (ø)`
src/services/access/useSessions.ts	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`55.26% <ø> (ø)`
Layouts	`97.00% <ø> (ø)`
Pages	`99.34% <100.00%> (+<0.01%)`	⬆️
Services	`99.60% <100.00%> (+<0.01%)`	⬆️
Shared	`99.83% <ø> (ø)`
UI	`94.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 747ed94...e9ec767. Read the comment docs.

codecov · 2024-02-21T14:07:26Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (747ed94) to head (e9ec767).

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #2612   +/-   ##
=====================================
  Coverage   98.38   98.38           
=====================================
  Files        845     845           
  Lines      11415   11422    +7     
  Branches    2958    2910   -48     
=====================================
+ Hits       11230   11237    +7     
  Misses       183     183           
  Partials       2       2

Files	Coverage Δ
.../pages/AccountSettings/tabs/Access/TokensTable.tsx	`100.00% <100.00%> (ø)`
src/services/access/useRevokeUserToken.ts	`100.00% <100.00%> (ø)`
src/services/access/useSessions.ts	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`55.26% <ø> (ø)`
Layouts	`97.00% <ø> (ø)`
Pages	`99.34% <100.00%> (+<0.01%)`	⬆️
Services	`99.60% <100.00%> (+<0.01%)`	⬆️
Shared	`99.83% <ø> (ø)`
UI	`94.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 747ed94...e9ec767. Read the comment docs.

netlify · 2024-02-21T14:08:08Z

✅ Deploy Preview for gazebo-staging ready!

Name	Link
🔨 Latest commit	`e9ec767`
🔍 Latest deploy log	https://app.netlify.com/sites/gazebo-staging/deploys/65dcad2923aa440008d624b5
😎 Deploy Preview	https://deploy-preview-2612--gazebo-staging.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov · 2024-02-21T14:08:34Z

Bundle Report

Changes will increase total bundle size by 4.31kB ⬆️

Bundle name	Size	Change
gazebo-production-array-push	5.89MB	4.31kB ⬆️

codecov-staging · 2024-02-21T14:08:56Z

Bundle Report

Changes will increase total bundle size by 4.31kB ⬆️

Bundle name	Size	Change
gazebo-staging-array-push	5.88MB	4.31kB ⬆️

codecov-releaser · 2024-02-21T14:12:01Z

Visit https://preview-pr-2612.codecov.dev for your PR preview. Expires after 1 month automatically. Enterprise URL: https://preview-pr-2612-enterprise.codecov.dev

src/services/access/useRevokeUserToken.ts

src/services/access/useSessions.ts

ajay-sentry

looks good to me!

nicholas-codecov

Looks all good to me ✅

Refactor TokensTable, useSessions, and useRevokeUserToken. GH codecov/engineering-team#601

spalmurray-codecov added 2 commits February 20, 2024 15:56

Move useSessions to TS

decccb7

Move useRevokeUserToken to TS

70b0972

Merge branch 'main' into gh-eng-601-TokensTable

81901a9

spalmurray-codecov changed the title ~~gh eng 601 TokensTable~~ ref: Convert TokensTable Feb 21, 2024

spalmurray-codecov added 4 commits February 21, 2024 16:35

Return rejected promise instead of null when response parse fails

6296148

Merge branch 'main' into gh-eng-601-TokensTable

49dc2d8

Convert TokensTable to tanstack table

e17f602

Merge branch 'main' into gh-eng-601-TokensTable

0efd75c

spalmurray-codecov changed the title ~~ref: Convert TokensTable~~ ref: Convert TokensTable to tanstack table Feb 23, 2024

Merge branch 'main' into gh-eng-601-TokensTable

8e22b05

spalmurray-codecov marked this pull request as ready for review February 23, 2024 20:05

ajay-sentry reviewed Feb 23, 2024

View reviewed changes

src/services/access/useRevokeUserToken.ts Show resolved Hide resolved

ajay-sentry reviewed Feb 23, 2024

View reviewed changes

src/services/access/useSessions.ts Show resolved Hide resolved

ajay-sentry approved these changes Feb 23, 2024

View reviewed changes

nicholas-codecov approved these changes Feb 26, 2024

View reviewed changes

Merge branch 'main' into gh-eng-601-TokensTable

e9ec767

spalmurray-codecov merged commit 9514708 into main Feb 26, 2024
62 checks passed

spalmurray-codecov deleted the gh-eng-601-TokensTable branch February 26, 2024 16:43

RulaKhaled pushed a commit that referenced this pull request Mar 8, 2024

ref: Convert TokensTable to tanstack table (#2612)

69b1ea0

Refactor TokensTable, useSessions, and useRevokeUserToken. GH codecov/engineering-team#601

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ref: Convert TokensTable to tanstack table #2612

ref: Convert TokensTable to tanstack table #2612

spalmurray-codecov commented Feb 21, 2024 •

edited

codecov-public-qa bot commented Feb 21, 2024 •

edited

codecov-qa bot commented Feb 21, 2024 •

edited

codecov-staging bot commented Feb 21, 2024 •

edited

codecov bot commented Feb 21, 2024 •

edited

netlify bot commented Feb 21, 2024 •

edited

codecov bot commented Feb 21, 2024 •

edited

codecov-staging bot commented Feb 21, 2024 •

edited

codecov-releaser commented Feb 21, 2024

ajay-sentry left a comment

nicholas-codecov left a comment

ref: Convert TokensTable to tanstack table #2612

ref: Convert TokensTable to tanstack table #2612

Conversation

spalmurray-codecov commented Feb 21, 2024 • edited

Description

Notable Changes

Screenshots

codecov-public-qa bot commented Feb 21, 2024 • edited

Codecov Report

codecov-qa bot commented Feb 21, 2024 • edited

Codecov Report

codecov-staging bot commented Feb 21, 2024 • edited

Codecov Report

codecov bot commented Feb 21, 2024 • edited

Codecov Report

netlify bot commented Feb 21, 2024 • edited

✅ Deploy Preview for gazebo-staging ready!

codecov bot commented Feb 21, 2024 • edited

Bundle Report

codecov-staging bot commented Feb 21, 2024 • edited

Bundle Report

codecov-releaser commented Feb 21, 2024

ajay-sentry left a comment

Choose a reason for hiding this comment

nicholas-codecov left a comment

Choose a reason for hiding this comment

spalmurray-codecov commented Feb 21, 2024 •

edited

codecov-public-qa bot commented Feb 21, 2024 •

edited

codecov-qa bot commented Feb 21, 2024 •

edited

codecov-staging bot commented Feb 21, 2024 •

edited

codecov bot commented Feb 21, 2024 •

edited

netlify bot commented Feb 21, 2024 •

edited

codecov bot commented Feb 21, 2024 •

edited

codecov-staging bot commented Feb 21, 2024 •

edited