Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: #1057 - Clarify prerequisite of coverage reports #2613

Merged
merged 7 commits into from
Feb 23, 2024

Conversation

ajay-sentry
Copy link
Contributor

Description

Adds a little box to the Github, CircleCI and other CI "new" repo pages explaining to check our quick start docs confirming they have coverage reports set up already, along with a link to the docs.

Notable Changes

Uncommented one of the book icons for this. There was a separate one on the figma, but I figured it'd probably be better to use one we already have in the repo rather than importing a fresh one.

Screenshots

Screen.Recording.2024-02-21.at.1.52.09.PM.mov

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov-public-qa bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ff3a20) 98.37% compared to head (e36b8ef) 98.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2613      +/-   ##
==========================================
- Coverage   98.37%   98.36%   -0.02%     
==========================================
  Files         838      841       +3     
  Lines       11283    11293      +10     
  Branches     2921     2911      -10     
==========================================
+ Hits        11100    11108       +8     
- Misses        181      183       +2     
  Partials        2        2              
Files Coverage Δ
...e/CoverageOnboarding/CircleCI/CircleCIOrgToken.tsx 100.00% <ø> (ø)
.../CoverageOnboarding/CircleCI/CircleCIRepoToken.tsx 100.00% <ø> (ø)
...Onboarding/GitHubActions/GitHubActionsOrgToken.tsx 100.00% <ø> (ø)
...nboarding/GitHubActions/GitHubActionsRepoToken.tsx 100.00% <ø> (ø)
...oPage/CoverageOnboarding/IntroBlurb/IntroBlurb.tsx 100.00% <100.00%> (ø)
...age/CoverageOnboarding/OtherCI/OtherCIOrgToken.tsx 100.00% <ø> (ø)
...ge/CoverageOnboarding/OtherCI/OtherCIRepoToken.tsx 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 97.00% <ø> (ø)
Pages 99.34% <100.00%> (+<0.01%) ⬆️
Services 99.58% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.14% <ø> (-0.13%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ff3a20...e36b8ef. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (1ff3a20) to head (e36b8ef).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2613      +/-   ##
==========================================
- Coverage   98.37%   98.36%   -0.02%     
==========================================
  Files         838      841       +3     
  Lines       11283    11293      +10     
  Branches     2921     2876      -45     
==========================================
+ Hits        11100    11108       +8     
- Misses        181      183       +2     
  Partials        2        2              
Files Coverage Δ
...e/CoverageOnboarding/CircleCI/CircleCIOrgToken.tsx 100.00% <ø> (ø)
.../CoverageOnboarding/CircleCI/CircleCIRepoToken.tsx 100.00% <ø> (ø)
...Onboarding/GitHubActions/GitHubActionsOrgToken.tsx 100.00% <ø> (ø)
...nboarding/GitHubActions/GitHubActionsRepoToken.tsx 100.00% <ø> (ø)
...oPage/CoverageOnboarding/IntroBlurb/IntroBlurb.tsx 100.00% <100.00%> (ø)
...age/CoverageOnboarding/OtherCI/OtherCIOrgToken.tsx 100.00% <ø> (ø)
...ge/CoverageOnboarding/OtherCI/OtherCIRepoToken.tsx 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 97.00% <ø> (ø)
Pages 99.34% <100.00%> (+<0.01%) ⬆️
Services 99.58% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.14% <ø> (-0.13%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ff3a20...e36b8ef. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2613      +/-   ##
==========================================
- Coverage   98.37%   98.36%   -0.02%     
==========================================
  Files         838      841       +3     
  Lines       11283    11293      +10     
  Branches     2876     2921      +45     
==========================================
+ Hits        11100    11108       +8     
- Misses        181      183       +2     
  Partials        2        2              
Files Coverage Δ
...e/CoverageOnboarding/CircleCI/CircleCIOrgToken.tsx 100.00% <ø> (ø)
.../CoverageOnboarding/CircleCI/CircleCIRepoToken.tsx 100.00% <ø> (ø)
...Onboarding/GitHubActions/GitHubActionsOrgToken.tsx 100.00% <ø> (ø)
...nboarding/GitHubActions/GitHubActionsRepoToken.tsx 100.00% <ø> (ø)
...oPage/CoverageOnboarding/IntroBlurb/IntroBlurb.tsx 100.00% <100.00%> (ø)
...age/CoverageOnboarding/OtherCI/OtherCIOrgToken.tsx 100.00% <ø> (ø)
...ge/CoverageOnboarding/OtherCI/OtherCIRepoToken.tsx 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 97.00% <ø> (ø)
Pages 99.34% <100.00%> (+<0.01%) ⬆️
Services 99.58% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.14% <ø> (-0.13%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ff3a20...e36b8ef. Read the comment docs.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (1ff3a20) to head (e36b8ef).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2613     +/-   ##
=======================================
- Coverage   98.38   98.36   -0.02     
=======================================
  Files        838     841      +3     
  Lines      11283   11293     +10     
  Branches    2921    2876     -45     
=======================================
+ Hits       11100   11108      +8     
- Misses       181     183      +2     
  Partials       2       2             
Files Coverage Δ
...e/CoverageOnboarding/CircleCI/CircleCIOrgToken.tsx 100.00% <ø> (ø)
.../CoverageOnboarding/CircleCI/CircleCIRepoToken.tsx 100.00% <ø> (ø)
...Onboarding/GitHubActions/GitHubActionsOrgToken.tsx 100.00% <ø> (ø)
...nboarding/GitHubActions/GitHubActionsRepoToken.tsx 100.00% <ø> (ø)
...oPage/CoverageOnboarding/IntroBlurb/IntroBlurb.tsx 100.00% <100.00%> (ø)
...age/CoverageOnboarding/OtherCI/OtherCIOrgToken.tsx 100.00% <ø> (ø)
...ge/CoverageOnboarding/OtherCI/OtherCIRepoToken.tsx 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 97.00% <ø> (ø)
Pages 99.34% <100.00%> (+<0.01%) ⬆️
Services 99.58% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.14% <ø> (-0.13%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ff3a20...e36b8ef. Read the comment docs.

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit e36b8ef
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65d8ca7236080c000894832b
😎 Deploy Preview https://deploy-preview-2613--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-staging
Copy link

codecov-staging bot commented Feb 21, 2024

Bundle Report

Changes will increase total bundle size by 4.07kB ⬆️

Bundle name Size Change
gazebo-staging-array-push 5.88MB 4.07kB ⬆️

Copy link

codecov bot commented Feb 21, 2024

Bundle Report

Changes will increase total bundle size by 4.07kB ⬆️

Bundle name Size Change
gazebo-production-array-push 5.88MB 4.07kB ⬆️

@codecov-releaser
Copy link
Contributor

Visit https://preview-pr-2613.codecov.dev for your PR preview. Expires after 1 month automatically. Enterprise URL: https://preview-pr-2613-enterprise.codecov.dev

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to only update the repo token versions of the onboarding where we need to also support the global upload tokens as well. Since this is being reused all over the place in six different components I think this is a good time to pull this out into it's own component.

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for those quick changes 🎉

@ajay-sentry ajay-sentry merged commit 167413d into main Feb 23, 2024
58 of 62 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/1057-clarify-prereq branch February 23, 2024 16:51
RulaKhaled pushed a commit that referenced this pull request Mar 8, 2024
* uncomment icon, add UT's, create box on new repo page

* pull out blurb into separate component, add to all org token files

* move to folder

* better tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants