-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: #1057 - Clarify prerequisite of coverage reports #2613
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #2613 +/- ##
==========================================
- Coverage 98.37% 98.36% -0.02%
==========================================
Files 838 841 +3
Lines 11283 11293 +10
Branches 2921 2911 -10
==========================================
+ Hits 11100 11108 +8
- Misses 181 183 +2
Partials 2 2
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2613 +/- ##
==========================================
- Coverage 98.37% 98.36% -0.02%
==========================================
Files 838 841 +3
Lines 11283 11293 +10
Branches 2921 2876 -45
==========================================
+ Hits 11100 11108 +8
- Misses 181 183 +2
Partials 2 2
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #2613 +/- ##
==========================================
- Coverage 98.37% 98.36% -0.02%
==========================================
Files 838 841 +3
Lines 11283 11293 +10
Branches 2876 2921 +45
==========================================
+ Hits 11100 11108 +8
- Misses 181 183 +2
Partials 2 2
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2613 +/- ##
=======================================
- Coverage 98.38 98.36 -0.02
=======================================
Files 838 841 +3
Lines 11283 11293 +10
Branches 2921 2876 -45
=======================================
+ Hits 11100 11108 +8
- Misses 181 183 +2
Partials 2 2
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle ReportChanges will increase total bundle size by 4.07kB ⬆️
|
Bundle ReportChanges will increase total bundle size by 4.07kB ⬆️
|
Visit https://preview-pr-2613.codecov.dev for your PR preview. Expires after 1 month automatically. Enterprise URL: https://preview-pr-2613-enterprise.codecov.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to only update the repo token versions of the onboarding where we need to also support the global upload tokens as well. Since this is being reused all over the place in six different components I think this is a good time to pull this out into it's own component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty for those quick changes 🎉
Description
Adds a little box to the Github, CircleCI and other CI "new" repo pages explaining to check our quick start docs confirming they have coverage reports set up already, along with a link to the docs.
Notable Changes
Uncommented one of the book icons for this. There was a separate one on the figma, but I figured it'd probably be better to use one we already have in the repo rather than importing a fresh one.
Screenshots
Screen.Recording.2024-02-21.at.1.52.09.PM.mov
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.