Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: clean up some lodash imports #2616

Merged
merged 10 commits into from
Feb 22, 2024
Merged

ref: clean up some lodash imports #2616

merged 10 commits into from
Feb 22, 2024

Conversation

nicholas-codecov
Copy link
Contributor

@nicholas-codecov nicholas-codecov commented Feb 22, 2024 •
edited

Description

This PR fixes up some lodash imports so that we don't over import from lodash.

@netlify Netlify
Copy link

netlify bot commented Feb 22, 2024 •
edited

✅ Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 34db247
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65d74874e2893a0008842180
😎 Deploy Preview https://deploy-preview-2616--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Feb 22, 2024 •
edited

Bundle Report

Changes will decrease total bundle size by 71.52KB ⬇️

Bundle name Size Change
gazebo-production-array-push 5.86MB 71.52KB ⬇️

@codecov-staging
Copy link

codecov-staging bot commented Feb 22, 2024 •
edited

Bundle Report

Changes will decrease total bundle size by 71.52KB ⬇️

Bundle name Size Change
gazebo-staging-array-push 5.86MB 71.52KB ⬇️

@nicholas-codecov nicholas-codecov marked this pull request as ready for review February 22, 2024 13:03
@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Feb 22, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ca0f75) 98.36% compared to head (34db247) 98.36%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2616   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         837      837           
  Lines       11217    11217           
  Branches     2859     2857    -2     
=======================================
  Hits        11034    11034           
  Misses        181      181           
  Partials        2        2
Files Coverage Δ
...ChangedTab/FilesChangedTable/FilesChangedTable.tsx 100.00% <ø> (ø)
...sTab/IndirectChangesTable/IndirectChangesTable.tsx 100.00% <ø> (ø)
...lCoverage/routes/ComponentsTab/ComponentsTable.tsx 100.00% <ø> (ø)
...lesChanged/FilesChangedTable/FilesChangedTable.tsx 100.00% <ø> (ø)
src/shared/utils/billing.js 100.00% <ø> (ø)
src/ui/TextInput/TextInput.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 97.00% <ø> (ø)
Pages 99.33% <ø> (ø)
Services 99.57% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.27% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ca0f75...34db247. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Feb 22, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2616   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         837      837           
  Lines       11217    11217           
  Branches     2910     2857   -53     
=======================================
  Hits        11034    11034           
  Misses        181      181           
  Partials        2        2
Files Coverage Δ
...ChangedTab/FilesChangedTable/FilesChangedTable.tsx 100.00% <ø> (ø)
...sTab/IndirectChangesTable/IndirectChangesTable.tsx 100.00% <ø> (ø)
...lCoverage/routes/ComponentsTab/ComponentsTable.tsx 100.00% <ø> (ø)
...lesChanged/FilesChangedTable/FilesChangedTable.tsx 100.00% <ø> (ø)
src/shared/utils/billing.js 100.00% <ø> (ø)
src/ui/TextInput/TextInput.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 97.00% <ø> (ø)
Pages 99.33% <ø> (ø)
Services 99.57% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.27% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ca0f75...34db247. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Feb 22, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ca0f75) 98.36% compared to head (34db247) 98.36%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2616   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         837      837           
  Lines       11217    11217           
  Branches     2857     2857           
=======================================
  Hits        11034    11034           
  Misses        181      181           
  Partials        2        2
Files Coverage Δ
...ChangedTab/FilesChangedTable/FilesChangedTable.tsx 100.00% <ø> (ø)
...sTab/IndirectChangesTable/IndirectChangesTable.tsx 100.00% <ø> (ø)
...lCoverage/routes/ComponentsTab/ComponentsTable.tsx 100.00% <ø> (ø)
...lesChanged/FilesChangedTable/FilesChangedTable.tsx 100.00% <ø> (ø)
src/shared/utils/billing.js 100.00% <ø> (ø)
src/ui/TextInput/TextInput.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 97.00% <ø> (ø)
Pages 99.33% <ø> (ø)
Services 99.57% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.27% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ca0f75...34db247. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented Feb 22, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ca0f75) 98.37% compared to head (34db247) 98.37%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2616   +/-   ##
=====================================
  Coverage   98.37   98.37           
=====================================
  Files        837     837           
  Lines      11217   11217           
  Branches    2892    2892           
=====================================
  Hits       11034   11034           
  Misses       181     181           
  Partials       2       2
Files Coverage Δ
...ChangedTab/FilesChangedTable/FilesChangedTable.tsx 100.00% <ø> (ø)
...sTab/IndirectChangesTable/IndirectChangesTable.tsx 100.00% <ø> (ø)
...lCoverage/routes/ComponentsTab/ComponentsTable.tsx 100.00% <ø> (ø)
...lesChanged/FilesChangedTable/FilesChangedTable.tsx 100.00% <ø> (ø)
src/shared/utils/billing.js 100.00% <ø> (ø)
src/ui/TextInput/TextInput.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 97.00% <ø> (ø)
Pages 99.33% <ø> (ø)
Services 99.57% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.27% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ca0f75...34db247. Read the comment docs.

@codecov-releaser
Copy link
Contributor

Visit https://preview-pr-2616.codecov.dev for your PR preview. Expires after 1 month automatically. Enterprise URL: https://preview-pr-2616-enterprise.codecov.dev

@nicholas-codecov nicholas-codecov merged commit e85e126 into main Feb 22, 2024
62 checks passed
@nicholas-codecov nicholas-codecov deleted the ref-clean-up-some-lodash-imports branch February 22, 2024 13:22
RulaKhaled pushed a commit that referenced this pull request Mar 8, 2024
@nicholas-codecov @RulaKhaled
ref: clean up some lodash imports (#2616)
7467c19 
Small tweaks to a couple of imports from lodash to reduce bundle size overall.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RulaKhaled RulaKhaled RulaKhaled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicholas-codecov @codecov-releaser @RulaKhaled