Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create hook to fetch list of modules for a given asset #2621

Conversation

nicholas-codecov
Copy link
Contributor

Description

Create a new hook that will fetch a list of modules and their details for a given branch + bundle + asset, for the upcoming bundles tab table.

Closes codecov/engineering-team#1209

Notable Changes

  • Create a new hook that fetches a list of modules
  • Add in tests

Copy link

codecov-public-qa bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (944d6d3) 98.36% compared to head (4855d8c) 98.37%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2621   +/-   ##
=======================================
  Coverage   98.36%   98.37%           
=======================================
  Files         844      845    +1     
  Lines       11347    11374   +27     
  Branches     2888     2928   +40     
=======================================
+ Hits        11162    11189   +27     
  Misses        183      183           
  Partials        2        2           
Files Coverage Δ
.../services/bundleAnalysis/useBundleAssetModules.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 97.00% <ø> (ø)
Pages 99.34% <ø> (ø)
Services 99.59% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <ø> (ø)
UI 94.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 944d6d3...4855d8c. Read the comment docs.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (944d6d3) to head (4855d8c).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2621   +/-   ##
=====================================
  Coverage   98.37   98.37           
=====================================
  Files        844     845    +1     
  Lines      11347   11374   +27     
  Branches    2931    2895   -36     
=====================================
+ Hits       11162   11189   +27     
  Misses       183     183           
  Partials       2       2           
Files Coverage Δ
.../services/bundleAnalysis/useBundleAssetModules.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 97.00% <ø> (ø)
Pages 99.34% <ø> (ø)
Services 99.59% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <ø> (ø)
UI 94.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 944d6d3...4855d8c. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (944d6d3) to head (4855d8c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2621   +/-   ##
=======================================
  Coverage   98.36%   98.37%           
=======================================
  Files         844      845    +1     
  Lines       11347    11374   +27     
  Branches     2931     2893   -38     
=======================================
+ Hits        11162    11189   +27     
  Misses        183      183           
  Partials        2        2           
Files Coverage Δ
.../services/bundleAnalysis/useBundleAssetModules.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 97.00% <ø> (ø)
Pages 99.34% <ø> (ø)
Services 99.59% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <ø> (ø)
UI 94.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 944d6d3...4855d8c. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2621   +/-   ##
=======================================
  Coverage   98.36%   98.37%           
=======================================
  Files         844      845    +1     
  Lines       11347    11374   +27     
  Branches     2939     2893   -46     
=======================================
+ Hits        11162    11189   +27     
  Misses        183      183           
  Partials        2        2           
Files Coverage Δ
.../services/bundleAnalysis/useBundleAssetModules.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 97.00% <ø> (ø)
Pages 99.34% <ø> (ø)
Services 99.59% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <ø> (ø)
UI 94.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 944d6d3...4855d8c. Read the comment docs.

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 4855d8c
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65d8f6d7c0351b0008446229
😎 Deploy Preview https://deploy-preview-2621--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-staging
Copy link

Bundle Report

Bundle size has no change ✅

1 similar comment
Copy link

codecov bot commented Feb 23, 2024

Bundle Report

Bundle size has no change ✅

@codecov-releaser
Copy link
Contributor

Visit https://preview-pr-2621.codecov.dev for your PR preview. Expires after 1 month automatically. Enterprise URL: https://preview-pr-2621-enterprise.codecov.dev

@nicholas-codecov nicholas-codecov merged commit fea31e7 into main Feb 23, 2024
62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-1209-create-hook-to-fetch-list-of-modules-for-a-given-asset branch February 23, 2024 20:02
RulaKhaled pushed a commit that referenced this pull request Mar 8, 2024
Create a new hook that fetches a list of modules for a given asset.

GH codecov/engineering-team#1209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Client] Create a hook to fetch a list of modules for a given asset
3 participants