style: Fix settings style inconsistencies #2630

spalmurray-codecov · 2024-02-27T22:23:42Z

Description

Style tweaks across the settings pages. Mostly adjusts widths of body divs on settings pages so that they match the comps.

Figma

Closes codecov/engineering-team#888

Notable Changes

Adjust large screen widths of several settings page body divs
Fix save button position on Global YAML settings page

Screenshots

Global YAML

codecov-public-qa · 2024-02-27T22:27:39Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc6ad44) 98.41% compared to head (8d14f80) 98.41%.

@@           Coverage Diff           @@
##             main    #2630   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files         850      850           
  Lines       11607    11607           
  Branches     2971     2973    +2     
=======================================
  Hits        11423    11423           
  Misses        182      182           
  Partials        2        2

Files	Coverage Δ
src/pages/AccountSettings/tabs/YAML/YAML.jsx	`100.00% <100.00%> (ø)`
src/pages/RepoPage/SettingsTab/SettingsTab.jsx	`100.00% <ø> (ø)`
...ngsTab/tabs/BadgesAndGraphsTab/Graphs/URLEmbed.jsx	`100.00% <ø> (ø)`
...b/tabs/GeneralTab/Tokens/GraphToken/GraphToken.jsx	`100.00% <ø> (ø)`
...eralTab/Tokens/RepoUploadToken/RepoUploadToken.jsx	`100.00% <ø> (ø)`
...es/RepoPage/SettingsTab/tabs/YamlTab/YAML/YAML.jsx	`100.00% <ø> (ø)`
...ages/RepoPage/SettingsTab/tabs/YamlTab/YamlTab.jsx	`100.00% <ø> (ø)`
src/ui/SettingsDescriptor/SettingsDescriptor.jsx	`100.00% <ø> (ø)`

Components	Coverage Δ
Assets	`55.55% <ø> (ø)`
Layouts	`97.00% <ø> (ø)`
Pages	`99.34% <100.00%> (ø)`
Services	`99.61% <ø> (ø)`
Shared	`99.83% <ø> (ø)`
UI	`94.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc6ad44...8d14f80. Read the comment docs.

codecov-qa · 2024-02-27T22:27:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (fc6ad44) to head (8d14f80).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2630   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files         850      850           
  Lines       11607    11607           
  Branches     3018     3008   -10     
=======================================
  Hits        11423    11423           
  Misses        182      182           
  Partials        2        2

Files	Coverage Δ
src/pages/AccountSettings/tabs/YAML/YAML.jsx	`100.00% <100.00%> (ø)`
src/pages/RepoPage/SettingsTab/SettingsTab.jsx	`100.00% <ø> (ø)`
...ngsTab/tabs/BadgesAndGraphsTab/Graphs/URLEmbed.jsx	`100.00% <ø> (ø)`
...b/tabs/GeneralTab/Tokens/GraphToken/GraphToken.jsx	`100.00% <ø> (ø)`
...eralTab/Tokens/RepoUploadToken/RepoUploadToken.jsx	`100.00% <ø> (ø)`
...es/RepoPage/SettingsTab/tabs/YamlTab/YAML/YAML.jsx	`100.00% <ø> (ø)`
...ages/RepoPage/SettingsTab/tabs/YamlTab/YamlTab.jsx	`100.00% <ø> (ø)`
src/ui/SettingsDescriptor/SettingsDescriptor.jsx	`100.00% <ø> (ø)`

Components	Coverage Δ
Assets	`55.55% <ø> (ø)`
Layouts	`97.00% <ø> (ø)`
Pages	`99.34% <100.00%> (ø)`
Services	`99.61% <ø> (ø)`
Shared	`99.83% <ø> (ø)`
UI	`94.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc6ad44...8d14f80. Read the comment docs.

netlify · 2024-02-27T22:28:03Z

✅ Deploy Preview for gazebo-staging ready!

Name	Link
🔨 Latest commit	`8d14f80`
🔍 Latest deploy log	https://app.netlify.com/sites/gazebo-staging/deploys/65e0b0e75a815600088dcab7
😎 Deploy Preview	https://deploy-preview-2630--gazebo-staging.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov · 2024-02-27T22:28:04Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (fc6ad44) to head (8d14f80).

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #2630   +/-   ##
=====================================
  Coverage   98.41   98.41           
=====================================
  Files        850     850           
  Lines      11607   11607           
  Branches    2971    3018   +47     
=====================================
  Hits       11423   11423           
  Misses       182     182           
  Partials       2       2

Files	Coverage Δ
src/pages/AccountSettings/tabs/YAML/YAML.jsx	`100.00% <100.00%> (ø)`
src/pages/RepoPage/SettingsTab/SettingsTab.jsx	`100.00% <ø> (ø)`
...ngsTab/tabs/BadgesAndGraphsTab/Graphs/URLEmbed.jsx	`100.00% <ø> (ø)`
...b/tabs/GeneralTab/Tokens/GraphToken/GraphToken.jsx	`100.00% <ø> (ø)`
...eralTab/Tokens/RepoUploadToken/RepoUploadToken.jsx	`100.00% <ø> (ø)`
...es/RepoPage/SettingsTab/tabs/YamlTab/YAML/YAML.jsx	`100.00% <ø> (ø)`
...ages/RepoPage/SettingsTab/tabs/YamlTab/YamlTab.jsx	`100.00% <ø> (ø)`
src/ui/SettingsDescriptor/SettingsDescriptor.jsx	`100.00% <ø> (ø)`

Components	Coverage Δ
Assets	`55.55% <ø> (ø)`
Layouts	`97.00% <ø> (ø)`
Pages	`99.34% <100.00%> (ø)`
Services	`99.61% <ø> (ø)`
Shared	`99.83% <ø> (ø)`
UI	`94.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc6ad44...8d14f80. Read the comment docs.

codecov-staging · 2024-02-27T22:28:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main    #2630      +/-   ##
==========================================
+ Coverage   85.20%   85.77%   +0.56%     
==========================================
  Files         848      848              
  Lines       11602    11605       +3     
  Branches     3018     3018              
==========================================
+ Hits         9886     9954      +68     
+ Misses       1700     1628      -72     
- Partials       16       23       +7

Files	Coverage Δ
src/pages/AccountSettings/tabs/YAML/YAML.jsx	`100.00% <100.00%> (ø)`
src/pages/RepoPage/SettingsTab/SettingsTab.jsx	`100.00% <ø> (ø)`
...ngsTab/tabs/BadgesAndGraphsTab/Graphs/URLEmbed.jsx	`100.00% <ø> (ø)`
...b/tabs/GeneralTab/Tokens/GraphToken/GraphToken.jsx	`100.00% <ø> (ø)`
...eralTab/Tokens/RepoUploadToken/RepoUploadToken.jsx	`100.00% <ø> (ø)`
...es/RepoPage/SettingsTab/tabs/YamlTab/YAML/YAML.jsx	`100.00% <ø> (ø)`
...ages/RepoPage/SettingsTab/tabs/YamlTab/YamlTab.jsx	`100.00% <ø> (ø)`
src/ui/SettingsDescriptor/SettingsDescriptor.jsx	`100.00% <ø> (ø)`

... and 183 files with indirect coverage changes

Components	Coverage Δ
Assets	`54.92% <ø> (-0.30%)`	⬇️
Layouts	`97.00% <ø> (ø)`
Pages	`76.21% <100.00%> (+1.21%)`	⬆️
Services	`98.83% <ø> (-0.65%)`	⬇️
Shared	`99.42% <ø> (+0.41%)`	⬆️
UI	`93.80% <ø> (+0.08%)`	⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc6ad44...8d14f80. Read the comment docs.

codecov-staging · 2024-02-27T22:28:56Z

Bundle Report

Changes will increase total bundle size by 75 bytes ⬆️

Bundle name	Size	Change
gazebo-staging-array-push	5.9MB	75 bytes ⬆️

codecov · 2024-02-27T22:30:21Z

Bundle Report

Changes will increase total bundle size by 83 bytes ⬆️

Bundle name	Size	Change
gazebo-production-array-push	5.9MB	83 bytes ⬆️

codecov-releaser · 2024-02-27T22:32:33Z

Visit https://preview-pr-2630.codecov.dev for your PR preview. Expires after 1 month automatically. Enterprise URL: https://preview-pr-2630-enterprise.codecov.dev

nicholas-codecov

Send it

ajay-sentry

lgtm! Thanks for the screenshot

Style tweaks across the settings pages. GH codecov/engineering-team#888

spalmurray-codecov added 6 commits February 28, 2024 12:45

Update YAML settings page

c2fb9ca

Update YAML settings page with correct width

2cc9b9c

Update Repo settings general tab layout

22e0fbf

Update couple more repo settings widths so that everything is uniform

27cc82a

Move yaml editor size change out of YamlEditor.jsx

f34fe6f

Change md: to lg:

d15dc31

spalmurray-codecov force-pushed the gh-eng-888-settings-polish branch from a37f2fb to d15dc31 Compare February 28, 2024 18:21

Merge branch 'main' into gh-eng-888-settings-polish

27e16c2

spalmurray-codecov marked this pull request as ready for review February 28, 2024 22:00

spalmurray-codecov force-pushed the gh-eng-888-settings-polish branch from 9d81d48 to 27e16c2 Compare February 29, 2024 14:07

nicholas-codecov approved these changes Feb 29, 2024

View reviewed changes

Merge branch 'main' into gh-eng-888-settings-polish

8d14f80

ajay-sentry approved these changes Feb 29, 2024

View reviewed changes

spalmurray-codecov merged commit 8844d06 into main Feb 29, 2024
61 checks passed

spalmurray-codecov deleted the gh-eng-888-settings-polish branch February 29, 2024 18:54

RulaKhaled pushed a commit that referenced this pull request Mar 8, 2024

style: Fix settings style inconsistencies (#2630)

5490239

Style tweaks across the settings pages. GH codecov/engineering-team#888

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

style: Fix settings style inconsistencies #2630

style: Fix settings style inconsistencies #2630

spalmurray-codecov commented Feb 27, 2024 •

edited

codecov-public-qa bot commented Feb 27, 2024 •

edited

codecov-qa bot commented Feb 27, 2024 •

edited

netlify bot commented Feb 27, 2024 •

edited

codecov bot commented Feb 27, 2024 •

edited

codecov-staging bot commented Feb 27, 2024 •

edited

codecov-staging bot commented Feb 27, 2024

codecov bot commented Feb 27, 2024 •

edited

codecov-releaser commented Feb 27, 2024

nicholas-codecov left a comment

ajay-sentry left a comment

style: Fix settings style inconsistencies #2630

style: Fix settings style inconsistencies #2630

Conversation

spalmurray-codecov commented Feb 27, 2024 • edited

Description

Notable Changes

Screenshots

codecov-public-qa bot commented Feb 27, 2024 • edited

Codecov Report

codecov-qa bot commented Feb 27, 2024 • edited

Codecov Report

netlify bot commented Feb 27, 2024 • edited

✅ Deploy Preview for gazebo-staging ready!

codecov bot commented Feb 27, 2024 • edited

Codecov Report

codecov-staging bot commented Feb 27, 2024 • edited

Codecov Report

codecov-staging bot commented Feb 27, 2024

Bundle Report

codecov bot commented Feb 27, 2024 • edited

Bundle Report

codecov-releaser commented Feb 27, 2024

nicholas-codecov left a comment

Choose a reason for hiding this comment

ajay-sentry left a comment

Choose a reason for hiding this comment

spalmurray-codecov commented Feb 27, 2024 •

edited

codecov-public-qa bot commented Feb 27, 2024 •

edited

codecov-qa bot commented Feb 27, 2024 •

edited

netlify bot commented Feb 27, 2024 •

edited

codecov bot commented Feb 27, 2024 •

edited

codecov-staging bot commented Feb 27, 2024 •

edited

codecov bot commented Feb 27, 2024 •

edited