-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add feedback banner for team plan users #2632
Conversation
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…cov/gazebo into rvinnakota/team-plan-banner
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Visit https://preview-pr-2632.codecov.dev for your PR preview. Expires after 1 month automatically. Enterprise URL: https://preview-pr-2632-enterprise.codecov.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #2632 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 847 848 +1
Lines 11507 11518 +11
Branches 2983 2985 +2
=======================================
+ Hits 11321 11332 +11
Misses 184 184
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2632 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 847 848 +1
Lines 11507 11518 +11
Branches 2983 2975 -8
=======================================
+ Hits 11321 11332 +11
Misses 184 184
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2632 +/- ##
=======================================
+ Coverage 98.38 98.39 +0.01
=======================================
Files 847 848 +1
Lines 11507 11518 +11
Branches 2973 2938 -35
=======================================
+ Hits 11321 11332 +11
Misses 184 184
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 2.21kB ⬆️
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #2632 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 847 848 +1
Lines 11507 11518 +11
Branches 2973 2985 +12
=======================================
+ Hits 11321 11332 +11
Misses 184 184
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
src/shared/GlobalTopBanners/TeamPlanFeedbackBanner/TeamPlanFeedbackBanner.spec.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one suggestion, lgtm otherwise!
This banner renders for users on the team plan and links to a google forms survey.
Screen.Recording.2024-02-28.at.11.45.45.AM.mov
Linked design in issue. This PR closes codecov/engineering-team#1065.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.