Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add feedback banner for team plan users #2632

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Feb 28, 2024

This banner renders for users on the team plan and links to a google forms survey.

Screen.Recording.2024-02-28.at.11.45.45.AM.mov

Linked design in issue. This PR closes codecov/engineering-team#1065.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit f2840d1
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65df67449a779d0008401104
😎 Deploy Preview https://deploy-preview-2632--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit dc34b66
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65df677dfe29d00008134fc5
😎 Deploy Preview https://deploy-preview-2632--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-releaser
Copy link
Contributor

Visit https://preview-pr-2632.codecov.dev for your PR preview. Expires after 1 month automatically. Enterprise URL: https://preview-pr-2632-enterprise.codecov.dev

Copy link

codecov-public-qa bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (744de7b) 98.38% compared to head (d6d3713) 98.38%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2632   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         847      848    +1     
  Lines       11507    11518   +11     
  Branches     2983     2985    +2     
=======================================
+ Hits        11321    11332   +11     
  Misses        184      184           
  Partials        2        2           
Files Coverage Δ
src/services/navigation/useNavLinks/useNavLinks.js 99.12% <100.00%> (+<0.01%) ⬆️
src/shared/GlobalTopBanners/GlobalTopBanners.tsx 100.00% <100.00%> (ø)
.../TeamPlanFeedbackBanner/TeamPlanFeedbackBanner.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 97.00% <ø> (ø)
Pages 99.33% <ø> (ø)
Services 99.60% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <100.00%> (+<0.01%) ⬆️
UI 94.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 744de7b...d6d3713. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (744de7b) to head (d6d3713).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2632   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         847      848    +1     
  Lines       11507    11518   +11     
  Branches     2983     2975    -8     
=======================================
+ Hits        11321    11332   +11     
  Misses        184      184           
  Partials        2        2           
Files Coverage Δ
src/services/navigation/useNavLinks/useNavLinks.js 99.12% <100.00%> (+<0.01%) ⬆️
src/shared/GlobalTopBanners/GlobalTopBanners.tsx 100.00% <100.00%> (ø)
.../TeamPlanFeedbackBanner/TeamPlanFeedbackBanner.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 97.00% <ø> (ø)
Pages 99.33% <ø> (ø)
Services 99.60% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <100.00%> (+<0.01%) ⬆️
UI 94.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 744de7b...d6d3713. Read the comment docs.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.39%. Comparing base (744de7b) to head (d6d3713).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2632     +/-   ##
=======================================
+ Coverage   98.38   98.39   +0.01     
=======================================
  Files        847     848      +1     
  Lines      11507   11518     +11     
  Branches    2973    2938     -35     
=======================================
+ Hits       11321   11332     +11     
  Misses       184     184             
  Partials       2       2             
Files Coverage Δ
src/services/navigation/useNavLinks/useNavLinks.js 99.12% <100.00%> (+<0.01%) ⬆️
src/shared/GlobalTopBanners/GlobalTopBanners.tsx 100.00% <100.00%> (ø)
.../TeamPlanFeedbackBanner/TeamPlanFeedbackBanner.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 97.00% <ø> (ø)
Pages 99.33% <ø> (ø)
Services 99.60% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <100.00%> (+<0.01%) ⬆️
UI 94.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 744de7b...d6d3713. Read the comment docs.

@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review February 28, 2024 17:14
Copy link

codecov bot commented Feb 28, 2024

Bundle Report

Changes will increase total bundle size by 2.21kB ⬆️

Bundle name Size Change
gazebo-production-array-push 5.9MB 2.21kB ⬆️

Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit d6d3713
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65df68ac79ddaf000833b162
😎 Deploy Preview https://deploy-preview-2632--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2632   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         847      848    +1     
  Lines       11507    11518   +11     
  Branches     2973     2985   +12     
=======================================
+ Hits        11321    11332   +11     
  Misses        184      184           
  Partials        2        2           
Files Coverage Δ
src/services/navigation/useNavLinks/useNavLinks.js 99.12% <100.00%> (+<0.01%) ⬆️
src/shared/GlobalTopBanners/GlobalTopBanners.tsx 100.00% <100.00%> (ø)
.../TeamPlanFeedbackBanner/TeamPlanFeedbackBanner.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 97.00% <ø> (ø)
Pages 99.33% <ø> (ø)
Services 99.60% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <100.00%> (+<0.01%) ⬆️
UI 94.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 744de7b...d6d3713. Read the comment docs.

Copy link
Contributor

@spalmurray-codecov spalmurray-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one suggestion, lgtm otherwise!

@rohitvinnakota-codecov rohitvinnakota-codecov merged commit b8a3d13 into main Feb 28, 2024
62 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/team-plan-banner branch February 28, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback Solicitation for New Team Plan
3 participants