feat: Update assets table to have modules table expander #2635

nicholas-codecov · 2024-02-29T13:37:40Z

Description

This PR adds in a new ModulesTable that is used as the sub-component for what the asset table is expanded. It shows all of the modules that make up that given asset, their type, size, and estimated download time.

Closes codecov/engineering-team#1211

Notable Changes

Create new ModulesTable component
Update AssetsTable
Update tests

Screenshots

codecov-public-qa · 2024-02-29T13:40:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (adf8d2c) 18.98% compared to head (0b140c9) 98.41%.

@@             Coverage Diff             @@
##             main    #2635       +/-   ##
===========================================
+ Coverage   18.98%   98.41%   +79.43%     
===========================================
  Files         822      851       +29     
  Lines       11528    11637      +109     
  Branches     2971     2981       +10     
===========================================
+ Hits         2189    11453     +9264     
+ Misses       9151      182     -8969     
+ Partials      188        2      -186

Files	Coverage Δ
...ndlesTab/BundleContent/AssetsTable/AssetsTable.tsx	`100.00% <100.00%> (+100.00%)`	⬆️
...dlesTab/BundleContent/AssetsTable/ModulesTable.tsx	`100.00% <100.00%> (ø)`
...epoPage/BundlesTab/BundleContent/BundleContent.tsx	`100.00% <100.00%> (+100.00%)`	⬆️
.../services/bundleAnalysis/useBundleAssetModules.tsx	`100.00% <100.00%> (+100.00%)`	⬆️

... and 657 files with indirect coverage changes

Components	Coverage Δ
Assets	`55.55% <ø> (+5.55%)`	⬆️
Layouts	`97.00% <ø> (+93.47%)`	⬆️
Pages	`99.34% <100.00%> (+99.05%)`	⬆️
Services	`99.61% <100.00%> (+72.11%)`	⬆️
Shared	`99.83% <ø> (+14.84%)`	⬆️
UI	`94.14% <ø> (+59.15%)`	⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf8d2c...0b140c9. Read the comment docs.

codecov-qa · 2024-02-29T13:40:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (adf8d2c) to head (0b140c9).

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2635       +/-   ##
===========================================
+ Coverage   18.98%   98.41%   +79.43%     
===========================================
  Files         822      851       +29     
  Lines       11528    11637      +109     
  Branches     3018     2981       -37     
===========================================
+ Hits         2189    11453     +9264     
+ Misses       9144      182     -8962     
+ Partials      195        2      -193

Files	Coverage Δ
...ndlesTab/BundleContent/AssetsTable/AssetsTable.tsx	`100.00% <100.00%> (+100.00%)`	⬆️
...dlesTab/BundleContent/AssetsTable/ModulesTable.tsx	`100.00% <100.00%> (ø)`
...epoPage/BundlesTab/BundleContent/BundleContent.tsx	`100.00% <100.00%> (+100.00%)`	⬆️
.../services/bundleAnalysis/useBundleAssetModules.tsx	`100.00% <100.00%> (+100.00%)`	⬆️

... and 657 files with indirect coverage changes

Components	Coverage Δ
Assets	`55.55% <ø> (+5.55%)`	⬆️
Layouts	`97.00% <ø> (+93.47%)`	⬆️
Pages	`99.34% <100.00%> (+99.05%)`	⬆️
Services	`99.61% <100.00%> (+72.11%)`	⬆️
Shared	`99.83% <ø> (+14.84%)`	⬆️
UI	`94.14% <ø> (+59.15%)`	⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf8d2c...0b140c9. Read the comment docs.

netlify · 2024-02-29T13:42:11Z

✅ Deploy Preview for gazebo-staging ready!

Name	Link
🔨 Latest commit	`0b140c9`
🔍 Latest deploy log	https://app.netlify.com/sites/gazebo-staging/deploys/65e0fb6a5f41ca000825cc2d
😎 Deploy Preview	https://deploy-preview-2635--gazebo-staging.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov-staging · 2024-02-29T13:42:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff           @@
##             main    #2635   +/-   ##
=======================================
  Coverage        ?   89.31%           
=======================================
  Files           ?      849           
  Lines           ?    11632           
  Branches        ?     3034           
=======================================
  Hits            ?    10389           
  Misses          ?     1217           
  Partials        ?       26

Files	Coverage Δ
...ndlesTab/BundleContent/AssetsTable/AssetsTable.tsx	`100.00% <100.00%> (ø)`
...dlesTab/BundleContent/AssetsTable/ModulesTable.tsx	`100.00% <100.00%> (ø)`
...epoPage/BundlesTab/BundleContent/BundleContent.tsx	`100.00% <100.00%> (ø)`
.../services/bundleAnalysis/useBundleAssetModules.tsx	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`52.94% <ø> (?)`
Layouts	`19.33% <ø> (?)`
Pages	`88.08% <100.00%> (?)`
Services	`99.56% <100.00%> (?)`
Shared	`99.83% <ø> (?)`
UI	`93.97% <ø> (?)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf8d2c...0b140c9. Read the comment docs.

codecov · 2024-02-29T13:42:32Z

Bundle Report

Changes will increase total bundle size by 5.61kB ⬆️

Bundle name	Size	Change
gazebo-production-array-push	5.91MB	5.61kB ⬆️

codecov · 2024-02-29T13:42:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.42%. Comparing base (adf8d2c) to head (0b140c9).

Additional details and impacted files

@@           Coverage Diff            @@
##            main   #2635      +/-   ##
========================================
+ Coverage   18.99   98.42   +79.43     
========================================
  Files        822     851      +29     
  Lines      11528   11637     +109     
  Branches    2971    2981      +10     
========================================
+ Hits        2189   11453    +9264     
+ Misses      9151     182    -8969     
+ Partials     188       2     -186

Files	Coverage Δ
...ndlesTab/BundleContent/AssetsTable/AssetsTable.tsx	`100.00% <100.00%> (+100.00%)`	⬆️
...dlesTab/BundleContent/AssetsTable/ModulesTable.tsx	`100.00% <100.00%> (ø)`
...epoPage/BundlesTab/BundleContent/BundleContent.tsx	`100.00% <100.00%> (+100.00%)`	⬆️
.../services/bundleAnalysis/useBundleAssetModules.tsx	`100.00% <100.00%> (+100.00%)`	⬆️

... and 657 files with indirect coverage changes

Components	Coverage Δ
Assets	`55.55% <ø> (+5.55%)`	⬆️
Layouts	`97.00% <ø> (+93.47%)`	⬆️
Pages	`99.34% <100.00%> (+99.05%)`	⬆️
Services	`99.61% <100.00%> (+72.11%)`	⬆️
Shared	`99.83% <ø> (+14.84%)`	⬆️
UI	`94.14% <ø> (+59.15%)`	⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf8d2c...0b140c9. Read the comment docs.

codecov-releaser · 2024-02-29T13:46:25Z

Visit https://preview-pr-2635.codecov.dev for your PR preview. Expires after 1 month automatically. Enterprise URL: https://preview-pr-2635-enterprise.codecov.dev

src/services/bundleAnalysis/useBundleAssetModules.tsx

spalmurray-codecov

code looks good

spalmurray-codecov · 2024-02-29T14:40:53Z

I feel like at least the two right columns here should be aligned. The left one I think I could be convinced to leave it or align it. Lmk your thoughts

nicholas-codecov · 2024-02-29T14:59:33Z

I feel like at least the two right columns here should be aligned. The left one I think I could be convinced to leave it or align it. Lmk your thoughts

I think for the name column it's fine, it aligns with the expander arrow which is part of the name column, I have fixed up the other two columns however.

…les-table-expander

Create new ModulesTable component and use in the Assets table in the updated bundles tab. GH codecov/engineering-team#1211

nicholas-codecov added 3 commits February 29, 2024 08:30

slight tweak to useBundleAssetModules

a61bfcc

add in new modules table component

b0c83c3

update AssetsTable to use new modules table component

c85846e

spalmurray-codecov reviewed Feb 29, 2024

View reviewed changes

src/services/bundleAnalysis/useBundleAssetModules.tsx Show resolved Hide resolved

spalmurray-codecov approved these changes Feb 29, 2024

View reviewed changes

nicholas-codecov added 2 commits February 29, 2024 09:58

fix up small issue with bundle content not passing branch

2ffb853

fix up modules table styling

36082f2

nicholas-codecov added 7 commits February 29, 2024 10:08

Merge branch 'main' into gh-eng-1211-update-assets-table-to-have-modu…

3a5ae46

…les-table-expander

fix responsive styles for assets table

c3b4543

small fix to tests

9b4b005

should be the last test fix

f2c2373

Merge branch 'main' into gh-eng-1211-update-assets-table-to-have-modu…

b36cfa9

…les-table-expander

Merge branch 'main' into gh-eng-1211-update-assets-table-to-have-modu…

9694345

…les-table-expander

Merge branch 'main' into gh-eng-1211-update-assets-table-to-have-modu…

0b140c9

…les-table-expander

nicholas-codecov merged commit 9b973f2 into main Feb 29, 2024
53 checks passed

nicholas-codecov deleted the gh-eng-1211-update-assets-table-to-have-modules-table-expander branch February 29, 2024 21:55

RulaKhaled pushed a commit that referenced this pull request Mar 8, 2024

feat: Update assets table to have modules table expander (#2635)

4886a5c

Create new ModulesTable component and use in the Assets table in the updated bundles tab. GH codecov/engineering-team#1211

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Update assets table to have modules table expander #2635

feat: Update assets table to have modules table expander #2635

nicholas-codecov commented Feb 29, 2024

codecov-public-qa bot commented Feb 29, 2024 •

edited

codecov-qa bot commented Feb 29, 2024 •

edited

netlify bot commented Feb 29, 2024 •

edited

codecov-staging bot commented Feb 29, 2024 •

edited

codecov bot commented Feb 29, 2024 •

edited

codecov bot commented Feb 29, 2024 •

edited

codecov-releaser commented Feb 29, 2024

spalmurray-codecov left a comment

spalmurray-codecov commented Feb 29, 2024

nicholas-codecov commented Feb 29, 2024

feat: Update assets table to have modules table expander #2635

feat: Update assets table to have modules table expander #2635

Conversation

nicholas-codecov commented Feb 29, 2024

Description

Notable Changes

Screenshots

codecov-public-qa bot commented Feb 29, 2024 • edited

Codecov Report

codecov-qa bot commented Feb 29, 2024 • edited

Codecov Report

netlify bot commented Feb 29, 2024 • edited

✅ Deploy Preview for gazebo-staging ready!

codecov-staging bot commented Feb 29, 2024 • edited

Codecov Report

codecov bot commented Feb 29, 2024 • edited

Bundle Report

codecov bot commented Feb 29, 2024 • edited

Codecov Report

codecov-releaser commented Feb 29, 2024

spalmurray-codecov left a comment

Choose a reason for hiding this comment

spalmurray-codecov commented Feb 29, 2024

nicholas-codecov commented Feb 29, 2024

codecov-public-qa bot commented Feb 29, 2024 •

edited

codecov-qa bot commented Feb 29, 2024 •

edited

netlify bot commented Feb 29, 2024 •

edited

codecov-staging bot commented Feb 29, 2024 •

edited

codecov bot commented Feb 29, 2024 •

edited

codecov bot commented Feb 29, 2024 •

edited