Update select placement on PR detail page #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/codecov/gazebo into rvinnakota/file-viewer-select-change
….com/codecov/gazebo into rvinnakota/file-viewer-select-change
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2675 +/- ##
=======================================
+ Coverage 98.40 98.41 +0.01
=======================================
Files 852 853 +1
Lines 12055 12068 +13
Branches 3112 3174 +62
=======================================
+ Hits 11862 11876 +14
+ Misses 188 187 -1
Partials 5 5
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2675 +/- ##
==========================================
+ Coverage 98.39% 98.40% +0.01%
==========================================
Files 852 853 +1
Lines 12055 12068 +13
Branches 3149 3174 +25
==========================================
+ Hits 11862 11876 +14
+ Misses 188 187 -1
Partials 5 5
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2675 +/- ##
==========================================
+ Coverage 98.39% 98.40% +0.01%
==========================================
Files 852 853 +1
Lines 12055 12068 +13
Branches 3166 3119 -47
==========================================
+ Hits 11862 11876 +14
+ Misses 188 187 -1
Partials 5 5
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
…m/codecov/gazebo into rvinnakota/update-pr-page-selects
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #2675 +/- ##
==========================================
+ Coverage 98.39% 98.40% +0.01%
==========================================
Files 852 853 +1
Lines 12055 12068 +13
Branches 3112 3156 +44
==========================================
+ Hits 11862 11876 +14
+ Misses 188 187 -1
Partials 5 5
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
rohitvinnakota-codecov
changed the title
|
Nice work, a few notes:
|
RulaKhaled
reviewed
Mar 13, 2024
RulaKhaled
reviewed
Mar 13, 2024
...questPage/PullCoverage/routes/IndirectChangesTab/IndirectChangesInfo/IndirectChangesInfo.jsx
Outdated
Show resolved
Hide resolved
RulaKhaled
approved these changes
Mar 19, 2024
…ota/update-pr-page-selects
Bundle ReportChanges will increase total bundle size by 84.69kB ⬆️
|
Bundle ReportChanges will increase total bundle size by 84.69kB ⬆️
|
This was referenced Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes a few changes to the key and selects(flags and components) on the PR detail page. More info can be found here: codecov/engineering-team#836
Changes
Screenshots
BEFORE
AFTER
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.