Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[fix] Show install help banner in global top banners" #2691

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

Reverts #2684

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.44%. Comparing base (e4b5adf) to head (27dda74).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2691   +/-   ##
=====================================
  Coverage   98.44   98.44           
=====================================
  Files        854     854           
  Lines      11903   11903           
  Branches    3120    3120           
=====================================
  Hits       11717   11717           
  Misses       183     183           
  Partials       3       3           
Files Coverage Δ
src/shared/GlobalTopBanners/GlobalTopBanners.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.33% <ø> (ø)
Services 99.61% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4b5adf...27dda74. Read the comment docs.

Copy link

codecov-public-qa bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4b5adf) 98.43% compared to head (27dda74) 98.43%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2691   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files         854      854           
  Lines       11903    11903           
  Branches     3078     3120   +42     
=======================================
  Hits        11717    11717           
  Misses        183      183           
  Partials        3        3           
Files Coverage Δ
src/shared/GlobalTopBanners/GlobalTopBanners.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.33% <ø> (ø)
Services 99.61% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4b5adf...27dda74. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.43%. Comparing base (e4b5adf) to head (27dda74).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2691   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files         854      854           
  Lines       11903    11903           
  Branches     3128     3120    -8     
=======================================
  Hits        11717    11717           
  Misses        183      183           
  Partials        3        3           
Files Coverage Δ
src/shared/GlobalTopBanners/GlobalTopBanners.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.33% <ø> (ø)
Services 99.61% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4b5adf...27dda74. Read the comment docs.

@ajay-sentry ajay-sentry marked this pull request as ready for review March 13, 2024 01:50
@ajay-sentry ajay-sentry merged commit acd5452 into main Mar 13, 2024
49 checks passed
@ajay-sentry ajay-sentry deleted the revert-2684-rvinnakota/install-banner-display branch March 13, 2024 01:52
@codecov-releaser
Copy link
Contributor

codecov-releaser commented Mar 13, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
27dda74 Wed, 13 Mar 2024 02:03:52 GMT Expired Expired
27dda74 Wed, 13 Mar 2024 02:04:13 GMT Cloud Enterprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants