Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Refactor usRepoFlags to ts #2729

Merged
merged 5 commits into from
Apr 2, 2024
Merged

ref: Refactor usRepoFlags to ts #2729

merged 5 commits into from
Apr 2, 2024

Conversation

RulaKhaled
Copy link
Contributor

@RulaKhaled RulaKhaled commented Mar 25, 2024

Description

closes: #2579

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov-public-qa bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb5e6b3) 98.43% compared to head (e1ae119) 98.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2729      +/-   ##
==========================================
- Coverage   98.43%   98.40%   -0.03%     
==========================================
  Files         852      852              
  Lines       12041    12055      +14     
  Branches     3107     3170      +63     
==========================================
+ Hits        11852    11863      +11     
- Misses        185      187       +2     
- Partials        4        5       +1     
Files Coverage Δ
src/services/repo/useRepoFlags.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.26% <ø> (-0.05%) ⬇️
Services 99.58% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb5e6b3...e1ae119. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2729      +/-   ##
==========================================
- Coverage   98.43%   98.40%   -0.03%     
==========================================
  Files         852      852              
  Lines       12041    12055      +14     
  Branches     3160     3149      -11     
==========================================
+ Hits        11852    11863      +11     
- Misses        185      187       +2     
- Partials        4        5       +1     
Files Coverage Δ
src/services/repo/useRepoFlags.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.26% <ø> (-0.05%) ⬇️
Services 99.58% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb5e6b3...e1ae119. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (eb5e6b3) to head (e1ae119).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2729      +/-   ##
==========================================
- Coverage   98.43%   98.40%   -0.03%     
==========================================
  Files         852      852              
  Lines       12041    12055      +14     
  Branches     3160     3166       +6     
==========================================
+ Hits        11852    11863      +11     
- Misses        185      187       +2     
- Partials        4        5       +1     
Files Coverage Δ
src/services/repo/useRepoFlags.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.26% <ø> (-0.05%) ⬇️
Services 99.58% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb5e6b3...e1ae119. Read the comment docs.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (eb5e6b3) to head (e1ae119).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2729     +/-   ##
=======================================
- Coverage   98.43   98.41   -0.02     
=======================================
  Files        852     852             
  Lines      12041   12055     +14     
  Branches    3160    3112     -48     
=======================================
+ Hits       11852   11863     +11     
- Misses       185     187      +2     
- Partials       4       5      +1     
Files Coverage Δ
src/services/repo/useRepoFlags.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.26% <ø> (-0.05%) ⬇️
Services 99.58% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb5e6b3...e1ae119. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Mar 25, 2024

Bundle Report

Changes will increase total bundle size by 1.46kB ⬆️

Bundle name Size Change
gazebo-staging-array-push 5.95MB 1.46kB ⬆️

Copy link

codecov bot commented Mar 25, 2024

Bundle Report

Changes will increase total bundle size by 1.44kB ⬆️

Bundle name Size Change
gazebo-production-array-push 5.96MB 1.44kB ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Mar 25, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
fe06114 Mon, 25 Mar 2024 18:13:51 GMT Expired Expired
fe06114 Mon, 25 Mar 2024 18:27:12 GMT Expired Expired
360e3e5 Tue, 26 Mar 2024 14:36:31 GMT Expired Expired
360e3e5 Tue, 26 Mar 2024 14:53:33 GMT Expired Expired
360e3e5 Tue, 26 Mar 2024 14:53:34 GMT Expired Expired
e08f414 Wed, 27 Mar 2024 11:19:54 GMT Expired Expired
dcae81c Tue, 02 Apr 2024 10:37:18 GMT Expired Expired
e1ae119 Tue, 02 Apr 2024 14:12:06 GMT Cloud Enterprise

@RulaKhaled RulaKhaled marked this pull request as draft March 25, 2024 18:16
@RulaKhaled RulaKhaled marked this pull request as ready for review March 26, 2024 14:40
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than little type change suggested!

RulaKhaled and others added 2 commits April 2, 2024 15:37
Co-authored-by: Spencer Murray <159931558+spalmurray-codecov@users.noreply.github.com>
@RulaKhaled RulaKhaled merged commit 3b2002b into main Apr 2, 2024
53 of 58 checks passed
@RulaKhaled RulaKhaled deleted the refactor-to-ts branch April 2, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useReposFlags refactor to ts
3 participants