Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create new hook useRepoComponentsSelect #2732

Merged
merged 7 commits into from
Apr 3, 2024

Conversation

RulaKhaled
Copy link
Contributor

Description

closes: codecov/engineering-team#1373

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 238 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 5.95MB 238 bytes ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Mar 27, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
f631cdf Wed, 27 Mar 2024 10:54:14 GMT Expired Expired
f631cdf Wed, 27 Mar 2024 10:59:51 GMT Expired Expired
f631cdf Thu, 28 Mar 2024 13:28:10 GMT Expired Expired
226d77e Wed, 03 Apr 2024 09:47:52 GMT Expired Expired
226d77e Wed, 03 Apr 2024 09:49:36 GMT Expired Expired
6137d3e Wed, 03 Apr 2024 15:11:58 GMT Expired Expired
d3f7693 Wed, 03 Apr 2024 16:04:05 GMT Cloud Enterprise

Copy link

codecov bot commented Mar 27, 2024

Bundle Report

Bundle size has no change ✅

@RulaKhaled RulaKhaled marked this pull request as draft March 28, 2024 13:19
@RulaKhaled
Copy link
Contributor Author

Description

closes: codecov/engineering-team#1373

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Gotta update to use measurements instead

@RulaKhaled RulaKhaled marked this pull request as ready for review April 3, 2024 09:28
@codecov-qa
Copy link

codecov-qa bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (819bd90) to head (93c3d85).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2732      +/-   ##
==========================================
- Coverage   98.41%   98.40%   -0.01%     
==========================================
  Files         854      855       +1     
  Lines       12099    12119      +20     
  Branches     3192     3139      -53     
==========================================
+ Hits        11907    11926      +19     
- Misses        187      188       +1     
  Partials        5        5              
Files Coverage Δ
src/services/repo/useRepoComponentsSelect.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.25% <ø> (-0.02%) ⬇️
Services 99.59% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 819bd90...93c3d85. Read the comment docs.

Copy link

codecov-public-qa bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (819bd90) 98.41% compared to head (93c3d85) 98.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2732      +/-   ##
==========================================
- Coverage   98.41%   98.40%   -0.01%     
==========================================
  Files         854      855       +1     
  Lines       12099    12119      +20     
  Branches     3133     3177      +44     
==========================================
+ Hits        11907    11926      +19     
- Misses        187      188       +1     
  Partials        5        5              
Files Coverage Δ
src/services/repo/useRepoComponentsSelect.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.25% <ø> (-0.02%) ⬇️
Services 99.59% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 819bd90...93c3d85. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2732      +/-   ##
==========================================
- Coverage   98.41%   98.40%   -0.01%     
==========================================
  Files         854      855       +1     
  Lines       12099    12119      +20     
  Branches     3192     3199       +7     
==========================================
+ Hits        11907    11926      +19     
- Misses        187      188       +1     
  Partials        5        5              
Files Coverage Δ
src/services/repo/useRepoComponentsSelect.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.25% <ø> (-0.02%) ⬇️
Services 99.59% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 819bd90...93c3d85. Read the comment docs.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (819bd90) to head (93c3d85).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2732   +/-   ##
=====================================
  Coverage   98.41   98.41           
=====================================
  Files        854     855    +1     
  Lines      12099   12119   +20     
  Branches    3192    3140   -52     
=====================================
+ Hits       11907   11926   +19     
- Misses       187     188    +1     
  Partials       5       5           
Files Coverage Δ
src/services/repo/useRepoComponentsSelect.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.25% <ø> (-0.02%) ⬇️
Services 99.59% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 819bd90...93c3d85. Read the comment docs.

@RulaKhaled RulaKhaled merged commit 6e700c5 into main Apr 3, 2024
54 of 58 checks passed
@RulaKhaled RulaKhaled deleted the useRepoComponentsSelect-hook branch April 3, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create hook to retrieve repo components' measurements
3 participants