-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create useRepoComponents hook #2733
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2733 +/- ##
=====================================
Coverage 98.41 98.41
=====================================
Files 853 854 +1
Lines 12068 12095 +27
Branches 3178 3126 -52
=====================================
+ Hits 11876 11903 +27
Misses 187 187
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #2733 +/- ##
=======================================
Coverage 98.40% 98.41%
=======================================
Files 853 854 +1
Lines 12068 12095 +27
Branches 3120 3182 +62
=======================================
+ Hits 11876 11903 +27
Misses 187 187
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2733 +/- ##
=======================================
Coverage 98.40% 98.41%
=======================================
Files 853 854 +1
Lines 12068 12095 +27
Branches 3156 3182 +26
=======================================
+ Hits 11876 11903 +27
Misses 187 187
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2733 +/- ##
=======================================
Coverage 98.40% 98.41%
=======================================
Files 853 854 +1
Lines 12068 12095 +27
Branches 3119 3186 +67
=======================================
+ Hits 11876 11903 +27
Misses 187 187
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 512 bytes ⬆️
|
Bundle ReportChanges will increase total bundle size by 512 bytes ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
}, | ||
}) | ||
|
||
const wrapper = ({ children }: { children: React.ReactNode }) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been told by Nick and Ajay to use wrapper: React.FC<React.PropsWithChildren>
instead of how you've typed this here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One little comment - lgtm otherwise!
* fix: Handle guest feature error, no nested catch * Update tests to reflect graphql error * Fix when to raise an error * my bad bro * Update to re add catch block
Update Sentry deps and bundler plugin config to prepare for incoming fix to source map uploading.
Remove bundle analysis feature flags from Gazebo. GH codecov/engineering-team#999 GH codecov/engineering-team#1214
Description
closes: codecov/engineering-team#1377
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.