Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create useRepoComponents hook #2733

Merged
merged 10 commits into from
Apr 3, 2024
Merged

feat: Create useRepoComponents hook #2733

merged 10 commits into from
Apr 3, 2024

Conversation

RulaKhaled
Copy link
Contributor

Description

closes: codecov/engineering-team#1377

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (b7aa96d) to head (dd5a1be).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2733   +/-   ##
=====================================
  Coverage   98.41   98.41           
=====================================
  Files        853     854    +1     
  Lines      12068   12095   +27     
  Branches    3178    3126   -52     
=====================================
+ Hits       11876   11903   +27     
  Misses       187     187           
  Partials       5       5           
Files Coverage Δ
src/services/repo/useRepoComponents.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.26% <ø> (ø)
Services 99.58% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7aa96d...dd5a1be. Read the comment docs.

Copy link

codecov-public-qa bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b7aa96d) 98.40% compared to head (dd5a1be) 98.41%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2733   +/-   ##
=======================================
  Coverage   98.40%   98.41%           
=======================================
  Files         853      854    +1     
  Lines       12068    12095   +27     
  Branches     3120     3182   +62     
=======================================
+ Hits        11876    11903   +27     
  Misses        187      187           
  Partials        5        5           
Files Coverage Δ
src/services/repo/useRepoComponents.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.26% <ø> (ø)
Services 99.58% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7aa96d...dd5a1be. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2733   +/-   ##
=======================================
  Coverage   98.40%   98.41%           
=======================================
  Files         853      854    +1     
  Lines       12068    12095   +27     
  Branches     3156     3182   +26     
=======================================
+ Hits        11876    11903   +27     
  Misses        187      187           
  Partials        5        5           
Files Coverage Δ
src/services/repo/useRepoComponents.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.26% <ø> (ø)
Services 99.58% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7aa96d...dd5a1be. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (b7aa96d) to head (dd5a1be).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2733   +/-   ##
=======================================
  Coverage   98.40%   98.41%           
=======================================
  Files         853      854    +1     
  Lines       12068    12095   +27     
  Branches     3119     3186   +67     
=======================================
+ Hits        11876    11903   +27     
  Misses        187      187           
  Partials        5        5           
Files Coverage Δ
src/services/repo/useRepoComponents.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.13% <ø> (ø)
Pages 99.26% <ø> (ø)
Services 99.58% <100.00%> (+<0.01%) ⬆️
Shared 99.83% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7aa96d...dd5a1be. Read the comment docs.

@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 512 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 5.96MB 512 bytes ⬆️

Copy link

codecov bot commented Mar 28, 2024

Bundle Report

Changes will increase total bundle size by 512 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 6.05MB 512 bytes ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Mar 28, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
26a75f0 Thu, 28 Mar 2024 13:43:54 GMT Expired Expired
26a75f0 Thu, 28 Mar 2024 13:43:56 GMT Expired Expired
a1d092d Tue, 02 Apr 2024 10:36:20 GMT Expired Expired
a1d092d Tue, 02 Apr 2024 10:37:27 GMT Expired Expired
dd5a1be Wed, 03 Apr 2024 09:21:42 GMT Cloud Enterprise

},
})

const wrapper = ({ children }: { children: React.ReactNode }) => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been told by Nick and Ajay to use wrapper: React.FC<React.PropsWithChildren> instead of how you've typed this here.

Copy link
Contributor

@spalmurray-codecov spalmurray-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little comment - lgtm otherwise!

RulaKhaled and others added 8 commits April 2, 2024 12:27
* fix: Handle guest feature error, no nested catch

* Update tests to reflect graphql error

* Fix when to raise an error

* my bad bro

* Update to re add catch block
Update Sentry deps and bundler plugin config to prepare for incoming fix to source map uploading.
@RulaKhaled RulaKhaled merged commit 8783a90 into main Apr 3, 2024
58 checks passed
@RulaKhaled RulaKhaled deleted the useRepoComponents-hook branch April 3, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create useRepoComponents hook to query Component measurements
4 participants