fix: Onboarding flow TOS & user intent screen UX improvement (Radio input) #2736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When trying out CodeCov for my repository ( wanted to test out bundle size insights before I propose in my org ), I noticed a small
UX issue, when selecting myUser Intent, whether Personal or Business.When clicking on the radio button's label or the description text, I believe the state should switch. On investigation, realized that the id shared between the
inputandlabelwere the same , so made those unique , and the helper label outside the radio button meant that these elements needed to share the id across components, so made a small change in the id creation mechanism as well.TLdr : For RadioInputs, set state on label click or helper text click as well.
Notable Changes
Changes the behavior of the
RadioInputcomponentAdded tests to test this behavior as well.
Screenshots
No visual change
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.