Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create branch selector for the components tab #2756

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

RulaKhaled
Copy link
Contributor

Description

New branch selector for components tab, will be used to reflect on the table.

Notable Changes

Create new branch selector, remove unnecessary feedback link as listed in https://www.figma.com/file/lpCAamL0oUGKvVng0g7vex/GH-234?type=design&node-id=21-787&mode=design&t=j3BVzL3ZezeeEYFB-0

Screenshots

Screenshot 2024-04-08 at 8 34 53 PM Screenshot 2024-04-08 at 8 34 49 PM

Link to Sample Entry

closes: codecov/engineering-team#1381

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (e4fe4dc) to head (8a01ca0).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2756      +/-   ##
==========================================
- Coverage   98.41%   98.40%   -0.01%     
==========================================
  Files         873      874       +1     
  Lines       12471    12496      +25     
  Branches     3241     3289      +48     
==========================================
+ Hits        12273    12297      +24     
- Misses        191      192       +1     
  Partials        7        7              
Files Coverage Δ
...onentsTab/Header/BranchSelector/BranchSelector.tsx 100.00% <100.00%> (ø)
src/pages/RepoPage/ComponentsTab/Header/Header.jsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.21% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (-0.04%) ⬇️
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4fe4dc...8a01ca0. Read the comment docs.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (e4fe4dc) to head (8a01ca0).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2756   +/-   ##
=====================================
  Coverage   98.41   98.41           
=====================================
  Files        873     874    +1     
  Lines      12471   12496   +25     
  Branches    3241    3247    +6     
=====================================
+ Hits       12273   12297   +24     
- Misses       191     192    +1     
  Partials       7       7           
Files Coverage Δ
...onentsTab/Header/BranchSelector/BranchSelector.tsx 100.00% <100.00%> (ø)
src/pages/RepoPage/ComponentsTab/Header/Header.jsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.21% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (-0.04%) ⬇️
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4fe4dc...8a01ca0. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2756      +/-   ##
==========================================
- Coverage   98.41%   98.40%   -0.01%     
==========================================
  Files         873      874       +1     
  Lines       12471    12496      +25     
  Branches     3283     3247      -36     
==========================================
+ Hits        12273    12297      +24     
- Misses        191      192       +1     
  Partials        7        7              
Files Coverage Δ
...onentsTab/Header/BranchSelector/BranchSelector.tsx 100.00% <100.00%> (ø)
src/pages/RepoPage/ComponentsTab/Header/Header.jsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.21% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (-0.04%) ⬇️
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4fe4dc...8a01ca0. Read the comment docs.

Copy link

codecov-public-qa bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (e4fe4dc) to head (8a01ca0).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2756      +/-   ##
==========================================
- Coverage   98.41%   98.40%   -0.01%     
==========================================
  Files         873      874       +1     
  Lines       12471    12496      +25     
  Branches     3301     3248      -53     
==========================================
+ Hits        12273    12297      +24     
- Misses        191      192       +1     
  Partials        7        7              
Files Coverage Δ
...onentsTab/Header/BranchSelector/BranchSelector.tsx 100.00% <100.00%> (ø)
src/pages/RepoPage/ComponentsTab/Header/Header.jsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.21% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (-0.04%) ⬇️
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4fe4dc...8a01ca0. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Apr 8, 2024

Bundle Report

Changes will increase total bundle size by 1.35kB ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.45MB 1.35kB ⬆️

Copy link

codecov bot commented Apr 8, 2024

Bundle Report

Changes will increase total bundle size by 1.35kB ⬆️

Bundle name Size Change
gazebo-production-array-push 6.45MB 1.35kB ⬆️

@RulaKhaled RulaKhaled marked this pull request as ready for review April 8, 2024 18:45
@codecov-releaser
Copy link
Contributor

codecov-releaser commented Apr 8, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
e32a6e2 Mon, 08 Apr 2024 18:46:44 GMT Expired Expired
e32a6e2 Mon, 08 Apr 2024 19:02:24 GMT Expired Expired
8a01ca0 Wed, 10 Apr 2024 12:43:35 GMT Cloud Enterprise

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@RulaKhaled RulaKhaled merged commit 5edd3e7 into main Apr 10, 2024
56 of 59 checks passed
@RulaKhaled RulaKhaled deleted the branch-selector-components branch April 10, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add branch selector to the table
3 participants