Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reflect new components schema #2757

Merged
merged 5 commits into from
Apr 10, 2024
Merged

fix: Reflect new components schema #2757

merged 5 commits into from
Apr 10, 2024

Conversation

RulaKhaled
Copy link
Contributor

Description

We're adding termId for the search value for components, also rename to components yaml as it's a duplicate name under repository query.

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@RulaKhaled RulaKhaled marked this pull request as ready for review April 8, 2024 18:47
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (5edd3e7) to head (db6b916).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2757   +/-   ##
=====================================
  Coverage   98.41   98.41           
=====================================
  Files        874     874           
  Lines      12496   12496           
  Branches    3247    3248    +1     
=====================================
  Hits       12297   12297           
  Misses       192     192           
  Partials       7       7           
Files Coverage Δ
src/services/repo/useRepoComponentsSelect.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.21% <ø> (ø)
Services 99.56% <100.00%> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5edd3e7...db6b916. Read the comment docs.

Copy link

codecov-public-qa bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (5edd3e7) to head (db6b916).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2757   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files         874      874           
  Lines       12496    12496           
  Branches     3307     3248   -59     
=======================================
  Hits        12297    12297           
  Misses        192      192           
  Partials        7        7           
Files Coverage Δ
src/services/repo/useRepoComponentsSelect.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.21% <ø> (ø)
Services 99.56% <100.00%> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5edd3e7...db6b916. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2757   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files         874      874           
  Lines       12496    12496           
  Branches     3312     3307    -5     
=======================================
  Hits        12297    12297           
  Misses        192      192           
  Partials        7        7           
Files Coverage Δ
src/services/repo/useRepoComponentsSelect.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.21% <ø> (ø)
Services 99.56% <100.00%> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5edd3e7...db6b916. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (5edd3e7) to head (db6b916).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2757   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files         874      874           
  Lines       12496    12496           
  Branches     3248     3307   +59     
=======================================
  Hits        12297    12297           
  Misses        192      192           
  Partials        7        7           
Files Coverage Δ
src/services/repo/useRepoComponentsSelect.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.21% <ø> (ø)
Services 99.56% <100.00%> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5edd3e7...db6b916. Read the comment docs.

@codecov-staging
Copy link

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Apr 8, 2024

Bundle Report

Bundle size has no change ✅

@@ -34,7 +34,7 @@ const dataReturned = {
owner: {
repository: {
__typename: 'Repository',
components: [
componentsYaml: [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add the id in the mock as well right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! good catch

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Apr 8, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
9c71bc2 Mon, 08 Apr 2024 19:02:03 GMT Expired Expired
9c71bc2 Mon, 08 Apr 2024 19:02:45 GMT Expired Expired
fdbee90 Tue, 09 Apr 2024 10:39:24 GMT Expired Expired
fdbee90 Tue, 09 Apr 2024 10:39:29 GMT Expired Expired
db6b916 Wed, 10 Apr 2024 14:24:51 GMT Cloud Enterprise

@RulaKhaled RulaKhaled merged commit 58a7230 into main Apr 10, 2024
58 of 59 checks passed
@RulaKhaled RulaKhaled deleted the fix-compoonents-hooks branch April 10, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants