Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix a couple of quick stuff for components tab #2770

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Conversation

RulaKhaled
Copy link
Contributor

Description

This fixes:

  • calling empty array of components as filters
  • padding for last uploaded

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.43%. Comparing base (3c0d4c8) to head (f814cf3).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2770   +/-   ##
=====================================
  Coverage   98.43   98.43           
=====================================
  Files        874     874           
  Lines      12509   12511    +2     
  Branches    3311    3296   -15     
=====================================
+ Hits       12312   12314    +2     
  Misses       191     191           
  Partials       6       6           
Files Coverage Δ
...tsTab/subroute/ComponentsTable/ComponentsTable.tsx 95.16% <ø> (ø)
...te/ComponentsTable/hooks/useRepoComponentsTable.js 86.20% <100.00%> (+1.02%) ⬆️
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.24% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c0d4c8...f814cf3. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.42%. Comparing base (3c0d4c8) to head (f814cf3).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2770   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files         874      874           
  Lines       12509    12511    +2     
  Branches     3294     3313   +19     
=======================================
+ Hits        12312    12314    +2     
  Misses        191      191           
  Partials        6        6           
Files Coverage Δ
...tsTab/subroute/ComponentsTable/ComponentsTable.tsx 95.16% <ø> (ø)
...te/ComponentsTable/hooks/useRepoComponentsTable.js 86.20% <100.00%> (+1.02%) ⬆️
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.24% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c0d4c8...f814cf3. Read the comment docs.

@hootener
Copy link

hootener commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2770   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files         874      874           
  Lines       12509    12511    +2     
  Branches     3311     3318    +7     
=======================================
+ Hits        12312    12314    +2     
  Misses        191      191           
  Partials        6        6           
Files Coverage Δ
...tsTab/subroute/ComponentsTable/ComponentsTable.tsx 95.16% <ø> (ø)
...te/ComponentsTable/hooks/useRepoComponentsTable.js 86.20% <100.00%> (+1.02%) ⬆️
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.24% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c0d4c8...f814cf3. Read the comment docs.

Copy link

codecov-public-qa bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.42%. Comparing base (3c0d4c8) to head (f814cf3).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2770   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files         874      874           
  Lines       12509    12511    +2     
  Branches     3311     3256   -55     
=======================================
+ Hits        12312    12314    +2     
  Misses        191      191           
  Partials        6        6           
Files Coverage Δ
...tsTab/subroute/ComponentsTable/ComponentsTable.tsx 95.16% <ø> (ø)
...te/ComponentsTable/hooks/useRepoComponentsTable.js 86.20% <100.00%> (+1.02%) ⬆️
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.24% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c0d4c8...f814cf3. Read the comment docs.

@hootener
Copy link

Bundle Report

Changes will increase total bundle size by 87 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.46MB 87 bytes ⬆️

Copy link

codecov bot commented Apr 12, 2024

Bundle Report

Changes will increase total bundle size by 87 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 6.46MB 87 bytes ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Apr 12, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
d2017eb Fri, 12 Apr 2024 15:15:08 GMT Expired Expired
a63a1a9 Fri, 12 Apr 2024 15:30:16 GMT Expired Expired
f814cf3 Fri, 12 Apr 2024 18:40:08 GMT Cloud Enterprise

@RulaKhaled RulaKhaled merged commit 5354d5a into main Apr 12, 2024
59 checks passed
@RulaKhaled RulaKhaled deleted the components-tab branch April 12, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants