Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not redirect on select branch #2774

Merged
merged 5 commits into from
Apr 12, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

One more small fix, for an unseen case where it's redirecting to /Select branch 🤦

@codecov-qa
Copy link

codecov-qa bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.41%. Comparing base (5354d5a) to head (9f6af57).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2774      +/-   ##
==========================================
- Coverage   98.42%   98.41%   -0.01%     
==========================================
  Files         874      874              
  Lines       12511    12515       +4     
  Branches     3255     3259       +4     
==========================================
+ Hits        12314    12317       +3     
- Misses        191      192       +1     
  Partials        6        6              
Files Coverage Δ
...Tab/BundleContent/BundleSummary/BranchSelector.tsx 100.00% <100.00%> (ø)
...Tab/BundleContent/BundleSummary/BundleSelector.tsx 97.05% <0.00%> (-2.95%) ⬇️
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.22% <80.00%> (-0.02%) ⬇️
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5354d5a...9f6af57. Read the comment docs.

Copy link

codecov-public-qa bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.41%. Comparing base (5354d5a) to head (9f6af57).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2774      +/-   ##
==========================================
- Coverage   98.42%   98.41%   -0.01%     
==========================================
  Files         874      874              
  Lines       12511    12515       +4     
  Branches     3296     3258      -38     
==========================================
+ Hits        12314    12317       +3     
- Misses        191      192       +1     
  Partials        6        6              
Files Coverage Δ
...Tab/BundleContent/BundleSummary/BranchSelector.tsx 100.00% <100.00%> (ø)
...Tab/BundleContent/BundleSummary/BundleSelector.tsx 97.05% <0.00%> (-2.95%) ⬇️
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.22% <80.00%> (-0.02%) ⬇️
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5354d5a...9f6af57. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2774      +/-   ##
==========================================
- Coverage   98.42%   98.41%   -0.01%     
==========================================
  Files         874      874              
  Lines       12511    12515       +4     
  Branches     3313     3258      -55     
==========================================
+ Hits        12314    12317       +3     
- Misses        191      192       +1     
  Partials        6        6              
Files Coverage Δ
...Tab/BundleContent/BundleSummary/BranchSelector.tsx 100.00% <100.00%> (ø)
...Tab/BundleContent/BundleSummary/BundleSelector.tsx 97.05% <0.00%> (-2.95%) ⬇️
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.22% <80.00%> (-0.02%) ⬇️
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5354d5a...9f6af57. Read the comment docs.

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.42%. Comparing base (5354d5a) to head (9f6af57).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2774     +/-   ##
=======================================
- Coverage   98.43   98.42   -0.01     
=======================================
  Files        874     874             
  Lines      12511   12515      +4     
  Branches    3318    3321      +3     
=======================================
+ Hits       12314   12317      +3     
- Misses       191     192      +1     
  Partials       6       6             
Files Coverage Δ
...Tab/BundleContent/BundleSummary/BranchSelector.tsx 100.00% <100.00%> (ø)
...Tab/BundleContent/BundleSummary/BundleSelector.tsx 97.05% <0.00%> (-2.95%) ⬇️
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.22% <80.00%> (-0.02%) ⬇️
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5354d5a...9f6af57. Read the comment docs.

@hootener
Copy link

hootener commented Apr 12, 2024

Bundle Report

Changes will increase total bundle size by 37 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.46MB 37 bytes ⬆️

Copy link

codecov bot commented Apr 12, 2024

Bundle Report

Changes will increase total bundle size by 37 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 6.46MB 37 bytes ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Apr 12, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
7fa5f3b Fri, 12 Apr 2024 19:13:15 GMT Expired Expired
7fa5f3b Fri, 12 Apr 2024 19:16:23 GMT Expired Expired
9f6af57 Fri, 12 Apr 2024 19:36:06 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov merged commit 111dd10 into main Apr 12, 2024
46 of 59 checks passed
@nicholas-codecov nicholas-codecov deleted the do-not-redirect-on-select-branch branch April 12, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants