Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Add webpack loading bar when starting gazebo #2789

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

ajay-sentry
Copy link
Contributor

@ajay-sentry ajay-sentry commented Apr 18, 2024

Description

adds a new package to gazebo called "Webpack bar" which is essentially just a plugin for showing a loader when building webpack.

I chose the color orange for the loader because it looked kinda nice (defaults to green out the box), but posted the color list below if anyone has some others they wanna try!

color list
webpackbar plugin

closes codecov/engineering-team#1641

Screenshots

Screen.Recording.2024-04-18.at.10.14.23.AM.mov

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov-public-qa bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (d57a320) to head (71057ec).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2789   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files         873      873           
  Lines       12634    12634           
  Branches     3316     3358   +42     
=======================================
  Hits        12439    12439           
  Misses        191      191           
  Partials        4        4           
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.28% <ø> (ø)
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57a320...71057ec. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2789   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files         873      873           
  Lines       12634    12634           
  Branches     3377     3382    +5     
=======================================
  Hits        12439    12439           
  Misses        191      191           
  Partials        4        4           
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.28% <ø> (ø)
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57a320...71057ec. Read the comment docs.

@hootener
Copy link

Bundle Report

Bundle size has no change ✅

@codecov-qa
Copy link

codecov-qa bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (d57a320) to head (71057ec).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2789   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files         873      873           
  Lines       12634    12634           
  Branches     3317     3316    -1     
=======================================
  Hits        12439    12439           
  Misses        191      191           
  Partials        4        4           
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.28% <ø> (ø)
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57a320...71057ec. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Apr 18, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
eb20328 Thu, 18 Apr 2024 17:33:36 GMT Expired Expired
eb20328 Thu, 18 Apr 2024 17:35:07 GMT Expired Expired
eb20328 Thu, 18 Apr 2024 17:48:39 GMT Expired Expired
6157158 Mon, 22 Apr 2024 18:19:02 GMT Expired Expired
71057ec Mon, 22 Apr 2024 19:10:29 GMT Expired Expired
71057ec Mon, 22 Apr 2024 19:10:34 GMT Cloud Enterprise

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (d57a320) to head (71057ec).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2789   +/-   ##
=====================================
  Coverage   98.46   98.46           
=====================================
  Files        873     873           
  Lines      12634   12634           
  Branches    3317    3377   +60     
=====================================
  Hits       12439   12439           
  Misses       191     191           
  Partials       4       4           
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.28% <ø> (ø)
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57a320...71057ec. Read the comment docs.

Copy link

codecov bot commented Apr 22, 2024

Bundle Report

Bundle size has no change ✅

@ajay-sentry ajay-sentry merged commit ad0656b into main Apr 22, 2024
59 of 60 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/webpack-loader branch April 22, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Loading Bar to Gazebo on startup
4 participants