-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: Add webpack loading bar when starting gazebo #2789
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2789 +/- ##
=======================================
Coverage 98.45% 98.45%
=======================================
Files 873 873
Lines 12634 12634
Branches 3316 3358 +42
=======================================
Hits 12439 12439
Misses 191 191
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2789 +/- ##
=======================================
Coverage 98.45% 98.45%
=======================================
Files 873 873
Lines 12634 12634
Branches 3377 3382 +5
=======================================
Hits 12439 12439
Misses 191 191
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Bundle ReportBundle size has no change ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2789 +/- ##
=======================================
Coverage 98.45% 98.45%
=======================================
Files 873 873
Lines 12634 12634
Branches 3317 3316 -1
=======================================
Hits 12439 12439
Misses 191 191
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2789 +/- ##
=====================================
Coverage 98.46 98.46
=====================================
Files 873 873
Lines 12634 12634
Branches 3317 3377 +60
=====================================
Hits 12439 12439
Misses 191 191
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Bundle ReportBundle size has no change ✅ |
Description
adds a new package to gazebo called "Webpack bar" which is essentially just a plugin for showing a loader when building webpack.
I chose the color orange for the loader because it looked kinda nice (defaults to green out the box), but posted the color list below if anyone has some others they wanna try!
color list
webpackbar plugin
closes codecov/engineering-team#1641
Screenshots
Screen.Recording.2024-04-18.at.10.14.23.AM.mov
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.