Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ref] Refactor commit detail file explorer table #2802

Merged
merged 20 commits into from
Apr 29, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Apr 23, 2024

Full refactor of the commit detail file explorer table and related hooks.

Also updated the CommitPathContents query to use the new repository endpoint.

Majority of the logic outside the table remains the same, and most changes are TS conversions.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (d76d77c) to head (a705cd6).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2802   +/-   ##
=====================================
  Coverage   98.47   98.47           
=====================================
  Files        871     872    +1     
  Lines      12686   12719   +33     
  Branches    3388    3412   +24     
=====================================
+ Hits       12492   12524   +32     
- Misses       190     191    +1     
  Partials       4       4           
Files Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.tsx 100.00% <100.00%> (ø)
...tailFileExplorer/CommitDetailFileExplorerTable.tsx 100.00% <100.00%> (ø)
...lFileExplorer/hooks/useRepoCommitContentsTable.tsx 100.00% <100.00%> (ø)
src/services/pathContents/commit/dir/constants.ts 100.00% <100.00%> (ø)
.../pathContents/commit/dir/useRepoCommitContents.tsx 100.00% <100.00%> (ø)
...ontents/commit/file/usePrefetchCommitFileEntry.tsx 100.00% <ø> (ø)
...able/TableEntries/CommitEntries/CommitDirEntry.tsx 100.00% <100.00%> (ø)
...ble/TableEntries/CommitEntries/CommitFileEntry.tsx 100.00% <100.00%> (ø)
src/shared/treePaths/useCommitTreePath.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.27% <100.00%> (+<0.01%) ⬆️
Services 99.56% <100.00%> (+<0.01%) ⬆️
Shared 99.84% <100.00%> (+<0.01%) ⬆️
UI 94.40% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d76d77c...a705cd6. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2802   +/-   ##
=======================================
  Coverage        ?   98.45%           
=======================================
  Files           ?      873           
  Lines           ?    12670           
  Branches        ?     3342           
=======================================
  Hits            ?    12474           
  Misses          ?      192           
  Partials        ?        4           
Files Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.tsx 100.00% <100.00%> (ø)
...tailFileExplorer/CommitDetailFileExplorerTable.tsx 100.00% <100.00%> (ø)
...lFileExplorer/hooks/useRepoCommitContentsTable.tsx 100.00% <100.00%> (ø)
src/services/pathContents/commit/dir/constants.ts 100.00% <100.00%> (ø)
.../pathContents/commit/dir/useRepoCommitContents.tsx 100.00% <100.00%> (ø)
...ontents/commit/file/usePrefetchCommitFileEntry.tsx 100.00% <ø> (ø)
...able/TableEntries/CommitEntries/CommitDirEntry.tsx 100.00% <100.00%> (ø)
...ble/TableEntries/CommitEntries/CommitFileEntry.tsx 100.00% <100.00%> (ø)
src/shared/treePaths/useCommitTreePath.js 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (?)
Layouts 97.25% <ø> (?)
Pages 99.28% <100.00%> (?)
Services 99.56% <100.00%> (?)
Shared 99.84% <100.00%> (?)
UI 94.15% <ø> (?)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 782e9b4...bde1e11. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (d76d77c) to head (a705cd6).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2802      +/-   ##
==========================================
- Coverage   98.47%   98.46%   -0.01%     
==========================================
  Files         871      872       +1     
  Lines       12686    12719      +33     
  Branches     3388     3354      -34     
==========================================
+ Hits        12492    12524      +32     
- Misses        190      191       +1     
  Partials        4        4              
Files Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.tsx 100.00% <100.00%> (ø)
...tailFileExplorer/CommitDetailFileExplorerTable.tsx 100.00% <100.00%> (ø)
...lFileExplorer/hooks/useRepoCommitContentsTable.tsx 100.00% <100.00%> (ø)
src/services/pathContents/commit/dir/constants.ts 100.00% <100.00%> (ø)
.../pathContents/commit/dir/useRepoCommitContents.tsx 100.00% <100.00%> (ø)
...ontents/commit/file/usePrefetchCommitFileEntry.tsx 100.00% <ø> (ø)
...able/TableEntries/CommitEntries/CommitDirEntry.tsx 100.00% <100.00%> (ø)
...ble/TableEntries/CommitEntries/CommitFileEntry.tsx 100.00% <100.00%> (ø)
src/shared/treePaths/useCommitTreePath.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.27% <100.00%> (+<0.01%) ⬆️
Services 99.56% <100.00%> (+<0.01%) ⬆️
Shared 99.84% <100.00%> (+<0.01%) ⬆️
UI 94.40% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d76d77c...a705cd6. Read the comment docs.

Copy link

codecov-public-qa bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (d76d77c) to head (a705cd6).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2802      +/-   ##
==========================================
- Coverage   98.47%   98.46%   -0.01%     
==========================================
  Files         871      872       +1     
  Lines       12686    12719      +33     
  Branches     3371     3412      +41     
==========================================
+ Hits        12492    12524      +32     
- Misses        190      191       +1     
  Partials        4        4              
Files Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.tsx 100.00% <100.00%> (ø)
...tailFileExplorer/CommitDetailFileExplorerTable.tsx 100.00% <100.00%> (ø)
...lFileExplorer/hooks/useRepoCommitContentsTable.tsx 100.00% <100.00%> (ø)
src/services/pathContents/commit/dir/constants.ts 100.00% <100.00%> (ø)
.../pathContents/commit/dir/useRepoCommitContents.tsx 100.00% <100.00%> (ø)
...ontents/commit/file/usePrefetchCommitFileEntry.tsx 100.00% <ø> (ø)
...able/TableEntries/CommitEntries/CommitDirEntry.tsx 100.00% <100.00%> (ø)
...ble/TableEntries/CommitEntries/CommitFileEntry.tsx 100.00% <100.00%> (ø)
src/shared/treePaths/useCommitTreePath.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.27% <100.00%> (+<0.01%) ⬆️
Services 99.56% <100.00%> (+<0.01%) ⬆️
Shared 99.84% <100.00%> (+<0.01%) ⬆️
UI 94.40% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d76d77c...a705cd6. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Apr 23, 2024

Bundle Report

Changes will increase total bundle size by 82.06kB ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.56MB 82.06kB ⬆️

Copy link

codecov bot commented Apr 23, 2024

Bundle Report

Changes will increase total bundle size by 82.06kB ⬆️

Bundle name Size Change
gazebo-production-array-push 6.56MB 82.06kB ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Apr 23, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
f6687f6 Tue, 23 Apr 2024 16:41:35 GMT Expired Expired
ee18087 Tue, 23 Apr 2024 17:28:40 GMT Expired Expired
575e3ef Tue, 23 Apr 2024 17:46:49 GMT Expired Expired
9f12b6f Tue, 23 Apr 2024 18:05:53 GMT Expired Expired
727146d Tue, 23 Apr 2024 18:42:14 GMT Expired Expired
c7043e6 Tue, 23 Apr 2024 19:10:01 GMT Expired Expired
ee9e4ca Tue, 23 Apr 2024 19:33:45 GMT Expired Expired
17ad2e7 Thu, 25 Apr 2024 14:25:09 GMT Expired Expired
17ad2e7 Thu, 25 Apr 2024 14:26:11 GMT Expired Expired
c82e755 Thu, 25 Apr 2024 14:50:08 GMT Expired Expired
a705cd6 Mon, 29 Apr 2024 17:51:37 GMT Expired Expired
a705cd6 Mon, 29 Apr 2024 17:59:37 GMT Cloud Enterprise

@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review April 24, 2024 15:50
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think probably best that I reviewed this lol. Pretty much identical to the other two we did 😄

I tested locally as well, everything seems to be working as expected.

@rohitvinnakota-codecov rohitvinnakota-codecov merged commit ea4d427 into main Apr 29, 2024
49 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants