Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub app installation banner update and CTA location update #2804

Merged
merged 7 commits into from
Apr 26, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Apr 24, 2024

Description

This closes codecov/engineering-team#1400.

  • Moves Add GH org text to the top of the context switcher
  • Updates Configure github app banner copy

Screenshots

Screenshot 2024-04-24 at 12 54 01 PM

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Apr 24, 2024

Bundle Report

Changes will decrease total bundle size by 1.64kB ⬇️

Bundle name Size Change
gazebo-staging-array-push 6.46MB 1.64kB ⬇️

Copy link

codecov bot commented Apr 24, 2024

Bundle Report

Changes will decrease total bundle size by 1.64kB ⬇️

Bundle name Size Change
gazebo-production-array-push 6.46MB 1.64kB ⬇️

Copy link

codecov-public-qa bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.44%. Comparing base (9f18102) to head (988dc64).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2804      +/-   ##
==========================================
- Coverage   98.45%   98.44%   -0.01%     
==========================================
  Files         870      870              
  Lines       12649    12642       -7     
  Branches     3386     3384       -2     
==========================================
- Hits        12453    12446       -7     
  Misses        192      192              
  Partials        4        4              
Files Coverage Δ
...rBanners/GithubConfigBanner/GithubConfigBanner.jsx 100.00% <ø> (ø)
...rvices/navigation/useNavLinks/useStaticNavLinks.js 98.41% <100.00%> (+0.02%) ⬆️
src/ui/ContextSwitcher/ContextSwitcher.jsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.26% <ø> (ø)
Services 99.56% <100.00%> (+<0.01%) ⬆️
Shared 99.84% <ø> (ø)
UI 94.11% <100.00%> (-0.04%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f18102...988dc64. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.44%. Comparing base (9f18102) to head (988dc64).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2804      +/-   ##
==========================================
- Coverage   98.45%   98.44%   -0.01%     
==========================================
  Files         870      870              
  Lines       12649    12642       -7     
  Branches     3369     3325      -44     
==========================================
- Hits        12453    12446       -7     
  Misses        192      192              
  Partials        4        4              
Files Coverage Δ
...rBanners/GithubConfigBanner/GithubConfigBanner.jsx 100.00% <ø> (ø)
...rvices/navigation/useNavLinks/useStaticNavLinks.js 98.41% <100.00%> (+0.02%) ⬆️
src/ui/ContextSwitcher/ContextSwitcher.jsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.26% <ø> (ø)
Services 99.56% <100.00%> (+<0.01%) ⬆️
Shared 99.84% <ø> (ø)
UI 94.11% <100.00%> (-0.04%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f18102...988dc64. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2804      +/-   ##
==========================================
- Coverage   98.45%   98.44%   -0.01%     
==========================================
  Files         870      870              
  Lines       12649    12642       -7     
  Branches     3391     3325      -66     
==========================================
- Hits        12453    12446       -7     
  Misses        192      192              
  Partials        4        4              
Files Coverage Δ
...rBanners/GithubConfigBanner/GithubConfigBanner.jsx 100.00% <ø> (ø)
...rvices/navigation/useNavLinks/useStaticNavLinks.js 98.41% <100.00%> (+0.02%) ⬆️
src/ui/ContextSwitcher/ContextSwitcher.jsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.26% <ø> (ø)
Services 99.56% <100.00%> (+<0.01%) ⬆️
Shared 99.84% <ø> (ø)
UI 94.11% <100.00%> (-0.04%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f18102...988dc64. Read the comment docs.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (9f18102) to head (988dc64).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2804   +/-   ##
=====================================
  Coverage   98.45   98.45           
=====================================
  Files        870     870           
  Lines      12649   12642    -7     
  Branches    3391    3384    -7     
=====================================
- Hits       12453   12446    -7     
  Misses       192     192           
  Partials       4       4           
Files Coverage Δ
...rBanners/GithubConfigBanner/GithubConfigBanner.jsx 100.00% <ø> (ø)
...rvices/navigation/useNavLinks/useStaticNavLinks.js 98.41% <100.00%> (+0.02%) ⬆️
src/ui/ContextSwitcher/ContextSwitcher.jsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.26% <ø> (ø)
Services 99.56% <100.00%> (+<0.01%) ⬆️
Shared 99.84% <ø> (ø)
UI 94.11% <100.00%> (-0.04%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f18102...988dc64. Read the comment docs.

if (ModalControl && ModalComponent) {
return (
<>
<ModalControl onClick={() => setShowComponent(true)} />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this is but it looks like it is unused

@rohitvinnakota-codecov rohitvinnakota-codecov changed the title [draft] GitHub app installation banner update and CTA location update GitHub app installation banner update and CTA location update Apr 24, 2024
@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review April 25, 2024 13:16
Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
988dc64 Fri, 26 Apr 2024 15:02:46 GMT Cloud Enterprise

@rohitvinnakota-codecov rohitvinnakota-codecov merged commit 91bd648 into main Apr 26, 2024
59 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/update-context-switcher branch April 26, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISSUE: GitHub app installation 1) banner update, and 2) CTA location update
3 participants