Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few UI tweaks for coverage over time for components #2813

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Conversation

JerrySentry
Copy link
Contributor

@JerrySentry JerrySentry commented Apr 26, 2024

fixes: codecov/engineering-team#1666

  • Change the icon in the "Get started with Components" button to white.
  • Have a bottom border for components table when no data state (needs configuration, activate, backfilling)
  • Remove the bottom border line of the header section

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link

codecov-public-qa bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (d1634a5) to head (eac13a4).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2813      +/-   ##
==========================================
+ Coverage   98.44%   98.46%   +0.01%     
==========================================
  Files         870      870              
  Lines       12642    12643       +1     
  Branches     3367     3385      +18     
==========================================
+ Hits        12446    12449       +3     
+ Misses        192      190       -2     
  Partials        4        4              
Files Coverage Δ
src/pages/RepoPage/ComponentsTab/Header/Header.tsx 100.00% <ø> (ø)
...tsTab/subroute/ComponentsTable/ComponentsTable.tsx 95.77% <100.00%> (+0.06%) ⬆️
...omponentsNotConfigured/ComponentsNotConfigured.tsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.28% <ø> (+0.16%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1634a5...eac13a4. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (d1634a5) to head (eac13a4).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2813      +/-   ##
==========================================
+ Coverage   98.44%   98.46%   +0.01%     
==========================================
  Files         870      870              
  Lines       12642    12643       +1     
  Branches     3367     3385      +18     
==========================================
+ Hits        12446    12449       +3     
+ Misses        192      190       -2     
  Partials        4        4              
Files Coverage Δ
src/pages/RepoPage/ComponentsTab/Header/Header.tsx 100.00% <ø> (ø)
...tsTab/subroute/ComponentsTable/ComponentsTable.tsx 95.77% <100.00%> (+0.06%) ⬆️
...omponentsNotConfigured/ComponentsNotConfigured.tsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.28% <ø> (+0.16%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1634a5...eac13a4. Read the comment docs.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (d1634a5) to head (eac13a4).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2813     +/-   ##
=======================================
+ Coverage   98.45   98.47   +0.02     
=======================================
  Files        870     870             
  Lines      12642   12643      +1     
  Branches    3326    3385     +59     
=======================================
+ Hits       12446   12449      +3     
+ Misses       192     190      -2     
  Partials       4       4             
Files Coverage Δ
src/pages/RepoPage/ComponentsTab/Header/Header.tsx 100.00% <ø> (ø)
...tsTab/subroute/ComponentsTable/ComponentsTable.tsx 95.77% <100.00%> (+0.06%) ⬆️
...omponentsNotConfigured/ComponentsNotConfigured.tsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.28% <ø> (+0.16%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1634a5...eac13a4. Read the comment docs.

@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 124 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.47MB 124 bytes ⬆️

Copy link

codecov bot commented Apr 26, 2024

Bundle Report

Changes will increase total bundle size by 124 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 6.47MB 124 bytes ⬆️

@JerrySentry JerrySentry merged commit b0bea5f into main Apr 26, 2024
48 checks passed
@JerrySentry JerrySentry deleted the apr_26_cot branch April 26, 2024 20:45
@codecov-releaser
Copy link
Contributor

codecov-releaser commented Apr 26, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
eac13a4 Fri, 26 Apr 2024 20:53:13 GMT Expired Expired
eac13a4 Fri, 26 Apr 2024 20:53:14 GMT Cloud Enterprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A few UI tweaks
3 participants