-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few UI tweaks for coverage over time for components #2813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2813 +/- ##
==========================================
+ Coverage 98.44% 98.46% +0.01%
==========================================
Files 870 870
Lines 12642 12643 +1
Branches 3367 3385 +18
==========================================
+ Hits 12446 12449 +3
+ Misses 192 190 -2
Partials 4 4
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2813 +/- ##
==========================================
+ Coverage 98.44% 98.46% +0.01%
==========================================
Files 870 870
Lines 12642 12643 +1
Branches 3367 3385 +18
==========================================
+ Hits 12446 12449 +3
+ Misses 192 190 -2
Partials 4 4
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2813 +/- ##
=======================================
+ Coverage 98.45 98.47 +0.02
=======================================
Files 870 870
Lines 12642 12643 +1
Branches 3326 3385 +59
=======================================
+ Hits 12446 12449 +3
+ Misses 192 190 -2
Partials 4 4
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 124 bytes ⬆️
|
Bundle ReportChanges will increase total bundle size by 124 bytes ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
fixes: codecov/engineering-team#1666
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.