fix: Scroll to line padding #2814

nicholas-codecov · 2024-04-29T14:11:12Z

Description

This PR cleans up some of the instances of useScrollToLine to fix the padding issues with headers, when both BA and Coverage are enabled, and to use a shared const throughout the app so we only have to adjust the values in one place.

Notable Changes

Convert/Update DiffLine to TS and to accept stickyPadding prop
Update other instances of stickyPadding to use const obj
Update tests
Update stories

codecov-public-qa · 2024-04-29T14:16:40Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (782e9b4) to head (66caba8).

✅ All tests successful. No failed tests found ☺️

@@           Coverage Diff           @@
##             main    #2814   +/-   ##
=======================================
  Coverage   98.46%   98.47%           
=======================================
  Files         871      871           
  Lines       12676    12686   +10     
  Branches     3332     3388   +56     
=======================================
+ Hits        12482    12492   +10     
  Misses        190      190           
  Partials        4        4

Files	Coverage Δ
.../CommitDetailFileViewer/CommitDetailFileViewer.jsx	`100.00% <ø> (ø)`
...hangedTab/shared/CommitFileDiff/CommitFileDiff.jsx	`100.00% <100.00%> (ø)`
...rectChangesTable/CommitFileDiff/CommitFileDiff.jsx	`100.00% <100.00%> (ø)`
...Page/PullCoverage/routes/FileViewer/FileViewer.jsx	`100.00% <ø> (ø)`
...outes/FilesChangedTab/shared/FileDiff/FileDiff.jsx	`100.00% <100.00%> (ø)`
...ge/routes/IndirectChangesTab/FileDiff/FileDiff.jsx	`100.00% <100.00%> (ø)`
...age/CoverageTab/subroute/Fileviewer/Fileviewer.jsx	`100.00% <ø> (ø)`
src/shared/utils/fileviewer.tsx	`100.00% <100.00%> (ø)`
src/ui/CodeRenderer/DiffLine/DiffLine.tsx	`100.00% <100.00%> (ø)`
src/ui/CodeRenderer/hooks/useScrollToLine.js	`94.91% <100.00%> (ø)`

Components	Coverage Δ
Assets	`55.55% <ø> (ø)`
Layouts	`97.25% <ø> (ø)`
Pages	`99.26% <100.00%> (+<0.01%)`	⬆️
Services	`99.56% <ø> (ø)`
Shared	`99.84% <100.00%> (+<0.01%)`	⬆️
UI	`94.40% <100.00%> (+<0.01%)`	⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 782e9b4...66caba8. Read the comment docs.

codecov-qa · 2024-04-29T14:16:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (782e9b4) to head (66caba8).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2814   +/-   ##
=======================================
  Coverage   98.46%   98.47%           
=======================================
  Files         871      871           
  Lines       12676    12686   +10     
  Branches     3395     3388    -7     
=======================================
+ Hits        12482    12492   +10     
  Misses        190      190           
  Partials        4        4

Files	Coverage Δ
.../CommitDetailFileViewer/CommitDetailFileViewer.jsx	`100.00% <ø> (ø)`
...hangedTab/shared/CommitFileDiff/CommitFileDiff.jsx	`100.00% <100.00%> (ø)`
...rectChangesTable/CommitFileDiff/CommitFileDiff.jsx	`100.00% <100.00%> (ø)`
...Page/PullCoverage/routes/FileViewer/FileViewer.jsx	`100.00% <ø> (ø)`
...outes/FilesChangedTab/shared/FileDiff/FileDiff.jsx	`100.00% <100.00%> (ø)`
...ge/routes/IndirectChangesTab/FileDiff/FileDiff.jsx	`100.00% <100.00%> (ø)`
...age/CoverageTab/subroute/Fileviewer/Fileviewer.jsx	`100.00% <ø> (ø)`
src/shared/utils/fileviewer.tsx	`100.00% <100.00%> (ø)`
src/ui/CodeRenderer/DiffLine/DiffLine.tsx	`100.00% <100.00%> (ø)`
src/ui/CodeRenderer/hooks/useScrollToLine.js	`94.91% <100.00%> (ø)`

Components	Coverage Δ
Assets	`55.55% <ø> (ø)`
Layouts	`97.25% <ø> (ø)`
Pages	`99.26% <100.00%> (+<0.01%)`	⬆️
Services	`99.56% <ø> (ø)`
Shared	`99.84% <100.00%> (+<0.01%)`	⬆️
UI	`94.40% <100.00%> (+<0.01%)`	⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 782e9b4...66caba8. Read the comment docs.

codecov · 2024-04-29T14:17:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (782e9b4) to head (66caba8).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #2814   +/-   ##
=====================================
  Coverage   98.47   98.47           
=====================================
  Files        871     871           
  Lines      12676   12686   +10     
  Branches    3332    3388   +56     
=====================================
+ Hits       12482   12492   +10     
  Misses       190     190           
  Partials       4       4

Files	Coverage Δ
.../CommitDetailFileViewer/CommitDetailFileViewer.jsx	`100.00% <ø> (ø)`
...hangedTab/shared/CommitFileDiff/CommitFileDiff.jsx	`100.00% <100.00%> (ø)`
...rectChangesTable/CommitFileDiff/CommitFileDiff.jsx	`100.00% <100.00%> (ø)`
...Page/PullCoverage/routes/FileViewer/FileViewer.jsx	`100.00% <ø> (ø)`
...outes/FilesChangedTab/shared/FileDiff/FileDiff.jsx	`100.00% <100.00%> (ø)`
...ge/routes/IndirectChangesTab/FileDiff/FileDiff.jsx	`100.00% <100.00%> (ø)`
...age/CoverageTab/subroute/Fileviewer/Fileviewer.jsx	`100.00% <ø> (ø)`
src/shared/utils/fileviewer.tsx	`100.00% <100.00%> (ø)`
src/ui/CodeRenderer/DiffLine/DiffLine.tsx	`100.00% <100.00%> (ø)`
src/ui/CodeRenderer/hooks/useScrollToLine.js	`94.91% <100.00%> (ø)`

Components	Coverage Δ
Assets	`55.55% <ø> (ø)`
Layouts	`97.25% <ø> (ø)`
Pages	`99.26% <100.00%> (+<0.01%)`	⬆️
Services	`99.56% <ø> (ø)`
Shared	`99.84% <100.00%> (+<0.01%)`	⬆️
UI	`94.40% <100.00%> (+<0.01%)`	⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 782e9b4...66caba8. Read the comment docs.

codecov-staging · 2024-04-29T14:18:30Z

Bundle Report

Changes will increase total bundle size by 777 bytes ⬆️

Bundle name	Size	Change
gazebo-staging-array-push	6.48MB	777 bytes ⬆️

codecov · 2024-04-29T14:19:07Z

Bundle Report

Changes will increase total bundle size by 777 bytes ⬆️

Bundle name	Size	Change
gazebo-production-array-push	6.48MB	777 bytes ⬆️

codecov-releaser · 2024-04-29T14:22:07Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit	Created	Cloud	Enterprise
`0cd206e`	Mon, 29 Apr 2024 14:22:07 GMT	Expired	Expired
`0cd206e`	Mon, 29 Apr 2024 14:22:42 GMT	Expired	Expired
`e9d1ced`	Mon, 29 Apr 2024 16:26:19 GMT	Expired	Expired
`1d8f111`	Mon, 29 Apr 2024 16:43:59 GMT	Expired	Expired
`1d8f111`	Mon, 29 Apr 2024 16:48:59 GMT	Expired	Expired
`66caba8`	Mon, 29 Apr 2024 17:20:20 GMT	Cloud	Enterprise

ajay-sentry · 2024-04-29T15:12:18Z

src/shared/utils/fileviewer.tsx

@@ -88,12 +92,21 @@ export const CODE_RENDERER_INFO = {
 } as const

 // Enum from https://github.com/codecov/shared/blob/master/shared/utils/merge.py#L275-L279


nit: think this comment is out of date if we can update

ajay-sentry · 2024-04-29T15:14:01Z

src/ui/CodeRenderer/DiffLine/DiffLine.tsx

+type LineContent = { types: Array<string>; content: string }
+
+export interface DiffLineProps {
+  lineContent?: Array<LineContent>


curious on this changing from a required prop when we were using PropTypes to optional

ajay-sentry · 2024-04-29T15:14:48Z

src/ui/CodeRenderer/DiffLine/DiffLine.tsx

-function DiffLine({
+type LineContent = { types: Array<string>; content: string }
+
+export interface DiffLineProps {


nit: thoughts on organizing props in required -> optional order?

Updating to be alphabetical, follows the same pattern as the auto-complete

ajay-sentry · 2024-04-29T15:16:40Z

src/ui/FileList/FileList.stories.tsx

-                      headCoverage={coverage[Math.floor(Math.random() * 3) % 3]}
-                      baseCoverage={coverage[Math.floor(Math.random() * 3) % 3]}
+                      headCoverage={
+                        coverage[Math.floor(Math.random() * 3) % 3] ?? null


won't coverage always be a truthy value here?

No, it can be undefined

ajay-sentry

Nothing blocking, just a couple comments

nicholas-codecov added 6 commits April 29, 2024 11:01

return object for proper types

bfa24e2

update DiffLine to TS and accept stickyPadding prop

971801f

add in types and sticky padding const

557c2b0

update Diff calls with sticky padding values

d7d7294

update FileList story

7e15173

update index file to TS

0cd206e

ajay-sentry reviewed Apr 29, 2024

View reviewed changes

ajay-sentry approved these changes Apr 29, 2024

View reviewed changes

nicholas-codecov added 5 commits April 29, 2024 13:10

reorder types, and make line content required

97a8915

Merge branch 'main' into fix-scroll-to-line-with-dropdowns

67363a1

Merge branch 'main' into fix-scroll-to-line-with-dropdowns

e9d1ced

Merge branch 'main' into fix-scroll-to-line-with-dropdowns

1d8f111

Merge branch 'main' into fix-scroll-to-line-with-dropdowns

66caba8

nicholas-codecov merged commit d76d77c into main Apr 29, 2024
51 checks passed

nicholas-codecov deleted the fix-scroll-to-line-with-dropdowns branch April 29, 2024 17:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Scroll to line padding #2814

fix: Scroll to line padding #2814

nicholas-codecov commented Apr 29, 2024

codecov-public-qa bot commented Apr 29, 2024 •

edited

codecov-qa bot commented Apr 29, 2024 •

edited

codecov bot commented Apr 29, 2024 •

edited

codecov-staging bot commented Apr 29, 2024 •

edited

codecov bot commented Apr 29, 2024 •

edited

codecov-releaser commented Apr 29, 2024 •

edited

ajay-sentry Apr 29, 2024

ajay-sentry Apr 29, 2024

nicholas-codecov Apr 29, 2024

ajay-sentry Apr 29, 2024

nicholas-codecov Apr 29, 2024

ajay-sentry Apr 29, 2024

nicholas-codecov Apr 29, 2024

ajay-sentry left a comment

		@@ -88,12 +92,21 @@ export const CODE_RENDERER_INFO = {
		} as const

		// Enum from https://github.com/codecov/shared/blob/master/shared/utils/merge.py#L275-L279

fix: Scroll to line padding #2814

fix: Scroll to line padding #2814

Conversation

nicholas-codecov commented Apr 29, 2024

Description

Notable Changes

codecov-public-qa bot commented Apr 29, 2024 • edited

Codecov Report

codecov-qa bot commented Apr 29, 2024 • edited

Codecov Report

codecov bot commented Apr 29, 2024 • edited

Codecov Report

codecov-staging bot commented Apr 29, 2024 • edited

Bundle Report

codecov bot commented Apr 29, 2024 • edited

Bundle Report

codecov-releaser commented Apr 29, 2024 • edited

✅ Deploy preview for gazebo ready!

ajay-sentry Apr 29, 2024

Choose a reason for hiding this comment

ajay-sentry Apr 29, 2024

Choose a reason for hiding this comment

nicholas-codecov Apr 29, 2024

Choose a reason for hiding this comment

ajay-sentry Apr 29, 2024

Choose a reason for hiding this comment

nicholas-codecov Apr 29, 2024

Choose a reason for hiding this comment

ajay-sentry Apr 29, 2024

Choose a reason for hiding this comment

nicholas-codecov Apr 29, 2024

Choose a reason for hiding this comment

ajay-sentry left a comment

Choose a reason for hiding this comment

codecov-public-qa bot commented Apr 29, 2024 •

edited

codecov-qa bot commented Apr 29, 2024 •

edited

codecov bot commented Apr 29, 2024 •

edited

codecov-staging bot commented Apr 29, 2024 •

edited

codecov bot commented Apr 29, 2024 •

edited

codecov-releaser commented Apr 29, 2024 •

edited