Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unlink PR author on pulls table #2846

Merged
merged 1 commit into from
May 7, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

Unlinks the PR author name on the pulls table. Currently the link just goes to the home page. Causes no visual changes.

Closes codecov/engineering-team#1568

@codecov-staging
Copy link

Bundle Report

Changes will decrease total bundle size by 48 bytes ⬇️

Bundle name Size Change
gazebo-staging-array-push 6.56MB 48 bytes ⬇️

Copy link

codecov bot commented May 6, 2024

Bundle Report

Changes will decrease total bundle size by 48 bytes ⬇️

Bundle name Size Change
gazebo-production-array-push 6.56MB 48 bytes ⬇️

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
8d0a67a Mon, 06 May 2024 20:23:24 GMT Cloud Enterprise

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review May 7, 2024 13:43
@codecov-qa
Copy link

codecov-qa bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (d701376) to head (8d0a67a).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2846   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         871      871           
  Lines       12760    12760           
  Branches     3365     3365           
=======================================
  Hits        12566    12566           
  Misses        190      190           
  Partials        4        4           
Files Coverage Δ
src/pages/RepoPage/PullsTab/shared/Title/Title.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.27% <ø> (ø)
Services 99.53% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d701376...8d0a67a. Read the comment docs.

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (d701376) to head (8d0a67a).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2846   +/-   ##
=====================================
  Coverage   98.48   98.48           
=====================================
  Files        871     871           
  Lines      12760   12760           
  Branches    3365    3364    -1     
=====================================
  Hits       12566   12566           
  Misses       190     190           
  Partials       4       4           
Files Coverage Δ
src/pages/RepoPage/PullsTab/shared/Title/Title.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.27% <ø> (ø)
Services 99.53% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d701376...8d0a67a. Read the comment docs.

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit 9002190 May 7, 2024
44 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/unlinkify-pr-author branch May 7, 2024 14:42
RulaKhaled pushed a commit that referenced this pull request May 13, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 13, 2024
* feat: Add free plan seats alert

* feat: Create alerts for paid plan

* fix: Remove repositoryDeprecated from path contents hooks (#2845)

* update usePrefetchBranchDirEntry

* update useRepoBranchContents

* update index file

* update query off of repositoryDeprecated

* update tests

* small change to have commit signed

* update constants to ts

* small tweaks to the query keys

* Update useBranchCoverageMeasurements to use repository instead of repositoryDeprecated (#2843)

* feat: Paid/Free plan seats limit banner (#2830)

* feat: Add activation banner for trial eligible owners

* pull out interface + spec stuff

* Update to reflect paid plan activation banner

* Refactor CircleCI repo onboarding into one file (#2806)

* Refactor Other CI repo onboarding into one file (#2807)

* Update repo onboarding title position and page alignment (#2818)

* sec: 390 - Add validation for potential XSS vuln (#2797)

* add tests, and validation for provider

* add back supportServiceless param

* ref: 1548 Part 1: Convert all Header files to TS (#2821)

* ref all header files to TS

* remove prop types and rebase

* fix: Remove repository from GUT settings page header (#2823)

Small tweak removing `repository` from the GUT settings page.

* Install radix-ui react radio group (#2825)

* Update repo onboarding steps with new Card component (#2819)

GH codecov/engineering-team#1665

* feat: Add hasSeatsLeft to plan query

* Update to reflect SeatsLimitReachedBanner

* feat: paid plan activation banner

* update with from FreePlanSeatsLimitBanner

* value duplicate

* feat: paid plan seats limit banner

* just one more small tweak

* update name to FreePlanSeatsLimitBanner

* remove queryclient call

* update tests

* fix padding

* Update to have a const for plan value

---------

Co-authored-by: Spencer Murray <159931558+spalmurray-codecov@users.noreply.github.com>
Co-authored-by: ajay-sentry <159853603+ajay-sentry@users.noreply.github.com>
Co-authored-by: nicholas-codecov <nicholas.deschenes@sentry.io>

* feat: Paid plans activation required banner (#2832)

* feat: Add activation banner for trial eligible owners

* pull out interface + spec stuff

* Update to reflect paid plan activation banner

* Refactor CircleCI repo onboarding into one file (#2806)

* Refactor Other CI repo onboarding into one file (#2807)

* Update repo onboarding title position and page alignment (#2818)

* sec: 390 - Add validation for potential XSS vuln (#2797)

* add tests, and validation for provider

* add back supportServiceless param

* ref: 1548 Part 1: Convert all Header files to TS (#2821)

* ref all header files to TS

* remove prop types and rebase

* fix: Remove repository from GUT settings page header (#2823)

Small tweak removing `repository` from the GUT settings page.

* Install radix-ui react radio group (#2825)

* Update repo onboarding steps with new Card component (#2819)

GH codecov/engineering-team#1665

* feat: Add hasSeatsLeft to plan query

* Update to reflect SeatsLimitReachedBanner

* feat: paid plan activation banner

* update with from FreePlanSeatsLimitBanner

* value duplicate

* feat: Activation required banner

* clean up previous commit

* match design

* fix style

* Resolve conflicts

---------

Co-authored-by: Spencer Murray <159931558+spalmurray-codecov@users.noreply.github.com>
Co-authored-by: ajay-sentry <159853603+ajay-sentry@users.noreply.github.com>
Co-authored-by: nicholas-codecov <nicholas.deschenes@sentry.io>

* Unlink PR author on pulls table (#2846)

* ref: Use Repository instead of RepositoryDeprecated in useCommitYaml (#2844)

* Convert UseCommitYaml to Repository from RepositoryDeprecated

* Update query key

* ref: Convert useCommitErrors to TS and remove repositoryDeprecated (#2847)

* init conversion and remove deprecated, testing

* fix tests for useCommitErrors

* add additional spec

* add dev stuff

* update test coverage

* feat: Route to plan if user session + to param == plan (#2837)

* add plan route logic if to param set as plan

* help w/ test

* remove some unneeded mocks

* remove to

* fix spec mocks

* fix: Show banner for private repos only (#2853)

* fix: Footer Codecov icon displaying incorrect color  (#2858)

* fill color update

* update hex val

* Update useRepoSettings to move to new repository type (#2851)

* Update usereposettings

* Update tests

* update test

* Update more tests

* Update more tests

* more test updates

* Update type

* Update

* Update query

* Refactor

* dep: Update to Sentry RC-1 (#2849)

* pin @sentry/react to the latest release candidated

* update lockfile

* fix: Flaky tests around file explorer tables (#2856)

* Fix coverage tab file list table

* Fix coverage tab code tree table tests

* Fix pull indirect changed files table

* Fix commit file explorer table

* Fix missed instance of getByText

* ref: Convert SessionsTable to tanstack table (#2842)

* Convert Access.jsx -> tsx

* Fix type issue with TokensTable

* Remove unnecessary import

* Convert SessionsTable to ts

* Add tests

* Fix tests

* Fix all testLocation: any

* Use msw for mutation mock

* Improve flatmap callback for readability

* Better type hint for flat map return

* Fix flake

* Fix imports

* Fix indirect coverage loss

* style: Use Card component in bundle onboarding (#2861)

* Fix copy pasta border/padding

* Page width change

* Vite onboarding overhaul

* Webpack onboarding overhaul

* Rollup onboarding overhaul

* Fix tests

* chore: Update codecov.yml so that PR comment isn't sent until 9 uploads (#2865)

* Update to 8 uploads before comment to avoid many comments

* Oopsie it's actually the ceiling

* ref: Convert useComparisonForCommitAndParent to TS and remove repositoryDeprecated (#2857)

* fix tests, confirm it works

* export type and use instead

* feat: Add radio button navigation to repo onboarding (#2839)

* Use RadioTileGroup for navigation on the repo onboarding page

* Pull getInitalProvider out of component

* Fix tests

* Remove unnecessary div

* fix: A potential fix for the flaky test (#2854)

* ref: Clean up pull file explorer tests (#2852)

* Clean up pull file explorer tests

* Fix tests

* Revert "Fix tests"

This reverts commit f5aeccd.

* components over time display name instead of id (#2868)

* style: Fix radio tile group indicator shifting on certain screen sizes (#2869)

* Fix responsiveness issue on RadioTileGroup

* Add longer description to story

* Left align the label text

* ref: Remove repositoryDeprecated from usePrefetchSingleFileComp (#2870)

* update usePrefetchSingleFileComp to TS

* update NameColumn tests

* move fragment schema next to gql fragment string

* Capitlize view in free alert

* oops conflict stuff

---------

Co-authored-by: nicholas-codecov <nicholas.deschenes@sentry.io>
Co-authored-by: Spencer Murray <159931558+spalmurray-codecov@users.noreply.github.com>
Co-authored-by: ajay-sentry <159853603+ajay-sentry@users.noreply.github.com>
Co-authored-by: Rohit Vinnakota <148245014+rohitvinnakota-codecov@users.noreply.github.com>
Co-authored-by: JerrySentry <142266253+JerrySentry@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: PR author link takes you to app home page
3 participants