Update action to do local processing #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
2 similar comments
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
2 similar comments
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
we are making this change so users don't have to phone home to Codecov. this command will parse the test results files locally and make the Codecov test results comment from the Github Action. Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
joseph-sentry
force-pushed
the
joseph/matrix-within-action
branch
from
ac14ed3
to
11e82fe
Compare
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
1 similar comment
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
4 similar comments
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
joseph-sentry
changed the title
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
| flags: py3.11 # optional | ||
| name: codecov-umbrella # optional | ||
| token: ${{ secrets.CODECOV_TOKEN }} # required | ||
| token: ${{ secrets.CODECOV_GITHUB_TOKEN }} # optional (default = false) |
There was a problem hiding this comment.
by default I think we call this CODECOV_TOKEN everywhere
There was a problem hiding this comment.
in this case it's not actually a "codecov token" anymore, it needs to be a github personal access token, "codecov token" usually means then token you can get from the codecov website
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: codecov/engineering-team#1713