hotfix: avoid double inserts when sync_repos #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync_repos when the repos affected are knows is acting up. Unsure if it's the filtering logic OR a race condition OR if something else is inserting the repo. We will be moving to `upsert_repo` to avoid this issue.
matt-codecov
approved these changes
Apr 24, 2024
adrian-codecov
approved these changes
Apr 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #412 +/- ##
==========================================
- Coverage 97.48% 97.48% -0.01%
==========================================
Files 395 395
Lines 33378 33376 -2
==========================================
- Hits 32538 32536 -2
Misses 840 840
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
==========================================
- Coverage 97.48% 97.48% -0.01%
==========================================
Files 395 395
Lines 33378 33376 -2
==========================================
- Hits 32538 32536 -2
Misses 840 840
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #412 +/- ##
==========================================
- Coverage 97.48% 97.48% -0.01%
==========================================
Files 395 395
Lines 33378 33376 -2
==========================================
- Hits 32538 32536 -2
Misses 840 840
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
==========================================
- Coverage 97.50% 97.50% -0.01%
==========================================
Files 426 426
Lines 34069 34067 -2
==========================================
- Hits 33220 33218 -2
Misses 849 849
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync_repos when the repos affected are knows is acting up.
Unsure if it's the filtering logic OR a race condition OR if something else
is inserting the repo.
We will be moving to
upsert_repoto avoid this issue.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.