Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy raw reports for parallel experiment #414

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

daniel-codecov
Copy link
Contributor

Explicitly make a copy of the raw reports so that the parallel pipeline can parse those raw reports instead of the ones that get rewritten by the serial flow (which are rewritten as the "legacy" format)

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

codecov-notifications bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 12 lines in your changes are missing coverage. Please review.

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
- Coverage   97.48%   97.45%   -0.03%     
==========================================
  Files         395      395              
  Lines       33376    33385       +9     
==========================================
  Hits        32536    32536              
- Misses        840      849       +9     
Flag Coverage Δ
integration 97.45% <42.85%> (-0.03%) ⬇️
latest-uploader-overall 97.45% <42.85%> (-0.03%) ⬇️
unit 97.45% <42.85%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.77% <40.00%> (-0.07%) ⬇️
OutsideTasks 97.55% <33.33%> (-0.04%) ⬇️
Files Coverage Δ
services/report/parser/__init__.py 100.00% <100.00%> (+11.11%) ⬆️
tasks/tests/unit/test_upload_processing_task.py 100.00% <100.00%> (ø)
helpers/parallel_upload_processing.py 15.09% <0.00%> (-0.30%) ⬇️
tasks/upload_processor.py 92.34% <60.00%> (-0.52%) ⬇️
services/report/__init__.py 92.27% <33.33%> (-1.69%) ⬇️

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 97.48%. Comparing base (bcec347) to head (69c72ae).

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
- Coverage   97.50%   97.48%   -0.03%     
==========================================
  Files         426      426              
  Lines       34067    34076       +9     
==========================================
  Hits        33218    33218              
- Misses        849      858       +9     
Flag Coverage Δ
integration 97.45% <42.85%> (-0.03%) ⬇️
latest-uploader-overall 97.45% <42.85%> (-0.03%) ⬇️
unit 97.45% <42.85%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.80% <40.00%> (-0.07%) ⬇️
OutsideTasks 97.55% <33.33%> (-0.04%) ⬇️
Files Coverage Δ
services/report/parser/__init__.py 100.00% <100.00%> (+11.11%) ⬆️
tasks/tests/unit/test_upload_processing_task.py 100.00% <100.00%> (ø)
helpers/parallel_upload_processing.py 15.09% <0.00%> (-0.30%) ⬇️
tasks/upload_processor.py 92.89% <60.00%> (-0.51%) ⬇️
services/report/__init__.py Critical 92.29% <33.33%> (-1.68%) ⬇️
Related Entrypoints
run/app.tasks.upload.UploadProcessor

@codecov-qa
Copy link

codecov-qa bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 97.45%. Comparing base (bcec347) to head (69c72ae).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
- Coverage   97.48%   97.45%   -0.03%     
==========================================
  Files         395      395              
  Lines       33376    33385       +9     
==========================================
  Hits        32536    32536              
- Misses        840      849       +9     
Flag Coverage Δ
integration 97.45% <42.85%> (-0.03%) ⬇️
latest-uploader-overall 97.45% <42.85%> (-0.03%) ⬇️
unit 97.45% <42.85%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.77% <40.00%> (-0.07%) ⬇️
OutsideTasks 97.55% <33.33%> (-0.04%) ⬇️
Files Coverage Δ
services/report/parser/__init__.py 100.00% <100.00%> (+11.11%) ⬆️
tasks/tests/unit/test_upload_processing_task.py 100.00% <100.00%> (ø)
helpers/parallel_upload_processing.py 15.09% <0.00%> (-0.30%) ⬇️
tasks/upload_processor.py 92.34% <60.00%> (-0.52%) ⬇️
services/report/__init__.py 92.27% <33.33%> (-1.69%) ⬇️

Copy link

codecov-public-qa bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 97.45%. Comparing base (bcec347) to head (69c72ae).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
- Coverage   97.48%   97.45%   -0.03%     
==========================================
  Files         395      395              
  Lines       33376    33385       +9     
==========================================
  Hits        32536    32536              
- Misses        840      849       +9     
Flag Coverage Δ
integration 97.45% <42.85%> (-0.03%) ⬇️
latest-uploader-overall 97.45% <42.85%> (-0.03%) ⬇️
unit 97.45% <42.85%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.77% <40.00%> (-0.07%) ⬇️
OutsideTasks 97.55% <33.33%> (-0.04%) ⬇️
Files Coverage Δ
services/report/parser/__init__.py 100.00% <100.00%> (+11.11%) ⬆️
tasks/tests/unit/test_upload_processing_task.py 100.00% <100.00%> (ø)
helpers/parallel_upload_processing.py 15.09% <0.00%> (-0.30%) ⬇️
tasks/upload_processor.py 92.34% <60.00%> (-0.52%) ⬇️
services/report/__init__.py 92.27% <33.33%> (-1.69%) ⬇️

joseph-sentry
joseph-sentry previously approved these changes Apr 25, 2024
@daniel-codecov daniel-codecov added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit c71ddfd Apr 25, 2024
14 of 30 checks passed
@daniel-codecov daniel-codecov deleted the daniel/save-raw-reports-for-parallel-experiment branch April 25, 2024 20:08
Copy link

sentry-io bot commented Apr 29, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ SSLError: HTTPSConnectionPool(host='storage.googleapis.com', port=443): Max retries exceeded with url: /upl... app.tasks.upload.UploadProcessor View Issue
  • ‼️ SSLError: HTTPSConnectionPool(host='storage.googleapis.com', port=443): Max retries exceeded with url: /upl... app.tasks.upload.UploadProcessor View Issue
  • ‼️ RequestRangeNotSatisfiable: GET https://storage.googleapis.com/download/storage/v1/b/codecov-dd-minio/o/v4%2Fraw%2F2024-05-08... app.tasks.upload.UploadProcessor View Issue
  • ‼️ AttributeError: 'NoneType' object has no attribute 'storage_path' app.tasks.upload.UploadProcessor View Issue
  • ‼️ SSLError: [SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC] decryption failed or bad record mac (_ssl.c:2559) app.tasks.upload.UploadProcessor View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants