1576 use users measurements #441
Conversation
| @@ -328,6 +330,24 @@ def create_report_upload( | |||
| flags = normalized_arguments.get("flags") | |||
| flags = flags.split(",") if flags else [] | |||
| self._attach_flags_to_upload(upload, flags) | |||
|
|
|||
There was a problem hiding this comment.
This was done here and not in the base class to only target Coverage type reports
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 430 430
Lines 34293 34299 +6
=======================================
+ Hits 33392 33398 +6
Misses 901 901
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 97.34% 97.34%
=======================================
Files 399 399
Lines 33603 33609 +6
=======================================
+ Hits 32711 32717 +6
Misses 892 892
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 97.34% 97.34%
=======================================
Files 399 399
Lines 33603 33609 +6
=======================================
+ Hits 32711 32717 +6
Misses 892 892
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 97.34% 97.34%
=======================================
Files 399 399
Lines 33603 33609 +6
=======================================
+ Hits 32711 32717 +6
Misses 892 892
Flags with carried forward coverage won't be shown. Click here to find out more.
|
requirements.txt
Outdated
| @@ -1,5 +1,5 @@ | |||
| # | |||
| # This file is autogenerated by pip-compile with Python 3.12 | |||
| # This file is autogenerated by pip-compile with Python 3.9 | |||
There was a problem hiding this comment.
oops, gonna have to redo this one!
There was a problem hiding this comment.
💀 a battle fought but done!
Finally. This is the PR where we get to use the measurements partition table on worker - API one here codecov/codecov-api#539.
Basically, we're inserting upload records on the user measurements table when we insert an upload. For this repo, that happens on the Legacy endpoint where we create an upload record preemptively. We're replacing the setting/reading with the insert_user_measurements and query_user_measurements methods.
On top of that, I'm getting rid of the previous implementation/query that took ages as that's no longer needed. I'm deleting, replacing or adjusting the tests we previously used to adjust to the new implementation.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.