Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to ts_telemetry #449

Merged
merged 1 commit into from
May 15, 2024

Conversation

michelletran-codecov
Copy link
Contributor

The reference to the ts_telemetry has been removed in the django apps in #443. We just need to remove referencing it in the migration script.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@michelletran-codecov michelletran-codecov requested a review from a team May 15, 2024 15:26
@codecov-notifications
Copy link

codecov-notifications bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #449   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         399      399           
  Lines       33607    33607           
=======================================
  Hits        32715    32715           
  Misses        892      892           
Flag Coverage Δ
integration 97.34% <ø> (ø)
latest-uploader-overall 97.34% <ø> (ø)
unit 97.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <ø> (ø)
OutsideTasks 97.50% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (966d2e8) to head (119a1a5).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #449   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         399      399           
  Lines       33607    33607           
=======================================
  Hits        32715    32715           
  Misses        892      892           
Flag Coverage Δ
integration 97.34% <ø> (ø)
latest-uploader-overall 97.34% <ø> (ø)
unit 97.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <ø> (ø)
OutsideTasks 97.50% <ø> (ø)

Copy link

codecov-public-qa bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (966d2e8) to head (119a1a5).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #449   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         399      399           
  Lines       33607    33607           
=======================================
  Hits        32715    32715           
  Misses        892      892           
Flag Coverage Δ
integration 97.34% <ø> (ø)
latest-uploader-overall 97.34% <ø> (ø)
unit 97.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <ø> (ø)
OutsideTasks 97.50% <ø> (ø)

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (966d2e8) to head (119a1a5).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #449   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files         430      430           
  Lines       34297    34297           
=======================================
  Hits        33396    33396           
  Misses        901      901           
Flag Coverage Δ
integration 97.34% <ø> (ø)
latest-uploader-overall 97.34% <ø> (ø)
unit 97.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.60% <ø> (ø)
OutsideTasks 97.50% <ø> (ø)

This change has been scanned for critical changes. Learn more

@michelletran-codecov michelletran-codecov added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 0c7829b May 15, 2024
29 checks passed
@michelletran-codecov michelletran-codecov deleted the fix_staging_ts_telemetry branch May 15, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants