Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update HeaderSectionWriter to link to head_report #460

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

nora-codecov
Copy link
Contributor

codecov/engineering-team#1573

the link was to the pull, should be to the commit

@codecov-notifications
Copy link

codecov-notifications bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
- Coverage   97.34%   97.34%   -0.01%     
==========================================
  Files         407      407              
  Lines       33830    33829       -1     
==========================================
- Hits        32932    32931       -1     
  Misses        898      898              
Flag Coverage Δ
integration 97.34% <ø> (-0.01%) ⬇️
latest-uploader-overall 97.34% <ø> (-0.01%) ⬇️
unit 97.34% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.57% <ø> (-0.01%) ⬇️
OutsideTasks 97.49% <ø> (-0.01%) ⬇️
Files Coverage Δ
.../notification/notifiers/mixins/message/__init__.py 100.00% <ø> (ø)
.../notification/notifiers/mixins/message/sections.py 97.01% <ø> (ø)
...cation/notifiers/tests/integration/test_comment.py 93.03% <ø> (ø)
...s/notification/notifiers/tests/unit/test_checks.py 98.26% <ø> (ø)
.../notification/notifiers/tests/unit/test_comment.py 99.22% <ø> (ø)
tasks/tests/integration/test_notify_task.py 100.00% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (2637eef) to head (f0b4dbb).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
- Coverage   97.34%   97.34%   -0.01%     
==========================================
  Files         407      407              
  Lines       33830    33829       -1     
==========================================
- Hits        32932    32931       -1     
  Misses        898      898              
Flag Coverage Δ
integration 97.34% <ø> (-0.01%) ⬇️
latest-uploader-overall 97.34% <ø> (-0.01%) ⬇️
unit 97.34% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.57% <ø> (-0.01%) ⬇️
OutsideTasks 97.49% <ø> (-0.01%) ⬇️
Files Coverage Δ
.../notification/notifiers/mixins/message/__init__.py 100.00% <ø> (ø)
.../notification/notifiers/mixins/message/sections.py 97.01% <ø> (ø)
...cation/notifiers/tests/integration/test_comment.py 93.03% <ø> (ø)
...s/notification/notifiers/tests/unit/test_checks.py 98.26% <ø> (ø)
.../notification/notifiers/tests/unit/test_comment.py 99.22% <ø> (ø)
tasks/tests/integration/test_notify_task.py 100.00% <ø> (ø)

Copy link

codecov-public-qa bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (2637eef) to head (f0b4dbb).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
- Coverage   97.34%   97.34%   -0.01%     
==========================================
  Files         407      407              
  Lines       33830    33829       -1     
==========================================
- Hits        32932    32931       -1     
  Misses        898      898              
Flag Coverage Δ
integration 97.34% <ø> (-0.01%) ⬇️
latest-uploader-overall 97.34% <ø> (-0.01%) ⬇️
unit 97.34% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.57% <ø> (-0.01%) ⬇️
OutsideTasks 97.49% <ø> (-0.01%) ⬇️
Files Coverage Δ
.../notification/notifiers/mixins/message/__init__.py 100.00% <ø> (ø)
.../notification/notifiers/mixins/message/sections.py 97.01% <ø> (ø)
...cation/notifiers/tests/integration/test_comment.py 93.03% <ø> (ø)
...s/notification/notifiers/tests/unit/test_checks.py 98.26% <ø> (ø)
.../notification/notifiers/tests/unit/test_comment.py 99.22% <ø> (ø)
tasks/tests/integration/test_notify_task.py 100.00% <ø> (ø)

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (2637eef) to head (f0b4dbb).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
- Coverage   97.37%   97.37%   -0.01%     
==========================================
  Files         439      439              
  Lines       34585    34584       -1     
==========================================
- Hits        33678    33677       -1     
  Misses        907      907              
Flag Coverage Δ
integration 97.34% <ø> (-0.01%) ⬇️
latest-uploader-overall 97.34% <ø> (-0.01%) ⬇️
unit 97.34% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.62% <ø> (-0.01%) ⬇️
OutsideTasks 97.49% <ø> (-0.01%) ⬇️
Files Coverage Δ
.../notification/notifiers/mixins/message/__init__.py 100.00% <ø> (ø)
.../notification/notifiers/mixins/message/sections.py 96.14% <ø> (ø)
...cation/notifiers/tests/integration/test_comment.py 93.03% <ø> (ø)
...s/notification/notifiers/tests/unit/test_checks.py 98.26% <ø> (ø)
.../notification/notifiers/tests/unit/test_comment.py 99.27% <ø> (ø)
tasks/tests/integration/test_notify_task.py 100.00% <ø> (ø)
Related Entrypoints
run/app.tasks.notify.Notify

@nora-codecov nora-codecov added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit b452181 May 23, 2024
40 of 43 checks passed
@nora-codecov nora-codecov deleted the nora/1573 branch May 23, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants