Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get all tests passing on local #461

Merged
merged 1 commit into from
May 22, 2024
Merged

get all tests passing on local #461

merged 1 commit into from
May 22, 2024

Conversation

nora-codecov
Copy link
Contributor

These tests are consistently failing on my local but they passing when they run in CI.
This fix allows them to pass on my local

@codecov-notifications
Copy link

codecov-notifications bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         407      407           
  Lines       33830    33834    +4     
=======================================
+ Hits        32932    32936    +4     
  Misses        898      898           
Flag Coverage Δ
integration 97.34% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.34% <100.00%> (+<0.01%) ⬆️
unit 97.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.57% <ø> (ø)
OutsideTasks 97.49% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
conftest.py 95.00% <100.00%> (+0.03%) ⬆️
helpers/tests/unit/test_environment.py 100.00% <100.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (2637eef) to head (9f55c61).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         407      407           
  Lines       33830    33834    +4     
=======================================
+ Hits        32932    32936    +4     
  Misses        898      898           
Flag Coverage Δ
integration 97.34% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.34% <100.00%> (+<0.01%) ⬆️
unit 97.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.57% <ø> (ø)
OutsideTasks 97.49% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
conftest.py 95.00% <100.00%> (+0.03%) ⬆️
helpers/tests/unit/test_environment.py 100.00% <100.00%> (ø)

Copy link

codecov-public-qa bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (2637eef) to head (9f55c61).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         407      407           
  Lines       33830    33834    +4     
=======================================
+ Hits        32932    32936    +4     
  Misses        898      898           
Flag Coverage Δ
integration 97.34% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.34% <100.00%> (+<0.01%) ⬆️
unit 97.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.57% <ø> (ø)
OutsideTasks 97.49% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
conftest.py 95.00% <100.00%> (+0.03%) ⬆️
helpers/tests/unit/test_environment.py 100.00% <100.00%> (ø)

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (2637eef) to head (9f55c61).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files         439      439           
  Lines       34585    34589    +4     
=======================================
+ Hits        33678    33682    +4     
  Misses        907      907           
Flag Coverage Δ
integration 97.34% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.34% <100.00%> (+<0.01%) ⬆️
unit 97.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.62% <ø> (ø)
OutsideTasks 97.49% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
conftest.py 95.00% <100.00%> (+0.03%) ⬆️
helpers/tests/unit/test_environment.py 100.00% <100.00%> (ø)

This change has been scanned for critical changes. Learn more

@nora-codecov nora-codecov added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 6482d2b May 22, 2024
29 of 30 checks passed
@nora-codecov nora-codecov deleted the nora/fix-local-tests branch May 22, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants