Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the embroider group with 3 updates #991

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 16, 2023

Bumps the embroider group with 3 updates: @embroider/compat, @embroider/router and @embroider/webpack.

Updates @embroider/compat from 3.2.3 to 3.3.1

Release notes

Sourced from @​embroider/compat's releases.

v3.3.1-compat

Release (2023-11-15)

@​embroider/compat 3.3.1 (patch) @​embroider/core 3.4.1 (patch)

🐛 Bug Fix

  • core
    • #1664 reorder extension precedence when searching app-js and fastboot-js trees (@​ef4)
    • #1661 Fix html clearing on rebuild (@​ef4)

🏠 Internal

  • Other
  • compat, core
    • #1663 adjust moved-package-target for namespaced packages (@​ef4)

Committers: 2

Changelog

Sourced from @​embroider/compat's changelog.

Embroider Changelog

Release (2023-11-15)

@​embroider/compat 3.3.1 (patch) @​embroider/core 3.4.1 (patch)

🐛 Bug Fix

  • core
    • #1664 reorder extension precedence when searching app-js and fastboot-js trees (@​ef4)
    • #1661 Fix html clearing on rebuild (@​ef4)

🏠 Internal

  • Other
  • compat, core
    • #1663 adjust moved-package-target for namespaced packages (@​ef4)

Committers: 2

Release (2023-11-11)

@​embroider/addon-dev 4.1.2 (patch) @​embroider/addon-shim 1.8.7 (patch) @​embroider/babel-loader-9 3.1.1 (patch) @​embroider/compat 3.3.0 (minor) @​embroider/core 3.4.0 (minor) @​embroider/hbs-loader 3.0.3 (patch) @​embroider/macros 1.13.3 (patch) @​embroider/router 2.1.5 (patch) @​embroider/shared-internals 2.5.1 (patch) @​embroider/test-setup 3.0.3 (patch) @​embroider/util 1.12.1 (patch) @​embroider/vite 0.2.0 (minor) @​embroider/webpack 3.2.1 (patch)

🚀 Enhancement

🐛 Bug Fix

... (truncated)

Commits

Updates @embroider/router from 2.1.4 to 2.1.5

Changelog

Sourced from @​embroider/router's changelog.

Embroider Changelog

Release (2023-11-15)

@​embroider/compat 3.3.1 (patch) @​embroider/core 3.4.1 (patch)

🐛 Bug Fix

  • core
    • #1664 reorder extension precedence when searching app-js and fastboot-js trees (@​ef4)
    • #1661 Fix html clearing on rebuild (@​ef4)

🏠 Internal

  • Other
  • compat, core
    • #1663 adjust moved-package-target for namespaced packages (@​ef4)

Committers: 2

Release (2023-11-11)

@​embroider/addon-dev 4.1.2 (patch) @​embroider/addon-shim 1.8.7 (patch) @​embroider/babel-loader-9 3.1.1 (patch) @​embroider/compat 3.3.0 (minor) @​embroider/core 3.4.0 (minor) @​embroider/hbs-loader 3.0.3 (patch) @​embroider/macros 1.13.3 (patch) @​embroider/router 2.1.5 (patch) @​embroider/shared-internals 2.5.1 (patch) @​embroider/test-setup 3.0.3 (patch) @​embroider/util 1.12.1 (patch) @​embroider/vite 0.2.0 (minor) @​embroider/webpack 3.2.1 (patch)

🚀 Enhancement

🐛 Bug Fix

... (truncated)

Commits

Updates @embroider/webpack from 3.2.0 to 3.2.1

Changelog

Sourced from @​embroider/webpack's changelog.

Embroider Changelog

Release (2023-11-15)

@​embroider/compat 3.3.1 (patch) @​embroider/core 3.4.1 (patch)

🐛 Bug Fix

  • core
    • #1664 reorder extension precedence when searching app-js and fastboot-js trees (@​ef4)
    • #1661 Fix html clearing on rebuild (@​ef4)

🏠 Internal

  • Other
  • compat, core
    • #1663 adjust moved-package-target for namespaced packages (@​ef4)

Committers: 2

Release (2023-11-11)

@​embroider/addon-dev 4.1.2 (patch) @​embroider/addon-shim 1.8.7 (patch) @​embroider/babel-loader-9 3.1.1 (patch) @​embroider/compat 3.3.0 (minor) @​embroider/core 3.4.0 (minor) @​embroider/hbs-loader 3.0.3 (patch) @​embroider/macros 1.13.3 (patch) @​embroider/router 2.1.5 (patch) @​embroider/shared-internals 2.5.1 (patch) @​embroider/test-setup 3.0.3 (patch) @​embroider/util 1.12.1 (patch) @​embroider/vite 0.2.0 (minor) @​embroider/webpack 3.2.1 (patch)

🚀 Enhancement

🐛 Bug Fix

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Copy link

github-actions bot commented Nov 16, 2023

Test Results

    1 files  ±0      1 suites  ±0   3m 26s ⏱️ -1s
297 tests ±0  296 ✔️ ±0  1 💤 ±0  0 ±0 
302 runs  ±0  301 ✔️ ±0  1 💤 ±0  0 ±0 

Results for commit 2b5c783. ± Comparison against base commit f5346b1.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f5346b1) 75.18% compared to head (2b5c783) 75.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #991   +/-   ##
=======================================
  Coverage   75.18%   75.18%           
=======================================
  Files         368      368           
  Lines        3385     3385           
  Branches      321      321           
=======================================
  Hits         2545     2545           
  Misses        734      734           
  Partials      106      106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohitpaulk
Copy link
Member

Hey @VasylMarchuk! Could you look at this PR please? There are a couple of test failures that seem related to the libraries being upgraded here

@VasylMarchuk
Copy link
Collaborator

I have rebased this PR on recent master and added two extra await settled calls next to await animationsSettled calls in the failing test, this seems to fix it. @rohitpaulk

dependabot bot and others added 2 commits November 22, 2023 11:32
Bumps the embroider group with 3 updates: [@embroider/compat](https://github.com/embroider-build/embroider/tree/HEAD/packages/compat), [@embroider/router](https://github.com/embroider-build/embroider/tree/HEAD/packages/router) and [@embroider/webpack](https://github.com/embroider-build/embroider/tree/HEAD/packages/webpack).


Updates `@embroider/compat` from 3.2.3 to 3.3.1
- [Release notes](https://github.com/embroider-build/embroider/releases)
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md)
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/compat)

Updates `@embroider/router` from 2.1.4 to 2.1.5
- [Release notes](https://github.com/embroider-build/embroider/releases)
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md)
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/router)

Updates `@embroider/webpack` from 3.2.0 to 3.2.1
- [Release notes](https://github.com/embroider-build/embroider/releases)
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md)
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/webpack)

---
updated-dependencies:
- dependency-name: "@embroider/compat"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: embroider
- dependency-name: "@embroider/router"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: embroider
- dependency-name: "@embroider/webpack"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: embroider
...

Signed-off-by: dependabot[bot] <support@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants