feat: update "received RESP value" log to print data types too

codecrafters-io · May 28, 2024 · 90b2d6f · 90b2d6f
1 parent 0d508c0
commit 90b2d6f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/internal/instrumented_resp_connection/instrumented_resp_connection.go b/internal/instrumented_resp_connection/instrumented_resp_connection.go
@@ -28,7 +28,9 @@ func defaultCallbacks(stageHarness *test_case_harness.TestCaseHarness, logPrefix
 			stageHarness.Logger.Debugf("%sReceived bytes: %q", logPrefix, string(bytes))
 		},
 		AfterReadValue: func(value resp_value.Value) {
-			stageHarness.Logger.Debugf("%sReceived RESP value: %s", logPrefix, value.FormattedString())
+			valueTypeLowerCase := strings.ReplaceAll(strings.ToLower(value.Type), "_", " ")
+			stageHarness.Logger.Debugf("%sReceived RESP %s: %s", logPrefix, valueTypeLowerCase, value.FormattedString())
+
 		},
 	}
 }

diff --git a/internal/resp/value/value.go b/internal/resp/value/value.go
@@ -113,7 +113,7 @@ func (v *Value) FormattedString() string {
 	case ERROR:
 		return fmt.Sprintf("%q", "ERR: "+v.String())
 	case NIL:
-		return "NIL"
+		return "$-1\\r\\n"
 	}
 
 	return ""