CC-1299: Update RESP framework to accomodate Transaction tests elegantly #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new `OrderedArrayAssertion` struct to the `resp_assertions` package. This assertion is used to compare the order of actual and expected values in an array. It checks that the length of the actual array matches the expected length, and then iterates through each element to compare their types and values. If any element does not match, an error is returned. The `OrderedArrayAssertion` is useful for cases where the order of elements in an array matters, such as when comparing the response of a Redis command.
The `Value` struct in the `value.go` file has been updated to include a new `bytes` field. This field is used to store the byte representation of the value. The `NewNilValue` function has also been updated to set the `bytes` field to `[]byte("$-1\r\n")`.
The `testTxMulti` function in the `test_txn_11.go` file has been refactored to use the `MultiCommandTestCase` struct for executing multiple transactions. This change improves code readability and maintainability by encapsulating the commands and assertions within a single test case object.
The `testTxDiscard` function in the `test_txn_9.go` file has been refactored to use the `MultiCommandTestCase` struct for executing multiple commands within a transaction. This change improves code readability and maintainability by encapsulating the commands and assertions within a single test case object.
|
Lint is failing due to unused high level test functions. (The stage level methods). |
Use MultiCommandTestCase for testTxIncr1, testTxIncr2, and testTxIncr3
This commit adds the testTxMulti function to the internal package. The function sets up a Redis executable and creates an instrumented RESP connection. It then runs a command test case using the MULTI command with no arguments, asserting that the response is "OK".
This commit adds the testTxEmpty function to the internal package. The function tests an empty transaction by running a Redis executable and executing various test cases. It includes assertions for error handling and ensures that the EXEC command without MULTI returns an error.
This commit adds the `testTxQueue` function to the internal package. The function sets up a Redis executable and creates two instrumented RESP connections. It then runs a transaction test case, followed by a command test case. This new function will be used for testing the transaction queue functionality.
This commit adds the `testTxExec` function to the internal package. The function sets up a Redis executable, creates an instrumented RESP connection, and runs a test case for the `EXEC` command.
…card
- Added support for multiple clients in the functions `testTxErr`, `testTxSuccess`, and `testTxDiscard`.
- Each client is created with a unique name using the format "client-{index+1}".
- The clients are stored in an array for later use.
- The clients are closed using the `Close` method before returning from the function.
This commit adds the `spawnClients` function. The `spawnClients` function is responsible for creating a specified number of client connections to a given address. It takes in the number of clients, address, stage harness, and logger as parameters. The function creates the clients and appends them to a slice before returning it. This new function is used in multiple places throughout the codebase to create client connections.
- Renamed the `spawnClients` function to `SpawnClients` - Added documentation for the `SpawnClients` function, explaining its purpose and usage - The `SpawnClients` function creates multiple clients connected to a given address using the `instrumented_resp_connection.NewFromAddr` function - Clients are expected to be closed after use
This commit adds new test cases for transaction functionality. The added test cases cover various stages of transactions, including INCR, MULTI, EXEC, and more. These tests ensure that the transaction functionality is working as expected. - Added new test cases for transaction functionality - Covered stages such as INCR-1, INCR-2, INCR-3, MULTI, EXEC, Empty Transaction, Queueing Commands - Ensured proper execution and handling of failed transactions
ryan-gang
changed the title
This commit renames several files in the internal directory for better clarity and organization. The changes include renaming `test_txn_9.go` to `test_txn_discard.go`, `test_txn_11.go` to `test_txn_multi_tx.go`, `test_txn_8.go` to `test_txn_tx.go`, and `test_txn_10.go` to `test_txn_tx_failure.go`. These file name updates improve the readability and maintainability of the codebase.
- Skip execution of transaction commands - Use `RunAll` instead of `RunMulti` and `RunQueueAll` - Update result array for each transaction command
rohitpaulk
reviewed
Jun 13, 2024
rohitpaulk
reviewed
Jun 13, 2024
rohitpaulk
reviewed
Jun 13, 2024
rohitpaulk
reviewed
Jun 13, 2024
rohitpaulk
reviewed
Jun 13, 2024
rohitpaulk
requested changes
Jun 13, 2024
- Removed the ShouldSkipExec flag from the TransactionTestCase struct - Renamed the RunAll method to RunWithoutExec in the TransactionTestCase struct - Updated test_txn_discard.go, test_txn_multi.go, test_txn_multi_tx.go, and test_txn_queue.go to use the RunWithoutExec method instead of RunAll
This commit adds a new test case to the `testTxErr` function in `internal/test_txn_tx_failure.go`. The test case includes commands to set random values for two keys, and then increment those values within a transaction. The expected result is an error value indicating that the value is not an integer or out of range, followed by the incremented value. After running the transaction, there are assertions to check if the values were updated correctly. The purpose of this change is to ensure that transactions handle errors properly and provide accurate results when dealing with non-integer values.
This commit adds a new transaction test case to the `testTxSuccess` function in `internal/test_txn_tx.go`. The test case includes commands for setting random keys with random integer values, incrementing the values, and retrieving them. The expected results are updated accordingly. Additionally, a command test case is added to verify the final value of one of the keys.
This commit adds the functionality to generate random keys for test cases in `test_txn_incr1.go`, `test_txn_incr2.go`, and `test_txn_incr3.go`. The generated keys are used in the `SET` and `INCR` commands. This change improves the flexibility and randomness of the test cases.
This commit adds new test cases to the `testTxDiscard` function in `internal/test_txn_discard.go`. The changes include: - Importing the `fmt` package - Generating unique keys using the `random.RandomWords` function - Generating random integers using the `random.RandomInt` function - Modifying the command arguments to use the generated keys and random integers - Updating assertions to use the generated values These changes enhance the test coverage for transaction discards.
- In test_txn_discard, changed the number of uniqueKeys generated from 3 to 2. - In test_txn_multi_tx, updated the commands to set key2 with a random integer value and increment key1. - Also added a comment explaining the expected result in each transaction. - In test_txn_queue, updated the command to set a random key with a random integer value and increment it.
CC-1299: Implement Transactions extension tests
- Refactor MultiCommandTestCase error message - Update TransactionTestCase comment and variable names - Modify logger debug message in RunQueueAll function - Rename ResultArray to ExpectedResponseArray
…ions Update tests accordingly
|
@rohitpaulk, I have merged the stage implementations to this branch. |
rohitpaulk
reviewed
Jun 14, 2024
rohitpaulk
reviewed
Jun 14, 2024
rohitpaulk
reviewed
Jun 14, 2024
rohitpaulk
approved these changes
Jun 14, 2024
Co-authored-by: Paul Kuruvilla <rohitpaulk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to the
Makefileand several files in theinternalpackage to improve the testing and handling of Redis commands. The primary changes include the removal and addition of several test cases in theMakefile, the addition of new methods and changes in theinternal/resp/value/value.gofile for handling integer and nil values, and the introduction of new files for handling RESP assertions and test cases.Changes to
Makefile:test_with_redisandtest_tmptargets in thebuildsection.test_all_with_redistotest_devand addedtest_base_with_redis,test_repl_with_redis, andtest_txn_with_redistargets.test_devtotest_txn_with_redisand addedtest_all_with_redistarget in thetest_streams_with_redis: buildsection.Changes to
internal/resp/value/value.go:bytesfield toNewIntegerValuefunction to convert integer to byte array.bytesfield toNewNilValuefunction to represent nil value in RESP.Errormethod toValuestruct to convert the value to a string.New files and changes in
internalpackage:error_assertion.goto define and run error assertions in RESP.ordered_array_assertion.goto define and run ordered array assertions in RESP.multi_command_test_case.goto define and run multiple SendCommandTestCase.transaction_test_case.goto define and run transaction test cases in RESP.Changes to test fixtures:
expiry/passandrdb-read-value-with-expiry/passfixtures. [1] [2]Changes to test cases:
transactions_passtest case inTestStagesfunction instages_test.go.