CC-1249: Colorize first differing bytes in Visualize method #31
Conversation
| } | ||
| } | ||
|
|
||
| func formatAsciiWithColorizedByteHelper(value []byte, i int, firstDiffIndex int, end int, chosenColor color.Attribute) string { |
There was a problem hiding this comment.
@ryan-gang there's still a bunch of complexity here around byte indexes - the main reason for all of this seems to be that we're using formatBytesAsHex instead of formatByteAsHex. Would things be simpler if we were printing out byte-by-byte instead of constructing a whole line at once and then having to mutate it?
This is certainly cleaner than what we were doing to the TabWriter output, but I think it can be far simpler. Good enough to merge, but I'd suggest giving this another go if you're looking to practice code design skills - good opportunity!
There was a problem hiding this comment.
Merging this for now, will work on the other implementation separately.
We can actually inline all the hex and ASCII conversion, to make this simpler, that way we can go byte-by-byte as you mentioned.
No description provided.