Fixed missing offset property default

codecruisedor · Jul 5, 2023 · 31d22f2 · 31d22f2
1 parent ed403b2
commit 31d22f2
Show file tree

Hide file tree

Showing 11 changed files with 7 additions and 8 deletions.
diff --git a/src/engraving/libmscore/letring.cpp b/src/engraving/libmscore/letring.cpp
@@ -143,6 +143,7 @@ PropertyValue LetRing::propertyDefault(Pid propertyId) const
     case Pid::LINE_VISIBLE:
         return true;
 
+    case Pid::BEGIN_TEXT_OFFSET:
     case Pid::CONTINUE_TEXT_OFFSET:
     case Pid::END_TEXT_OFFSET:
         return PropertyValue::fromValue(PointF(0, 0));

diff --git a/src/engraving/libmscore/palmmute.cpp b/src/engraving/libmscore/palmmute.cpp
@@ -167,6 +167,7 @@ PropertyValue PalmMute::propertyDefault(Pid propertyId) const
     case Pid::LINE_VISIBLE:
         return true;
 
+    case Pid::BEGIN_TEXT_OFFSET:
     case Pid::CONTINUE_TEXT_OFFSET:
     case Pid::END_TEXT_OFFSET:
         return PropertyValue::fromValue(PointF(0, 0));

diff --git a/src/engraving/libmscore/pedal.cpp b/src/engraving/libmscore/pedal.cpp
@@ -146,6 +146,11 @@ engraving::PropertyValue Pedal::propertyDefault(Pid propertyId) const
     case Pid::END_TEXT_PLACE:
         return TextPlace::LEFT;
 
+    case Pid::BEGIN_TEXT_OFFSET:
+    case Pid::CONTINUE_TEXT_OFFSET:
+    case Pid::END_TEXT_OFFSET:
+        return PropertyValue::fromValue(PointF(0, 0));
+
     case Pid::BEGIN_HOOK_TYPE:
     case Pid::END_HOOK_TYPE:
         return HookType::NONE;

diff --git a/src/importexport/guitarpro/tests/data/let-ring.gp-ref.mscx b/src/importexport/guitarpro/tests/data/let-ring.gp-ref.mscx
@@ -94,7 +94,6 @@
             </Tempo>
           <Spanner type="LetRing">
             <LetRing>
-              <beginTextOffset x="0" y="0"/>
               </LetRing>
             <next>
               <location>

diff --git a/src/importexport/guitarpro/tests/data/let-ring.gp4-ref.mscx b/src/importexport/guitarpro/tests/data/let-ring.gp4-ref.mscx
@@ -94,7 +94,6 @@
             </Dynamic>
           <Spanner type="LetRing">
             <LetRing>
-              <beginTextOffset x="0" y="0"/>
               </LetRing>
             <next>
               <location>

diff --git a/src/importexport/guitarpro/tests/data/let-ring.gp5-ref.mscx b/src/importexport/guitarpro/tests/data/let-ring.gp5-ref.mscx
@@ -90,7 +90,6 @@
             </Dynamic>
           <Spanner type="LetRing">
             <LetRing>
-              <beginTextOffset x="0" y="0"/>
               </LetRing>
             <next>
               <location>

diff --git a/src/importexport/guitarpro/tests/data/let-ring.gpx-ref.mscx b/src/importexport/guitarpro/tests/data/let-ring.gpx-ref.mscx
@@ -94,7 +94,6 @@
             </Tempo>
           <Spanner type="LetRing">
             <LetRing>
-              <beginTextOffset x="0" y="0"/>
               </LetRing>
             <next>
               <location>

diff --git a/src/importexport/guitarpro/tests/data/palm-mute.gp-ref.mscx b/src/importexport/guitarpro/tests/data/palm-mute.gp-ref.mscx
@@ -94,7 +94,6 @@
             </Tempo>
           <Spanner type="PalmMute">
             <PalmMute>
-              <beginTextOffset x="0" y="0"/>
               </PalmMute>
             <next>
               <location>

diff --git a/src/importexport/guitarpro/tests/data/palm-mute.gp4-ref.mscx b/src/importexport/guitarpro/tests/data/palm-mute.gp4-ref.mscx
@@ -94,7 +94,6 @@
             </Dynamic>
           <Spanner type="PalmMute">
             <PalmMute>
-              <beginTextOffset x="0" y="0"/>
               </PalmMute>
             <next>
               <location>

diff --git a/src/importexport/guitarpro/tests/data/palm-mute.gp5-ref.mscx b/src/importexport/guitarpro/tests/data/palm-mute.gp5-ref.mscx
@@ -90,7 +90,6 @@
             </Dynamic>
           <Spanner type="PalmMute">
             <PalmMute>
-              <beginTextOffset x="0" y="0"/>
               </PalmMute>
             <next>
               <location>

diff --git a/src/importexport/guitarpro/tests/data/palm-mute.gpx-ref.mscx b/src/importexport/guitarpro/tests/data/palm-mute.gpx-ref.mscx
@@ -94,7 +94,6 @@
             </Tempo>
           <Spanner type="PalmMute">
             <PalmMute>
-              <beginTextOffset x="0" y="0"/>
               </PalmMute>
             <next>
               <location>