Merge pull request musescore#18468 from RomanPudashkin/tremolo_crash

tremolo_crash
codecruisedor · Jul 7, 2023 · 3d1bd4b · 3d1bd4b
2 parents fe21a8c + c712bdf
commit 3d1bd4b
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 6 deletions.
diff --git a/src/engraving/libmscore/tremolo.cpp b/src/engraving/libmscore/tremolo.cpp
@@ -600,6 +600,26 @@ void Tremolo::triggerLayout() const
     }
 }
 
+bool Tremolo::needStartEditingAfterSelecting() const
+{
+    return twoNotes();
+}
+
+int Tremolo::gripsCount() const
+{
+    return twoNotes() ? 3 : 0;
+}
+
+Grip Tremolo::initialEditModeGrip() const
+{
+    return twoNotes() ? Grip::END : Grip::NO_GRIP;
+}
+
+Grip Tremolo::defaultGrip() const
+{
+    return twoNotes() ? Grip::MIDDLE : Grip::NO_GRIP;
+}
+
 //---------------------------------------------------------
 //   gripsPositions
 //---------------------------------------------------------

diff --git a/src/engraving/libmscore/tremolo.h b/src/engraving/libmscore/tremolo.h
@@ -132,15 +132,13 @@ class Tremolo final : public EngravingItem
     void setUp(bool up) { _up = up; }
 
     // only need grips for two-note trems
-    bool needStartEditingAfterSelecting() const override { return twoNotes(); }
-    int gripsCount() const override { return 3; }
-    Grip initialEditModeGrip() const override { return Grip::END; }
-    Grip defaultGrip() const override { return Grip::MIDDLE; }
+    bool needStartEditingAfterSelecting() const override;
+    int gripsCount() const override;
+    Grip initialEditModeGrip() const;
+    Grip defaultGrip() const override;
     std::vector<mu::PointF> gripsPositions(const EditData&) const override;
     bool isMovable() const override { return true; }
-    void startDrag(EditData&) override {}
     bool isEditable() const override { return true; }
-    void startEdit(EditData&) override {}
     void endEdit(EditData&) override;
     void editDrag(EditData&) override;